From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11095 invoked by alias); 22 Jul 2011 12:02:14 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 29585 Received: (qmail 3101 invoked from network); 22 Jul 2011 12:02:13 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 Received-SPF: pass (ns1.primenet.com.au: SPF record at _spf.google.com designates 209.85.160.171 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=TG04/umZFy60wNF3MqVqUY0fHW6gKYg7ph13tEXiLtI=; b=rCIVldI7vheRZaXH9rKl8xi+PFZ0jyqCWZjhCYQX418reGmTpJt01INep3AJzofPqs cyEcdz4Q/QgiiD94TinUSLCudZSI2Z/yRU/E3TYiHHdOfYfEX0craLshIehG6zIBbmWD 1p7aTxM/dvXyc/dIKMegL/o1Jp3umlg74P5as= MIME-Version: 1.0 Sender: nikolai.weibull@gmail.com In-Reply-To: <1309379833-31315-4-git-send-email-ft@bewatermyfriend.org> References: <1309211717-9650-1-git-send-email-ft@bewatermyfriend.org> <1309379833-31315-1-git-send-email-ft@bewatermyfriend.org> <1309379833-31315-4-git-send-email-ft@bewatermyfriend.org> Date: Fri, 22 Jul 2011 13:54:00 +0200 X-Google-Sender-Auth: uuDOAx988OQyhxVrI0qVq5s-moo Message-ID: Subject: Re: PATCH: (3/3) _git: re-add `user-commands' support again From: Nikolai Weibull To: Frank Terbeck Cc: zsh workers , Mikael Magnusson Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable I=E2=80=99m going to change the order of the tags to be main-porcelain-commands user-commands third-party-commands =E2=80=A6 I prefer =E2=80=9Cuser-commands=E2=80=9D as a tag name over =E2=80=9Cuser-s= pecific-commands=E2=80=9D as it matches the style name. My reasoning for this order is that you always want the main porcelain commands listed first. Then, any commands defined through the zstyle will most likely be of most interest to the user. Third-party commands are tricky, however, as their relevance to the user may or may not be high. I think having them before ancillary-manipulator-commands makes sense, but perhaps someone disagrees? On Wed, Jun 29, 2011 at 22:37, Frank Terbeck wrote= : > --- > =C2=A0Completion/Unix/Command/_git | =C2=A0 =C2=A04 ++++ > =C2=A01 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/Completion/Unix/Command/_git b/Completion/Unix/Command/_git > index ef97499..4567460 100644 > --- a/Completion/Unix/Command/_git > +++ b/Completion/Unix/Command/_git > @@ -4439,6 +4439,9 @@ __git_ignore_line_inside_arguments () { > > =C2=A0(( $+functions[_git_commands] )) || > =C2=A0_git_commands () { > + =C2=A0local -a user_commands > + =C2=A0zstyle -a ":completion:${curcontext}:" user-commands user_command= s || user_commands=3D() > + > =C2=A0 local -a main_porcelain_commands > =C2=A0 main_porcelain_commands=3D( > =C2=A0 =C2=A0 add:'add file contents to index' > @@ -4604,6 +4607,7 @@ _git_commands () { > =C2=A0 _describe -t plumbing-sync-helper-commands 'plumbing sync helper c= ommand' plumbing_sync_helper_commands && ret=3D0 > =C2=A0 _describe -t plumbing-internal-helper-commands 'plumbing internal = helper command' plumbing_internal_helper_commands && ret=3D0 > =C2=A0 _describe -t third-party-addons 'third party addon' _git_third_par= ty && ret=3D0 > + =C2=A0_describe -t user-specific-commands 'user specific command' user_= commands && ret=3D0 > =C2=A0 return ret > =C2=A0}