From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id e95e9fb9 for ; Mon, 25 Nov 2019 07:32:22 +0000 (UTC) Received: (qmail 26119 invoked by alias); 25 Nov 2019 07:32:15 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44929 Received: (qmail 8105 invoked by uid 1010); 25 Nov 2019 07:32:14 -0000 X-Qmail-Scanner-Diagnostics: from mail-io1-f66.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.0/25642. spamassassin: 3.4.2. Clear:RC:0(209.85.166.66):SA:0(-2.0/5.0):. Processed in 2.229194 secs); 25 Nov 2019 07:32:14 -0000 X-Envelope-From: mezin.alexander@gmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.166.66 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kLaLYKy20HBBWdWZXMr6lwMCQ0m4fybIXYozh04aJ5s=; b=a9GgcMWJ2DiAHL60hwq0k/j+Cy7NpZLUXawHafYoX3/IyZnWUrgf4Yj+zNxQ00TLXQ NnO5m8Y4mkoIrtd1+0wT5i78+Rwj4uzqzApJQ2XOSuzWIFcFytG1TYoqbM2Jm2bEmseF PRiIe1B85Y1o6ylE3rtLWj/MDrd6Y1cP1SsSVKb9jsGjg2UXGJ73aBwEGWsMDpcDKtLi i9rFqH4r3z/Oea5wagpMGhsYfsXoXUZYbKZbPlEWUB/CWjKoKw62e0n3E2DlBgKG41Vo HyhUuKxj0riGOSPGstPPY2wkmw9xGKuvUCpLsUrdBagCNmAZ8Vjfxs+ovkzolxMmY8ZU 94Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kLaLYKy20HBBWdWZXMr6lwMCQ0m4fybIXYozh04aJ5s=; b=ZoYDc0sZHoVxKT6QFHl0cPsdqQ/hjhAsyPr0uG3j6cinh7Qv1Ebp6f8UoI/WxO8kkO m+Dszxabw+g4+8i3R7lOcRLJfibUMZ9zj+WItnWkgZxrXQjEzHraN2U4XTdr3d5mFked lKxKcKel8x0mjbQ/VD++pavl2ije825l7kbAdx/IPNrUeCM6n3PW4Bz+Og+iZNE+TFFl f+hTOQygvepI21lReNsCTGs78fu/dlL6fDJ6/ZcEL6l8Z8M4e75nbyHDoJeYfYcSi2Oe cZQYpJ5RCWe4ZvFAvSsdMvewLiNwWav3tjx4J0qkcYwbyDYEVzXqu9v76blDT4/7ooCM py5A== X-Gm-Message-State: APjAAAXZHqokMV7xXhq4hAIwqbBk01xcB94VdixqDzk9ZMph2BCLS5iA 2YkOYuasG+AJZqJaos16Xmed/Pwl9TikBIV6j5U= X-Google-Smtp-Source: APXvYqyTsfJckUPHBN9zFjjMRrmeQKq2QJCPbK8pvwNgOwRY6x6gaP8TrZupiwBkHOBxDPvFOdAkKDEUoPmtN8U5c10= X-Received: by 2002:a05:6602:2181:: with SMTP id b1mr25422291iob.208.1574667098151; Sun, 24 Nov 2019 23:31:38 -0800 (PST) MIME-Version: 1.0 References: <20191123221443.279556-1-mezin.alexander@gmail.com> <20191123221443.279556-3-mezin.alexander@gmail.com> <20191125043525.lcxm532gi6hb7n53@tarpaulin.shahaf.local2> In-Reply-To: <20191125043525.lcxm532gi6hb7n53@tarpaulin.shahaf.local2> From: Aleksandr Mezin Date: Mon, 25 Nov 2019 13:31:27 +0600 Message-ID: Subject: Re: [PATCH 2/3] vcs_info/cvs: set vcs_comm[basedir] in VCS_INFO_detect_cvs To: Daniel Shahaf Cc: zsh-workers@zsh.org Content-Type: text/plain; charset="UTF-8" On Mon, Nov 25, 2019 at 10:35 AM Daniel Shahaf wrote: > > Aleksandr Mezin wrote on Sun, Nov 24, 2019 at 04:14:42 +0600: > > +++ b/Functions/VCS_Info/Backends/VCS_INFO_get_data_cvs > > @@ -5,11 +5,7 @@ > > -cvsbase="." > > -while [[ -d "${cvsbase}/../CVS" ]]; do > > - cvsbase="${cvsbase}/.." > > -done > > +++ b/Functions/VCS_Info/Backends/VCS_INFO_detect_cvs > > @@ -7,5 +7,12 @@ setopt localoptions NO_shwordsplit > > +local cvsbase="." > > +while [[ -d "${cvsbase}/../CVS" ]]; do > > + cvsbase="${cvsbase}/.." > > +done > > I know you just moved this code around, but I'd like to point out that it > causes an infinite loop when /CVS exists. Also I probably shouldn't have moved the code in the first place. If the current directory has `CVS/Repository` in it, it means that the directory is controlled by CVS, and maybe we shouldn't consider .git from the parent directory (even when the parent directory also has `CVS/Repository` in it). Though it's questionable. Example: ~/cvs-dir/CVS/Repository ~/cvs-dir/git-repo/.git ~/cvs-dir/git-repo/CVS/Repository ~/cvs-dir/git-repo/cvs-subdir/CVS/Repository I'm not sure what vcs_info should output for ~/cvs-dir/git-repo/cvs-subdir/ > > Cheers, > > Daniel