From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 20058 invoked from network); 1 Nov 2020 23:10:36 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 1 Nov 2020 23:10:36 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1604272236; b=Tpfk2ZiPEHb2fA0mcoMRKfNYl8iWWhn0l1oWMYHwSjhBiKE5UCwUASVYo6IeromxwFRX5cHMF0 Ef5C7/Wz0MOAI602cw5bY0aFLxnj1vH8+2fflIoaTz5Om1vIZ9ai9cDrSPziWWr/lzvnfV2Uaz wRyWobKt1Y2l0xghcDgVhCtPg+mR6u+fSWp/G7k/G2tXvp6PKIUNYAf31y7/HauVOn/w9aNb5H Pw0izgpIKmmccDIio/OX3lDwUUsljiWiiQqGXfGn+Dxu6sHYgAq1S8BFgnOa3l6Nu/fXU2tW98 4W8yNsEJXwHQT6he/rtHTm88jFFUr8IJ2Of5NEkKcjxQuQ==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-il1-f194.google.com) smtp.remote-ip=209.85.166.194; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1604272236; bh=P4/ZW16KdIGJ591/KXoU6l1vfJwLKbqTqfj240iDUGA=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=G2TQRQCVoE2phx0aJ9QXISc6UWVH7fyO152OVbg0UDCqWAXrAptMqYRvwzQOLX3Hwjv2ybI7wZ MfbCx+Dq98NiGEJv6oe5DtysuBujWpZGw+Sq0bdq133Hvgftu6+fakXlLTRS46IcwVw7s8G32N K80PRav6Pr1Qzl/suZzu/awnqBKiRNcso7fMkCc8u3zuiCDdD7Ab4w0+7TjtiZrrdKp+NLRPen msC8mjl/RzuTQYAh6TmuBiFEaUr3/WQHKCwTdzIukiN5PMLXUSwwqy1spkhCqWLJz13d18TkGk jNu/dTKuaBZyS4mMGZPqeI2TM9UMfIZIKwMZrv9ZT1LCMA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:To:Subject:Message-ID: Date:From:In-Reply-To:References:MIME-Version:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=SvB1fGc9EGqdWhJ4RltqIsfO4CmxrrAyVOk7E2XBGvk=; b=qEyE6w/f74iyymcep9jbkSyCb6 FxxLow4t0Hdjb5PePd9c5cpj80PC9UEAQ+agaaf3LO8pRN924KDqpN0c/wriq4ptzz+ECG7sC1Occ 9nqRzGjlMp7aq17rZU1XtscBJTAdbULmQkPo67sZRlRIvbh/FDl79OmkTP1F0F90NpOPXKZ1ovUye 48sGawaoHqUys7lFGM650/MRvMVJpfhd+KSP9khQKATfakDlVjRHQsUwk681amN9QYC310wwxnASf y/A6n7qk/p2xbT6DWUVsmuIV+/Xl7BSMSvVdURkMzs3HrRkcXBIhI1GCL/L7zfoHgq7AO+9ZPUPXg IADrAxLg==; Received: from authenticated user by zero.zsh.org with local id 1kZMUa-000Oiz-6y; Sun, 01 Nov 2020 23:10:32 +0000 Authentication-Results: zsh.org; iprev=pass (mail-il1-f194.google.com) smtp.remote-ip=209.85.166.194; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-il1-f194.google.com ([209.85.166.194]:39443) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1kZMTt-000LWJ-HB; Sun, 01 Nov 2020 23:09:55 +0000 Received: by mail-il1-f194.google.com with SMTP id q1so11361032ilt.6 for ; Sun, 01 Nov 2020 15:09:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=SvB1fGc9EGqdWhJ4RltqIsfO4CmxrrAyVOk7E2XBGvk=; b=a6oP3iZU7eDKvADDYzxLBHn5uHAzRnIMqBGAG7dfdcqm8VgE9EYgl4AnIPq/Fg7X9C m076xpCarrFxUvafrOk+/xR5cb4c1nfXf52t1XztMeXtLARM1vdybfHQErlob77NxVys og3P4DIxSg0ZiTTsKc0UqK8MmUlap1ELg55PnHtiet8bDDXeeO/1h6EVIy9gTwR5Wi+n iP0fd6G06UFfv3RK1ZrGsZqTO/sfaMQpJBu6iVD89KmnHNeAEVqClDPZxRuQa9JS2IAk NwXG0IeISYaHBe2tQf5TEPSHpk+L24UxBZv7qpgZXExCtexIfA1MHkTAsthSsOMRCwmZ kqwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=SvB1fGc9EGqdWhJ4RltqIsfO4CmxrrAyVOk7E2XBGvk=; b=CX4H/+511nQi7fFD1Zub+0hydhgKnEFgwF2xQxCZ0z1q98JGicVRzziw16WVTa7ZEq 5u/7MI1esLevf7HEjAhZL10zkAgmW4M72omrx1/Xpy0W30amxIgpzl/0B6ouG35lELoe pvL+AaE23x0EyI6Tg3R7BZNigY9haXgPXFCl8uLk1QsXbvGLj+r0nLa90Wu8a2biovbe ijVpAtq5YKVrWylXlo6KlRp5wMjMr0Q9lUMc2gskCMDnGir01CwBNyHwadAVNDz+rSne erIt6FuBJP4C/dRytIgPkglr32F1B5V3nz6wyupYiHO5USATKAE/s0s2ZfZ2GVb/m7kf 2P8g== X-Gm-Message-State: AOAM532zgVpvvaQ4qHgvUv4+gWcweWOUg/9oz1kBd0arKjQ5Wx0isXvl eQIPpUKBP6ac+cANTUxVgcrfXpNaSsGnzvUGsccBIxc/Wpv4vRFt X-Google-Smtp-Source: ABdhPJwf+26DPPfdRjkIKkLHmBdf+rlCkhgoaLe9f31yYTHg1DY8njO1rBRn3W+1h13YzHwxPvqHHPH9ICYfzOdEDuo= X-Received: by 2002:a05:6e02:786:: with SMTP id q6mr8866236ils.208.1604272187269; Sun, 01 Nov 2020 15:09:47 -0800 (PST) MIME-Version: 1.0 References: <20201029012755.253085-1-mezin.alexander@gmail.com> In-Reply-To: <20201029012755.253085-1-mezin.alexander@gmail.com> From: Aleksandr Mezin Date: Mon, 2 Nov 2020 05:09:36 +0600 Message-ID: Subject: Re: [RFC PATCH v3] vcs_info: choose backend by basedir To: zsh-workers@zsh.org Content-Type: text/plain; charset="UTF-8" X-Seq: 47515 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Archived-At: On Thu, Oct 29, 2020 at 7:28 AM Aleksandr Mezin wrote: > It's possible to revert to the old behavior of vcs_info, by setting: > > zstyle ':vcs_info:*' backend-choice enablement-order > Now I'm not sure if an "enum-like" zstyle is a good idea. 1) Should I check somewhere that the string value is valid (i.e. it's either empty, or one of the predefined strings)? 2) Extensibility: I don't think there will be another different mode that should be controlled by this zstyle. More likely, there will be parameters like "prefer non-ancestor vcs directories or not". And IMO they should have their own boolean zstyles, and not something like `backend-choice closest-vcs-dir-prefer-ancestors`. And even more likely, nobody will add anything there