From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 5533 invoked from network); 19 Jan 2021 01:52:54 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 19 Jan 2021 01:52:54 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1611021174; b=Cp7s+rI/WqO/U/Xwon2foHISrodGj8cYZElV99bXqXZTRjWEjGl2JGWFkcLGhkrp1mfrlBAQzf Tjpcd3XvvRjOtih8ReyHNxJUZiB6WCY2zttriMWLl/duQW0zGM2f5yh49ji8B+BggEY74xpH0f JXnEM01QKoFPoY9dpzY1gATA5YAp9+DEG2ZzJAOr6PR3Y60ZvSaS9MPevtl2UE2C1kCYHgj/ds UHeKYkjf1znXgph+abeI52b56eYhRdK2MC+cwsZP65hiGG/lHrVDw+0lRRpJBlml9OgEvyvqVK J3EXc2AQfE5/HMbW6OMxcmopwjnCGZ/t+CSMFM0TQUKLew==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-pj1-f41.google.com) smtp.remote-ip=209.85.216.41; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1611021174; bh=WkPbTpCfuQl4emO1vb4Dgioeg5mcxQca230mTOEjR+0=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:Cc:To:Subject: Message-ID:Date:From:In-Reply-To:References:MIME-Version:DKIM-Signature: DKIM-Signature; b=fH9jgXjbA0M1b8MHB/5J0HKY6Uus3jHcs3qaJeAAjqnWp22KscMQzARDQjNAc1W/cXasDZKeMZ F7iLcFzUBTfY+6UahE7SgcBliAZkyNpt6POFL46drNaOYS3ldgk7goyJ7rLp95BPSVZE4IbfFH f1a60hQHZ+XacedSD/FFwxLLmIZbS+X6UFOQjMv00uswLaz8/8P/GHrBdDk04wrbaA1P0Jh87m /khD0s0NLPy7YR1+0Oo1e00A7cLiCqLooGLaLY8njkCrkFP2UGxjEPPZpJzmjrDAN5GCwanmyg tT+g4HiWuC6KPWHXV2IxlA4DptQBA3A32dImd8OZ7OSihQ==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=zF/qKGwCDth+lMuZxSJWY1toEocgvarfS+a/J8j8jpI=; b=1ZFuDFzvR6v3xoF6LESYY0bUuE GPbU9vqDzO/YbytEcBNAJ8X0N/rHDhBrJ5C9RjprEktDEUlJf3jcAxUgQuZ+BzAQJMnvAwHFwB/f7 qJ3qiEtq0q9r+JfEuR4USjjxn6GNdzolwSc2uqq4eboyHNIR8ulixcdQrxd9FxonUud7cLaY9FFXg SxJ9ZS7paMLPZBnVFFw7KS5rIMN0U8zyUaLC6PjLBekfCnxZEGTj+YFqfjqnbTvsRJ8cPWwdu0WQh K6V7RtkcdEeCWN6Er44LYcdxoKOG2789s3cj6qkD3gMhkQ2qgD4JdQCUNRWB8hXQUHV0cr4gGad7I +YDy8TNQ==; Received: from authenticated user by zero.zsh.org with local id 1l1gCT-0003Mi-AO; Tue, 19 Jan 2021 01:52:53 +0000 Authentication-Results: zsh.org; iprev=pass (mail-pj1-f41.google.com) smtp.remote-ip=209.85.216.41; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-pj1-f41.google.com ([209.85.216.41]:52671) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1l1gC9-0003E0-S5; Tue, 19 Jan 2021 01:52:35 +0000 Received: by mail-pj1-f41.google.com with SMTP id kx7so1462797pjb.2 for ; Mon, 18 Jan 2021 17:52:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=zF/qKGwCDth+lMuZxSJWY1toEocgvarfS+a/J8j8jpI=; b=nRF7efSrpQuqnIOxF5uKOoryEgzjznODMK8hKMxeTFG7a3yaMhgRn4ay1JQ1id0/nZ HCqKSBQu0mhDOi1sRG2UfY1siUita3RNqM1BtJQpXcqk5eowreq8RvCIFfQgBnyLKB0i rydXr4Vm4m7RiDzMsgycQk0CjFj7O7ZPOPFRXOvlYgJIVa9rEHdn+nTP7FMQQULWS+i7 iUk+qg5bLhNSeNrj72Kv4BAugNiPtfDQ5VDpJGbTEC+5eSA9+l0WB/COgV4Bck/6S4sH nESUdSp9oMxMgSNlJOlX79u0GmPtuxSnixmHeTbA7IsD90zbktZ3hH0QabQbW9YKRs8z YeKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=zF/qKGwCDth+lMuZxSJWY1toEocgvarfS+a/J8j8jpI=; b=PruCBBsLkbpjvL/yoD4CxS195MNMydJCytYVQy7ywCsZZViu6+M5f/AuRuE4MtpEw/ lyzDYuvnjOlNq3gKuyQVQ/CCZG9GA2bnRQhjV7ULSzDY9WOhh+wzoFaPOlPOoPtuJ34C /BzdspHMysvzPzCxZ7YiELW3+oTvs0bsZp1PGi7kXoUlK4CZgpTyS3KN6scqtXTPhDJw AR4j8X3XEOMwBZXK4FCsYd7VhPfdJJauYgTfW7jygebxlNlMZr3rva3iz9Dl9jvASoXW s6dbVPOQ3PXS43PpWJHcwIe4RF/IuUYx2yu/U8tdueKNhrgb+aAE8FduW6smhNo0tAOE en2w== X-Gm-Message-State: AOAM530tEJsIhE/pw9k8DVg9Co1P1xXSRbTvtXV28XtYIiVTP1PsYjxX Lz7eJD8MLLo1mwcZXhDrRr3vcn81ybpjbf/KKWmBuY8/Jbo06g== X-Google-Smtp-Source: ABdhPJzT5LHoHPCVoV3YphjJEWwGaoClEMHWiyotoOEO3VZrHIKzxzcDN6VrNtUjwtrtzLrp/rLaSrdrrikGJoi/s/M= X-Received: by 2002:a17:90b:100f:: with SMTP id gm15mr2452786pjb.47.1611021152421; Mon, 18 Jan 2021 17:52:32 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Peiyuan Song Date: Tue, 19 Jan 2021 09:52:23 +0800 Message-ID: Subject: Re: [PATCH v2] Make zpty module work in the cygwin and msys2 To: Bart Schaefer Cc: "zsh-workers@zsh.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Seq: 47848 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Archived-At: Bart Schaefer =E4=BA=8E2021=E5=B9=B41=E6=9C=881= 7=E6=97=A5=E5=91=A8=E6=97=A5 =E4=B8=8A=E5=8D=882:34=E5=86=99=E9=81=93=EF=BC= =9A > > On Thu, Jan 14, 2021 at 8:30 PM Peiyuan Song wrote: > > > > v2 change: make fdtable[master] > > I don't see anything technically wrong with this, but it does > duplicate the code for check_fd_table. > > Anyone else have thoughts? Can someone else who compiles on cygwin > give this a once-over? I have upload v3 patch, remove duplicate the code for check_fd_table, use addmodulefd api. assume cygwin upstream issue will be fixed in version 3.2.0