From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-32556-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 28800 invoked by alias); 17 Apr 2014 08:58:35 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 32556
Received: (qmail 22871 invoked from network); 17 Apr 2014 08:58:20 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,HTML_MESSAGE,
	RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:mime-version:in-reply-to:references:date
         :message-id:subject:from:to:content-type;
        bh=wj6zBiIG4U/GGfLdieDgzjr9gMH+0gyKxgbetTbYKHM=;
        b=j4HkoQMH+pUko/Af+XV/kQklH6LYP4tdjBUcg8MiKBodEwpSr8StKBU4uVBUBsmnhp
         KZKD1H20QgiErbgJiwY3EbZ7u3ZmAFgYbgd/ugZkpMWA88IzhsW7xZ+F+DOdKhXR9qXb
         IwB+IOeNID3dPOpyx2lo5YHbDdq2Qe95q4oIDHGA30Fi7Sf3mGg5CFQZ+rRVhqtGoQkc
         bWue+gI6FSI8V4bv15nkMZPSQrBJw99pJimBd6uR7rpIRQaUCwL2hzntsJ/gU09b/e68
         RITsHLIb2inlMdGQi4MNKRs90JLFUudtCbweO4RilCI4W2bBWBtqO/iGEaeuhrUNnX1g
         rueA==
X-Gm-Message-State: ALoCoQnS/E5kzSZav4+IHydrOnZet8pn8RIb3lkgQWTf9xxvrZ5A+brNB3N1xhHzgphoFPXoVf9O
MIME-Version: 1.0
X-Received: by 10.52.175.166 with SMTP id cb6mr6274018vdc.1.1397725096778;
 Thu, 17 Apr 2014 01:58:16 -0700 (PDT)
X-Originating-IP: [86.6.157.246]
In-Reply-To: <140416091311.ZM19009@torch.brasslantern.com>
References: <20140416044612.GB24565@ewok>
	<140415221511.ZM18252@torch.brasslantern.com>
	<20140416061549.GA31591@ewok>
	<140416091311.ZM19009@torch.brasslantern.com>
Date: Thu, 17 Apr 2014 09:58:16 +0100
Message-ID: <CAECNH1Qp_hJcYwjJp1vWwp6xST86GNiDDdWdTmBdVB7rErBqSA@mail.gmail.com>
Subject: Re: SegFault in stringsubst
From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: zsh workers <zsh-workers@zsh.org>
Content-Type: multipart/alternative; boundary=bcaec50fdff3e326ff04f7393bde

--bcaec50fdff3e326ff04f7393bde
Content-Type: text/plain; charset=ISO-8859-1

On Wednesday, 16 April 2014, Bart Schaefer <schaefer@brasslantern.com>
wrote:
> On Apr 16,  4:19pm, Andrew Waldron wrote:
> }
> } On Tue, 15 Apr 2014, Bart Schaefer wrote:
> }
> } > The exec.c change doesn't change anything other than verbosity about
some
> } > error conditions, correct?
> }
> } Correct, if you take the change in stringsubst then there is no
segfault.
> } You just end up with empty substitutions.
>
> Any second opinions on whether we want the increased verbosity?  Peter?

I think it's certainly useful in debug mode, and there's definitely an
argument for
always reporting it as the alternative is probably rather obscure. The only
likely
negative effect I can think of might be of the caller also reported an
error.

I'm likely to be quiet for a week.

pws

--bcaec50fdff3e326ff04f7393bde--