From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id efcc0f05 for ; Sat, 16 Mar 2019 22:29:37 +0000 (UTC) Received: (qmail 9788 invoked by alias); 16 Mar 2019 22:29:26 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44134 Received: (qmail 858 invoked by uid 1010); 16 Mar 2019 22:29:26 -0000 X-Qmail-Scanner-Diagnostics: from mail-ot1-f67.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.100.2/25384. spamassassin: 3.4.2. Clear:RC:0(209.85.210.67):SA:0(-1.9/5.0):. Processed in 2.300167 secs); 16 Mar 2019 22:29:26 -0000 X-Envelope-From: wesley@mintlab.nl X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.210.67 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mintlab-nl.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=/IG074UD4FxEb7ZpJ+i8sSGVqJ3RlBsaHdg8c3RnEZY=; b=LDsbOtolU/LnkW8qiHf6tLutl4dWRf4aaqZGCCdF348pWQ53LVRJ7I21JmDn9q8jU/ FpoK0OfcyiBfKAsfFB3m9cZOy1KOFIg+xhlpJ6kUrXI8gFIB6p7swnNrebp2wASclnTL ccTFAQNAp9JI5XuuqNmAZ/GYCYai8OtrcWFcmilgE4G0oX4L7YBUO1OP/IkZEJkpRdfq 5hgZ0Q0aEpltLI6lKJlTKDZb30E3/84hL/2rtsVZfLp6UIBig3fxz57oQuqmjtF5MvlY ajW+Mxs42cZ36xf+O+spMALMO+kXLucUN627tDy20eoHNrfwW5HyidHMHw6CrSFu4TPU BU4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=/IG074UD4FxEb7ZpJ+i8sSGVqJ3RlBsaHdg8c3RnEZY=; b=XgoLWqRoa8MOJ2BN6PA2HvIXN0HfilCY0ndkDQfpfNEZDe/Z4xCSvb3eLeI84ln7xk irNIEjZDmJKjP4hq9HsRaWVDQXgJVszx1g3lPs6ZZBEC4WvrGXT7rMe+XLu6K84dnhtp PfrJDtF+ra1MQN0qPtOYVYgJv3yj69zeJDGAU04iDq1d7y8yBLLrNt/UzXJws1r+RMa3 +Ld4tDjLmmqUTHlPc0QnrI0LaVnWNcNxn5XE0Yr7h4Bw5h1QH/5WSvpcfkDyHfIOn5TR 0oCePDXoy9Z85m0UT8ZDyYAkH8Z0BwRYXtZhojstrl37pfIRoO4rF89O1entLQxC+blb qSnA== X-Gm-Message-State: APjAAAXPqy1QBCuAhLNMLWFqBKEWGXPBJ+SK33LU/aShalckT5+suT8O vi42ph+8Wlpc7kjPveYkQyheczUlsCBpuXx7iGbwjg8qeVw= X-Google-Smtp-Source: APXvYqwhpki2J9qCMcZs/Ucdwit5SnqgCynZp6SnrUvJeDkvq0Dy44RpK+8LyCup9E8tvuTxNJojFCFbRBNO5OkKL/s= X-Received: by 2002:a9d:6854:: with SMTP id c20mr63563oto.99.1552775329771; Sat, 16 Mar 2019 15:28:49 -0700 (PDT) MIME-Version: 1.0 References: <20190316214155.GH10429@sym.noone.org> In-Reply-To: <20190316214155.GH10429@sym.noone.org> From: Wesley Schwengle Date: Sat, 16 Mar 2019 23:28:39 +0100 Message-ID: Subject: Re: Bug#924736: zsh 5.7.1 segfaults when three setopt options are in play [origin: wesley@schwengle.net] To: zsh-workers@zsh.org Content-Type: text/plain; charset="UTF-8" Hello all, > Haven't had time to bisect this, but I got this backtrace from git > HEAD: On #zsh (thanks okdana, Mikachu and DHowett) we noticed that the bug was introduced between 5.3.1 and 5.6.2. I managed to bisect and the bug seems to originate from https://github.com/zsh-users/zsh/commit/758966502caa6f91abcbaaebf2610609250de1fb Once that commit is reverted the bug disappears. Mikachu noticed that if one applies the patch below the problem is also resolved. My understanding of the zsh code base is limited, so I don't feel confident to submit the patch for actual inclusion in the code base: diff --git i/Src/hist.c w/Src/hist.c index dbdc1e4e5..972a36db2 100644 --- i/Src/hist.c +++ w/Src/hist.c @@ -1489,7 +1489,7 @@ hend(Eprog prog) } else save = 0; } - if (chwordpos <= 2 && !hist_keep_comment) + if (chwordpos <= 2) save = 0; else if (should_ignore_line(prog)) save = -1; Cheers, Wesley -- Wesley Schwengle, Developer Mintlab B.V., https://www.zaaksysteem.nl E: wesley@mintlab.nl T: +31 20 737 00 05