From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-43003-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 1309 invoked by alias); 13 Jun 2018 17:14:30 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
List-Unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
X-Seq: 43003
Received: (qmail 28470 invoked by uid 1010); 13 Jun 2018 17:14:30 -0000
X-Qmail-Scanner-Diagnostics: from mail-yw0-f194.google.com by f.primenet.com.au (envelope-from <lists@eitanadler.com>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1.  
 Clear:RC:0(209.85.161.194):SA:0(-1.9/5.0):. 
 Processed in 3.687072 secs); 13 Jun 2018 17:14:30 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,
	RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_PASS,T_DKIM_INVALID autolearn=ham
	autolearn_force=no version=3.4.1
X-Envelope-From: lists@eitanadler.com
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=eitanadler.com; s=0xdeadbeef;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc;
        bh=yrQtM2yhCStjql0vrif/aJ5j05Eh6Yu3jQzKHzx0iwI=;
        b=Pp0iu2mSBodOyIcrDDIc60+BaUah4wsc9g7c3lQl2FiPYDKTcFv6ABs6FHDskxp0Rf
         OaQsV4uQqJuGvArxmN003qRRBSDjhynkqpKRhJbrwsR3KZysH9FTQg+Cj+ZeaSfDa0bX
         1Dq1tlXX1iJ61IqPx+/mukhjM0NjHrdsia2D0=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:in-reply-to:references:from:date
         :message-id:subject:to:cc;
        bh=yrQtM2yhCStjql0vrif/aJ5j05Eh6Yu3jQzKHzx0iwI=;
        b=N1Ijj8bc2WyNDmNY3AhPHw87OJMC8EZ/7EH0aFjrE1RWoNHRkrhPjhjdt4xCGYblkc
         GSqZXvXW11u1ukJvRQMCMY0qNy07JFbI5OpbZfPTN80XkMNXXGmAk4S18hJALZ+xrqy8
         AljVUPwheRJJBIH+8O/SsTcJiTr22D9k6HjE0o/GUfAL3FwJQx0hQM1CMUcvDt9mwE1h
         0LyMJrmk8XIk4M0/iuy2lzUOwLnOmam0Dtre/3k/A6/XMD78Z1iDwPxhrWe0XRdUMviL
         0yCMUlCgwbitQWuQ4HskE0EaGgC4F8aeO8XmjOqfWIPV9e0qaUztK/ReW9TnSjYlayLV
         7eNw==
X-Gm-Message-State: APt69E0+Q7USkqjEkISrqfZGvhJ8Ld2gWytwtvurkxSeIUp0KSSU+QGV
	wm8jN7pelfeqaLrbsiBKlkk4hND1SANsiq3uZrbGJg==
X-Google-Smtp-Source: ADUXVKJi2k6jrEZ1HspV2kItEualKHylxiYcJyq801eTHXYtdxDilZPVWHAa4wyD9Fe+Cqp2vbpxm+DH1XN+/lNkTCI=
X-Received: by 2002:a81:3e16:: with SMTP id l22-v6mr2768505ywa.37.1528910063592;
 Wed, 13 Jun 2018 10:14:23 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <CAH+w=7Z5hNeLpoUkGDMnuk3PRF3BX7+z=EdHQHTVtj1pgasrAA@mail.gmail.com>
References: <CAKc7PVBWHsOhpC7mZcL4DA0ih=3yJF-HYe+We=r0q1oXA_s38g@mail.gmail.com>
 <CGME20180613115039epcas5p3f7e70bdce12919686a5dec9895782138@epcas5p3.samsung.com>
 <CAF6rxgmVA5KtcRoaVZi5P=6OtQdLPzHJowbBm+eyp0Zjea19Sg@mail.gmail.com>
 <20180613131021eucas1p263704fa9832375e6a49cf7f2077606dc~3ukj6hhqT1702017020eucas1p2W@eucas1p2.samsung.com>
 <CAH+w=7Z5hNeLpoUkGDMnuk3PRF3BX7+z=EdHQHTVtj1pgasrAA@mail.gmail.com>
From: Eitan Adler <lists@eitanadler.com>
Date: Wed, 13 Jun 2018 10:13:53 -0700
Message-ID: <CAF6rxg=Y1BSfoQLMgyLj4ahJcRp36AN8n2=hwFgxqQ4h0VkAYw@mail.gmail.com>
Subject: Re: [PATCH] Silence compilation warnings about setuid, setgid
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: Peter Stephenson <p.stephenson@samsung.com>, Zsh hackers list <zsh-workers@zsh.org>
Content-Type: text/plain; charset="UTF-8"

On 13 June 2018 at 08:08, Bart Schaefer <schaefer@brasslantern.com> wrote:
> This may have been isolated to a 1990s-era OS that is no longer at
> issue.  Either way there's no particular reason to save and report
> errno from the first call.

See https://wiki.sei.cmu.edu/confluence/display/c/POS37-C.+Ensure+that+privilege+relinquishment+is+successful
I'm not sure what current systems have these issues, but explicitly
checking the results of getuid after priv-drop is still considered a
"good idea"



-- 
Eitan Adler