zsh-workers
 help / color / mirror / code / Atom feed
From: Eitan Adler <lists@eitanadler.com>
To: Jun T <takimoto-j@kba.biglobe.ne.jp>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: Teach 'tar' to support more file types
Date: Thu, 5 Apr 2018 23:53:02 -0700	[thread overview]
Message-ID: <CAF6rxgk+joSqoogqD=eWrjYTpOok+A_qSRFNOrZu58-crEfEMg@mail.gmail.com> (raw)
In-Reply-To: <7060C6C4-6721-4878-B8BC-224346633816@kba.biglobe.ne.jp>

On 4 April 2018 at 20:55, Jun T <takimoto-j@kba.biglobe.ne.jp> wrote:
>
>> 2018/04/02 7:10, Eitan Adler <lists@eitanadler.com> wrote:
>>
>>    In libarchive based (BSD) tar implementations, all file types can be
>>    uncompressed, even without a filetype letter.  In GNU tar's case
>>    "recent" versions (for over 10 years) can do the same.
>>    As such, remove the check for tar type and just assume it works.
>
> We can't assume it works since there are many systems where tar requires
> explicit compression flags. Even on some BSDs (OpenBSD and NetBSD) tar
> is not based on libarchive.
>
> If the tar command is based on libarchive, we can detect it by using
> 'tar --version'.

This patch LGTM.


-- 
Eitan Adler


      parent reply	other threads:[~2018-04-06  6:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-01 22:10 Eitan Adler
2018-04-05  3:55 ` Jun T
2018-04-05  5:41   ` Baptiste Daroussin
2018-04-06  6:53   ` Eitan Adler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAF6rxgk+joSqoogqD=eWrjYTpOok+A_qSRFNOrZu58-crEfEMg@mail.gmail.com' \
    --to=lists@eitanadler.com \
    --cc=takimoto-j@kba.biglobe.ne.jp \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).