From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22698 invoked by alias); 27 Sep 2013 01:10:59 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 31769 Received: (qmail 2184 invoked from network); 27 Sep 2013 01:10:55 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.160.48 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=NScbORTge5HEGZyY5o/ryOzeAjU8xLMQF934wN61SX0=; b=Myn//wiNPtk0rrcNbDIBLG8xOtwsq8jFu+k5PFTlz5guXH38BynLnpBOmLVW9ydmO1 P+o8CHQUnRYf1mXFtamaajDo9ENYKzLNzO6aqJbbZCfjMAxMZE7kRmUb49FC/EQjPAUZ 4Xzm8J8tTeE9gGQqzdQE6NS/VX3nrsYguB488= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=NScbORTge5HEGZyY5o/ryOzeAjU8xLMQF934wN61SX0=; b=b4ZEh54xt96ovaJS+bRH3q/owhD/Tmd5NP8DLtyhcX6Y2aq6sfJl0u2fk8J5+iqy/f LwD8zR0YX9bHwIkCgwX8DoObYl/lOg2OYcE1oziPENLNY4lKRXqB5eZ0DIz1rnSGPpUv dyQdRxfxb32+RhetC62muy76FkUx+qVprB/MUMALOa2CE4Vj+ldtK6nwoeB0hm65Av3g WXFTlNiRSHlvHLX+I+MmKHRa+LXDKKXcl2Fki8BwigoRlgYXeFEdfF6NcrIR0LbENXoh d6IY4hIOxWHPnd7BF4a/Mopuhp4cFpex1RlDhs0eiYkt9PLqH/cnOlt12NzAtgU+Lbyu ks9w== X-Gm-Message-State: ALoCoQma3my+YK4naIhvcQb/YnS6qu9ChkNT8ne+ePjBUroflJpdkCY/NrQ5Nb1wX8savcLrKFuI X-Received: by 10.68.197.200 with SMTP id iw8mr16482pbc.197.1380244248329; Thu, 26 Sep 2013 18:10:48 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: From: Eitan Adler Date: Thu, 26 Sep 2013 21:10:18 -0400 Message-ID: Subject: Re: coredump on C-c To: Bart Schaefer Cc: Zsh hackers list Content-Type: text/plain; charset=UTF-8 On Thu, Sep 26, 2013 at 5:31 PM, Bart Schaefer wrote: > On Thu, Sep 26, 2013 at 10:52 AM, Eitan Adler wrote: >> >> Sometimes, when pressing Ctrl-c to exit a program I get a coredump. I >> have not been able to isolate the exact case when this happens. >> >> #12 0x000000000053ded6 in zleaftertrap (dummy=0x87ea50 , >> dat=0x0) at zle_main.c:1856 > > ... >> >> name=0x800930040 "_main_complete") at exec.c:4854 > > > > If this is an accurate backtrace, and you've accurately described the > circumstances in which you pressed ctrl-c, then it indicates that you've > invoked completion, This sounds possible and even likely. > A first question is, is the first sentence of the previous paragraph > correct? And if so, what are you doing invoking a program that you might > have to kill off with ctrl-c from inside a completion widget? Now that I think about it, it may be pressing ctrl-c to try and stop a from completing due the time it takes. I have not been able to isolate the coredumps yet but I'll be on the lookout for this > I'd say that > particular widget is in need of a rewrite. This is my zshrc: https://code.google.com/p/config/source/browse/zsh/zshrc and these are the files referenced by my zshrc: https://code.google.com/p/config/source/browse/#hg%2Fzsh I will try to press ctrl-c during completion to see if that causes the crash. > ... we should be queuing signals. zfree() does it internally, but that's > not enough to stop corruption in freeparamnode() if the signal arrives > before all the parts of the node are cleaned p, and we probably ought to be > queuing signals around the entire "free all the nodes" loop in > resizehashtable(). I'm happy to test patches, but I don't know zsh internals well enough to comment on this. -- Eitan Adler