From: Eitan Adler <lists@eitanadler.com>
To: Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [PATCH] _git: add completion for git-version
Date: Sun, 19 Jan 2020 18:00:39 -0800 [thread overview]
Message-ID: <CAF6rxgmhXYH3qD-5N_YWcCn-LgBPNZc4f=NWX-p71rs5UVx1KQ@mail.gmail.com> (raw)
In-Reply-To: <8049d524-b7ad-4f45-982e-ddf313b7958b@www.fastmail.com>
On Sun, 19 Jan 2020 at 14:14, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
>
> Eitan Adler wrote on Sun, 19 Jan 2020 21:31 +00:00:
> > +++ b/Completion/Unix/Command/_git
> > @@ -407,6 +407,12 @@ _git-bundle () {
> > +_git-version () {
> > + _arguments -S $endopt \
> > + '--build-options[also print build options]'
> > +}
> > @@ -5951,7 +5957,8 @@ _git_commands () {
> > + version:'show git version')
>
> This subcommand is undocumented (except one mention in the release
> notes); is it a public API?
I believe it to be a public API. In fact the --build-options was added
since modifying the output otherwise would affect consumers. I'll add
sending an upstream patch to git to my never ending TODO list.
--
Eitan Adler
prev parent reply other threads:[~2020-01-20 2:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-19 21:31 Eitan Adler
2020-01-19 22:13 ` Daniel Shahaf
2020-01-19 23:09 ` Oliver Kiddle
2020-01-19 23:31 ` Daniel Shahaf
2020-01-20 2:00 ` Eitan Adler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAF6rxgmhXYH3qD-5N_YWcCn-LgBPNZc4f=NWX-p71rs5UVx1KQ@mail.gmail.com' \
--to=lists@eitanadler.com \
--cc=d.s@daniel.shahaf.name \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).