From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-45337-ml=inbox.vuxu.org@zsh.org>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI,
	RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2
Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2])
	by inbox.vuxu.org (OpenSMTPD) with ESMTP id 2faf125c
	for <ml@inbox.vuxu.org>;
	Mon, 20 Jan 2020 02:01:49 +0000 (UTC)
Received: (qmail 448 invoked by alias); 20 Jan 2020 02:01:42 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
List-Unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
X-Seq: 45337
Received: (qmail 13445 invoked by uid 1010); 20 Jan 2020 02:01:42 -0000
X-Qmail-Scanner-Diagnostics: from mail-io1-f68.google.com by f.primenet.com.au (envelope-from <lists@eitanadler.com>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.102.1/25699. spamassassin: 3.4.2.  
 Clear:RC:0(209.85.166.68):SA:0(-2.0/5.0):. 
 Processed in 2.537054 secs); 20 Jan 2020 02:01:42 -0000
X-Envelope-From: lists@eitanadler.com
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.166.68 as permitted sender)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=P3RF2V7+6HeQGoLr5QNqCYou0dFPqFQu4SLJ0GTLJ4g=;
        b=Mdo3Ppw8TtD4t3F29f35OpxtMFb6yEhSz9MvFtpjVOmzGwwBfvuDIKofeKU9WF6fPy
         GvRyWYaCz11qZ2+b2JUt6c70xlhbsLBOTqD3ag29yWAeOPeoTagmYcCCpHRUR8+NTwzs
         nV4wQssQeCKGzvbbNpS2lwt6Xm9bBtuiHugfj1t1v6Ytvev+kdGWAWLeaTzA7R5ACjsE
         zYwf9I7xWthUAYq2UJeCyu1DhWHjYmvGQ+AhqXzC5dM6rcDAulzBTEFyGUEXl8tyjIwR
         F7gE7Ent7JR7kHs1Na0JMtfeGduwrp6f0+NwEEdYff8/j0JwmAjJijI6d9/o0LZYMdLn
         aI6w==
X-Gm-Message-State: APjAAAXtMN2gOAf/ZHIP0NzIRD71cTudtTv9/3w+4TiET+ndZ0y7dyGC
	cbw9/IOQ1yHT82sjet/kmIAJ8uqAWaKjX0Nb70/ytw==
X-Google-Smtp-Source: APXvYqxWw5wJDZgvSCxxQ3vPKp/NEQqKvVav9NJ9jh6M7XQfphlUZNuDUPxF3WWCRc0hoRlIMI2eNfdHVml9GtPst4M=
X-Received: by 2002:a02:2e43:: with SMTP id u3mr43007356jae.137.1579485665422;
 Sun, 19 Jan 2020 18:01:05 -0800 (PST)
MIME-Version: 1.0
References: <20200119213156.37874-1-lists@eitanadler.com> <8049d524-b7ad-4f45-982e-ddf313b7958b@www.fastmail.com>
In-Reply-To: <8049d524-b7ad-4f45-982e-ddf313b7958b@www.fastmail.com>
From: Eitan Adler <lists@eitanadler.com>
Date: Sun, 19 Jan 2020 18:00:39 -0800
Message-ID: <CAF6rxgmhXYH3qD-5N_YWcCn-LgBPNZc4f=NWX-p71rs5UVx1KQ@mail.gmail.com>
Subject: Re: [PATCH] _git: add completion for git-version
To: Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Content-Type: text/plain; charset="UTF-8"

On Sun, 19 Jan 2020 at 14:14, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
>
> Eitan Adler wrote on Sun, 19 Jan 2020 21:31 +00:00:
> > +++ b/Completion/Unix/Command/_git
> > @@ -407,6 +407,12 @@ _git-bundle () {
> > +_git-version () {
> > +  _arguments -S $endopt \
> > +    '--build-options[also print build options]'
> > +}
> > @@ -5951,7 +5957,8 @@ _git_commands () {
> > +    version:'show git version')
>
> This subcommand is undocumented (except one mention in the release
> notes); is it a public API?

I believe it to be a public API. In fact the --build-options was added
since modifying the output otherwise would affect consumers. I'll add
sending an upstream patch to git to my never ending TODO list.



--
Eitan Adler