From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24658 invoked by alias); 18 Jun 2018 07:50:20 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 43051 Received: (qmail 10470 invoked by uid 1010); 18 Jun 2018 07:50:20 -0000 X-Qmail-Scanner-Diagnostics: from mail-yb0-f195.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.213.195):SA:0(-1.9/5.0):. Processed in 1.734363 secs); 18 Jun 2018 07:50:20 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_PASS,T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1 X-Envelope-From: lists@eitanadler.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=vu8dfKKBSYSmPWBN9GP46qc/g1jAAyFFcYuP5B5Ycg8=; b=leSB2mtD5gIw7UqbYzETJOZYFMKZSCG3eHUy1VieNLayc3xzy8nZKaLbdpz8F0RaXw DCUM8QifiCNqW6Stun15khFxQLI2ZZSA8WVbTA3TAmbw46MJs2dgOZtC00LCwe8LkReH IhMijLxNPNbhLOuuGKmdxR4blYPg4XuD8+6VY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=vu8dfKKBSYSmPWBN9GP46qc/g1jAAyFFcYuP5B5Ycg8=; b=ipLnJqGj9x8Ec1pBzk/7o3bPjeUw6ZKJYrzhe8qgn1YiB5Wi83yw8tUf7PeMaX6/f+ xHHA4zRWOAR1Cezjy7kbKf5wyVFpPlJOdvGvKjcV6E587gMTxpw/FY7DNxo58JmkuZTH dDjZ0Ci606tF9TGQ/8Ktf5U/POWrVCx3d+tU9k1dJyydu8sUjpNh2xbV5m0nSj5DGEoC 4fplDMB8rAbpjOn5YHnvCUjXBcyCkWB7wQvIhgD3B+QSpSFNRp8UXj2XirNrUuyO/t6U YalWCNjcsfQOMN8tsGYuk5NVM3k/zSpUburVuDQk1211+BfdI/PAo+O2whasqodWrVNS DtOQ== X-Gm-Message-State: APt69E10EU1QiMw/lf8PVuw83RRblZ/syMmGn049obvsfqOUCDeHTu+0 dFqA4KdO3F23x9se8u9tibpUFXEYbLMKScXhk64E2nO2 X-Google-Smtp-Source: ADUXVKIcr5lE3VN0lJp/eJLbWKmi8T26EoA+3QB7mqaIEXck/N4i/sCRPkEGPB/+++Lqrb6J0Zyu9FVjccUBIeRf2WA= X-Received: by 2002:a25:734f:: with SMTP id o76-v6mr1860271ybc.69.1529308215663; Mon, 18 Jun 2018 00:50:15 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <20180618051446.69512-1-lists@eitanadler.com> From: Eitan Adler Date: Mon, 18 Jun 2018 00:49:45 -0700 Message-ID: Subject: Re: [PATCH] _gcc: Improve completer for _clang and _gcc To: Mikael Magnusson Cc: zsh workers Content-Type: text/plain; charset="UTF-8" On 18 June 2018 at 00:44, Mikael Magnusson wrote: > On Mon, Jun 18, 2018 at 7:14 AM, Eitan Adler wrote: >> clang - add additional sanitizers >> both - add additional standards (basically, aliases) >> both - fix -flto >> >> Signed-off-by: Eitan Adler >> --- >> Completion/Unix/Command/_gcc | 22 ++++++++++++++++++---- >> 1 file changed, 18 insertions(+), 4 deletions(-) >> >> diff --git a/Completion/Unix/Command/_gcc b/Completion/Unix/Command/_gcc >> index a552bb2db..9690df79f 100644 >> --- a/Completion/Unix/Command/_gcc >> +++ b/Completion/Unix/Command/_gcc >> @@ -338,16 +338,31 @@ h8/300) >> ;; >> esac >> >> +local -a sanitizers >> if [[ "$service" = clang* ]]; then >> args=( >> $args >> - -flto -emit-llvm >> + "-flto=-[generate output files suitable for link time optimization]::style:(full thin)" >> + -emit-llvm >> "-Qunused-arguments[don't emit warning for unused driver arguments]" >> --analyze >> -fshow-column -fshow-source-location -fcaret-diagnostics -fdiagnostics-fixit-info >> -fdiagnostics-parseable-fixits -fdiagnostics-print-source-range-info >> -fprint-source-range-info -fdiagnostics-show-option -fmessage-length >> ) >> + sanitizers=( >> + address alignment bool bounds enum float-cast-overflow float-divide-by-zero >> + integer-divide-by-zero memory nonnull-attribute null nullability-arg nullability-assign >> + nullability-return object-size pointer-overflow return unsigned-integer-overflow >> + returns-nonnull-attribute shift signed-integer-overflow unreachable vla-bound vptr > > Did you mean to add this list under the gcc case? No. Those are the list supported by clang. I didn't do a full audit, but gcc supports fewer of them. It may support more than the list I included, but this is not a regression. Its hard to test gcc since it just errors out with "/usr/local/bin/ld: cannot find -lubsan" when testing and I don't want to go down the rabbit hole of debugging that right now. -- Eitan Adler