From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 594 invoked by alias); 18 Apr 2018 00:38:33 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 42677 Received: (qmail 17083 invoked by uid 1010); 18 Apr 2018 00:38:33 -0000 X-Qmail-Scanner-Diagnostics: from mail-yb0-f180.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.213.180):SA:0(-1.9/5.0):. Processed in 2.294166 secs); 18 Apr 2018 00:38:33 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_PASS,T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1 X-Envelope-From: lists@eitanadler.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=Mi1VQlhRmtUTNv4/HProYIJ3nGqTrkUfaigDH5Zxfew=; b=Y/IeLkQN0d/3W8MNgWyPCfnwLuD7ccD7Od/uCdHlLA4yMzpFwCwmCeveyxLwaozEQJ L5O3mnR62NjCHFjFB5oclCvkuqV3fTtUWwvenMdUZ9C9lhrmLXwnXYAkwjNV7RrFhfjb aRtLHeV5N2oj3u9aKgeBsevrADXmQbziJyOHA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=Mi1VQlhRmtUTNv4/HProYIJ3nGqTrkUfaigDH5Zxfew=; b=hnye5d1gqWFEPahZ/vPh65oMhakOvuL9taSMjwr/Wa7X92E8e1l2gmPd/b2ZfWXVMc +C8NK057TTdSQ7h34zeIco9Kb7OcoseyB/KbGMVwA3zIgITgeNffG+bk5jGvccjJwBGR tHk9tIbFpKbKIL38ykuagw+cNiwbs9NJ32mQkQCmFZZcv3WA+dAkQ22iPuzSO1kXYwyt YY/Rv0prCkanwQpOagGezes13DUrUrKaCI5M7m2rpJStPdqLnul30MFm3Bt+Pzqi8VIS vQfvEwCZIKKxcdrJh6Qp7zS7WO4oQsa77QWxxOK5BhNdYgKQ6sf05TukZqdhL7b0VJGM RyUw== X-Gm-Message-State: ALQs6tDGh+ybTlXxgJLLf78/K08uM/ta7t7BsN11I0bGyMczoMg8NWNg jIaokZqZJ7m/izbSjPpOwH3PH9mm19n7LG9iF/D0mQ== X-Google-Smtp-Source: AIpwx49KrBIaTxeYXAvU7nBvkwynVrJeIQck3cwfUjNT8NvOoxkpOP8dxCUgXX6Y4W4w24BSEmbKG9WjSVFiMye1hNA= X-Received: by 2002:a25:a0d0:: with SMTP id i16-v6mr3087821ybm.479.1524011907464; Tue, 17 Apr 2018 17:38:27 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20180417125307.GA34493@CptOrmolo.darkstar> References: <20180416145913.wv637mfnw5hfe2fi@Daniels-MacBook-Air.local> <20180417125307.GA34493@CptOrmolo.darkstar> From: Eitan Adler Date: Tue, 17 Apr 2018 17:37:56 -0700 Message-ID: Subject: Re: support more arguments to diff To: Zsh hackers list Content-Type: text/plain; charset="UTF-8" On 17 April 2018 at 05:53, Matthew Martin wrote: > On Tue, Apr 17, 2018 at 04:22:38AM -0700, Eitan Adler wrote: >> On 16 April 2018 at 07:59, Daniel Tameling wrote: >> > On Sun, Apr 15, 2018 at 10:48:08PM -0700, Eitan Adler wrote: >> >> This patch isn't perfect since {Net,DragonFly,Open,Free}BSD are not >> >> identical but this patch at leasts makes the completion a lot closer >> >> to reality. >> >> >> >> Currently FreeBSD doesn't even show -q for example. >> >> >> > >> > Did the patch change the behavior of diff completion for you? On my >> > FreeBSD, diff is some GNU variant, and I think that it's the default >> > and that I didn't install it via pkg: >> >> FreeBSD is in the process of converting to a new diff implementation. >> This resulted in me seeing a huge difference with this patch. >> >> I'd also like to port this particular diff implementation to the other >> BSDs, hence adding all of them to the case statement. > > I think it would be best to add the other cases as each BSD adopts > whichever diff. I generally try to update the completion to match > -current, so when a new release is picked up the options are correct. I also wonder if we could just get rid of the OS test and replace it with a pure version test. What if we run different verrsions than the default? -- Eitan Adler