From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-31630-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 26483 invoked by alias); 2 Aug 2013 19:14:51 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 31630
Received: (qmail 4863 invoked from network); 2 Aug 2013 19:14:36 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_LOW,
	T_TO_NO_BRKTS_FREEMAIL autolearn=ham version=3.3.2
Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.160.47 as permitted sender)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:date:message-id:subject:from:to:content-type;
        bh=VvhxVlFKR2nhUPUBhfur16M9o86Be3Urbf0uMQL9dM0=;
        b=FPlW3xt2QfGj7ryiOsTfhWzP+2WLYSQkuB9CTjQIfkM5iNqFvJirGag0cnTN0UB+e+
         QxwZWUcAMf9gzmRRxhC7LREt2j+Smf5t9UDlUqMEN8/1bl1HR3yeMZE+zjm1n6WpB9I8
         6HS+FgKcvBNuzWgKUORyM/wdvcU/YCn1udUAd7qOzEFL6JNLQhpjL4+RaFq9i1b6Aj5w
         kTGd5B6KyWgt8vZZSw+BVrhqk/j/Wn81CXmHQMT8TrL0/csdewWIcElGwK2giZOlWiqy
         +0CWyU5jvLp9q9jIbZtJtQTIMeOlx0ZE1FzCYPgomYXg5tcOWjbwQUkzlv9ZGNlo9mrJ
         mjdw==
MIME-Version: 1.0
X-Received: by 10.66.122.194 with SMTP id lu2mr4319946pab.125.1375470866097;
 Fri, 02 Aug 2013 12:14:26 -0700 (PDT)
Date: Fri, 2 Aug 2013 14:14:26 -0500
Message-ID: <CAFX4wC0q-BgWtY+RW3z7Nnz0arGgTCc9hbKRJyms16FamsZ6TQ@mail.gmail.com>
Subject: builtins.c does not compile under latest cygwin
From: =?UTF-8?Q?Edgar_S=C3=A1nchez_Grajeda?= <edgarsanchezg@gmail.com>
To: zsh-workers@zsh.org
Content-Type: multipart/alternative; boundary=047d7bf0cefe5f6fa604e2fbc48c

--047d7bf0cefe5f6fa604e2fbc48c
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hello,

When installing Cygwin I tried installing zsh from the source, and the
builtin.c module
=E2=80=8Bwas not compiling.

Here
=E2=80=8B=E2=80=8B
the output from make:

rm -f libzsh-5.0.2.dll
gcc  -s -shared -Wl,--export-all-symbols -o libzsh-5.0.2.dll  `cat
stamp-modobjs` -ldl -lncursesw -lrt -lm  -lc
builtin.o:builtin.c:(.text+0xa98c): undefined reference to
`cygwin_conv_to_posix_path'
builtin.o:builtin.c:(.text+0xa98c): relocation truncated to fit:
R_X86_64_PC32 against undefined symbol `cygwin_conv_to_posix_path'
/usr/lib/gcc/x86_64-pc-cygwin/4.8.1/../../../../x86_64-pc-cygwin/bin/ld:
builtin.o: bad reloc address 0x8 in section `.data'
collect2: error: ld returned 1 exit status
Makefile:230: recipe for target `libzsh-5.0.2.dll' failed
make[1]: *** [libzsh-5.0.2.dll] Error 1
make[1]: Leaving directory `/zsh-5.0.2/Src'

I
=E2=80=8B looked up the missing function, and cygwin_conv_to_posix_path() f=
unction
was deprecated and replaced with cygwin_conv_path().

In builtins.c:cd_do_chdir()=E2=80=8B

=E2=80=8BI fixed it with:

#ifndef _SYS_CYGWIN_H
    void cygwin_conv_path(cygwin_conv_path_t what, const void * from, void
* to, size_t size);
#endif

    cygwin_conv_path (CCP_WIN_A_TO_POSIX | CCP_RELATIVE, dest, buf,
PATH_MAX);=E2=80=8B


=E2=80=8B   dest =3D buf;=E2=80=8B


=E2=80=8BThere's still some comptests failing when running make check, but =
at least
now it's compiling without errors=E2=80=8B.

--
~ Ed
=E2=80=8Bgar=E2=80=8B

--047d7bf0cefe5f6fa604e2fbc48c--