From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,HTML_IMAGE_ONLY_24,HTML_MESSAGE, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 8846 invoked from network); 23 Sep 2023 03:14:30 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 23 Sep 2023 03:14:30 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1695438871; b=UEGL3xs2Y29kq1hOHlyz5DHTF9hMNeAJl+0IhqQyZFUe3sJS7F/gN4RBl4+2jnuH4tMI8RX0iv QvaWxag0bKaks6GoDxZrhilqTrzAMYYb/etZ9+NACgU1Snwj+ClwxE6etfyUbxQ18yfl5N55Ki qQaXSsV76JkQkTo5LceKAXdPArDfdft+Bpq9apKzeAY58TtA21YnMj4d5lUsvX4RBBkTB6Ve+W 1VHHRoi/JJL7CvoD+7Op8rVYshqmObBwBnOyjyv4GsASbIvTTwa9Ij7kqr/TqXWzSz7/2tIKwp pMVtsi38FGW7QS5XkQsDeA23TbhCfJwLOf2vhaypGtGU6Q==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-yb1-f176.google.com) smtp.remote-ip=209.85.219.176; dkim=pass header.d=gmail.com header.s=20230601 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1695438871; bh=EmhbTT4GkCGdZkH0hVlKGHyxmLnpS7FF1+gpPlT0gPg=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=R9jvpWsiWpqzYDbOQqKpeNJlghUvwSHDTlgdOe6M/tWdhVf2KrAcpisP2tOqDbkJ+qYZaONMRM kJoOMItNLW1+JPlTDX+DxY4GEt8/1IKzaTdEyVjV+fkCSs37imr0r0QnAqlSsP27gGrMbVMSrl AUaIQw1e041xuh3m7DqnFbTCm8Nn4wT3LLTNY9jDEfen6wkU5IZqUpohe1S54OPn5RRy0mdFrp YuEFmuw6gtdw+4BpXjD/t7MDW2MI/5cQfUBGEm6sCemU2TL1x3i9s+9XtP5rXpwQ0nMa1a/+kt IbL561xG8UBotdWxeY88+FF+oSNP5gETb/DCm20SeAfj/w==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=qLCSL5Xzm4KbEIt/u4YNjMuI8El5NfUjdx+3iiVIe/I=; b=AzZb/G/q0pgK9T7BDF3lLjkx/j JbiN4DlTGib2O1P/7nVrK3sp0ribJUiAlk5I46gdyAtt0wYHYBQ7WIO52BxAcBNchS1UIK7/qQVtF vM9NqLNEZYiwhbxPvpJJ8wriddK/qczXkw/gUu2JeQkaQh7ncjK7go9or7lyAFMH2/+3kp3xMCGTX Mg1PG5C4OsTbVtJKu+dn6OXXoCcbj8Zq6hPleW1862XCj37Y4ZkK09QZXmOMTFg6LbSxmW7yQ6kCm 2QIv/8mX4kQa9hzDiBhmODt2rAjG0cw3AqRaf6LKbGZbA8wMR+whm6Wooc6wdKqc5NZOqsay1Iu7X DCTeSMyg==; Received: by zero.zsh.org with local id 1qjt6D-0009hX-T3; Sat, 23 Sep 2023 03:14:29 +0000 Authentication-Results: zsh.org; iprev=pass (mail-yb1-f176.google.com) smtp.remote-ip=209.85.219.176; dkim=pass header.d=gmail.com header.s=20230601 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-yb1-f176.google.com ([209.85.219.176]:55614) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1qjt5Y-0009N6-SE; Sat, 23 Sep 2023 03:13:50 +0000 Received: by mail-yb1-f176.google.com with SMTP id 3f1490d57ef6-d7ecdb99b7aso3601242276.3; Fri, 22 Sep 2023 20:13:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695438827; x=1696043627; darn=zsh.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=qLCSL5Xzm4KbEIt/u4YNjMuI8El5NfUjdx+3iiVIe/I=; b=cbDTDoFhVV9U1zAgyQop2/lek55gHZiGsxymfMlZMOZM4f2dBuarJGUhT+hLjg8jKN 0sRFBzcpYMrbu85HhX0TuKEC2T9H89oJmJn8guf4CUJtylXsgWBEwgxigdZs7IIF24Jh xc9WswO1ToaNSl2acrDKI2tU9j5vGtwYUujqDQfGR8MnS97ciBsK8mjx190k1qHEXG3p P8trjx+Mg4yO47VAtrLVfmDEbSN8xw5QIdyadJrJ2xS31lYX3/J/2AIWuazOngENNrUB bTkhhBX7m0Pih244tTEBQsBWd6avoE2gHByOgw/DB6HdvHkbN6svk0gZvdx/BDSMTVRR o7jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695438827; x=1696043627; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qLCSL5Xzm4KbEIt/u4YNjMuI8El5NfUjdx+3iiVIe/I=; b=tHf5bD3tLQr08qenjUZlCDObPi9qMrXG8cpO8TsgtYrpeZAhjxBTr0dnkbroN60txl /Dnven+r36Htiy+ivj0AEQvFshw/Mqfx+VnSEOhXspRMZcWk9UaYXrs4JMAcovP/PK3g KAU4M7cihnMMwLJb+j6muMAaYbazmJ5SEkTM3k3R7XkYwyzVjH41vtN2vbmkPP8Zsugy cX6PsFfOnpcgkW7PuoMo1Gwl577AZS7c8u7/hWgcdZ0yU3kcq/V58tindJ3IP6FpAo+Q FIk44bOtE4l6K+2ckvTomK/gJO59lwU2CYWP3Eg8QDWe/kskfOmi0mecXlHc4inGnKB8 sUXA== X-Gm-Message-State: AOJu0Yw4JxT8bF3yBzt2VzC49EiST4LA39+DvuwfCYkcnYP31wL2ZlAm jeZJE2yEcEzWlAL9k234+R79n2T3Zk0Wh8ZbkdAOpcSd X-Google-Smtp-Source: AGHT+IGeO692zZohsxlZsUNnb+dV4YhCTTcM5EOJ0q6WiRO7wFzr8hzOoz4AvDPAscG7wxH43L6Hvh53wTvy0EKoGRc= X-Received: by 2002:a25:e811:0:b0:d22:c8b9:8c9b with SMTP id k17-20020a25e811000000b00d22c8b98c9bmr934111ybd.13.1695438827418; Fri, 22 Sep 2023 20:13:47 -0700 (PDT) MIME-Version: 1.0 References: <20230922025003.33716-1-syohex@gmail.com> <34152-1695425815.329395@JT8l.BbmG.WY7I> In-Reply-To: <34152-1695425815.329395@JT8l.BbmG.WY7I> From: Shohei Yoshida Date: Sat, 23 Sep 2023 12:13:36 +0900 Message-ID: Subject: Re: [PATCH] Fix gradlew completion To: Oliver Kiddle Cc: zsh-workers@zsh.org Content-Type: multipart/mixed; boundary="0000000000000c14110605fe1dc4" X-Seq: 52179 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: --0000000000000c14110605fe1dc4 Content-Type: multipart/alternative; boundary="0000000000000c140f0605fe1dc2" --0000000000000c140f0605fe1dc2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Sep 23, 2023 at 8:36=E2=80=AFAM Oliver Kiddle wrote: > Shohei YOSHIDA wrote: > > gradlew is not usually in the PATH so the command to retrieve tasks > would fail > > due to 'command not found'. So it should execute './gradlew' instead of > 'gradle' > > if service is gradlew and there is an executable file './gradlew' in > current > > directory > > Trying to run $service from a completion function is nearly always > wrong because any path prefix has first been stripped. Rather than > trying to handle the current directory, it is probably better to just > use $words[1] instead. Then if someone completes after ../gradlew or > /somewhere/else/gradlew then it will use the location they specified. > If there is no gradlew there, they're going to have other problems when > they try to execute it anyway. > > Oliver > Thanks for reviewing. I have updated the patch and attached it. --=20 Shohei YOSHIDA(syohex@gmail.com) --0000000000000c140f0605fe1dc2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Sat, Sep 23, 2023 at 8:36=E2=80=AFAM O= liver Kiddle <opk@zsh.org> wrote:<= br>
Shohei YOSHIDA w= rote:
> gradlew is not usually in the PATH so the command to retrieve tasks wo= uld fail
> due to 'command not found'. So it should execute './gradle= w' instead of 'gradle'
> if service is gradlew and there is an executable file './gradlew&#= 39; in current
> directory

Trying to run $service from a completion function is nearly always
wrong because any path prefix has first been stripped. Rather than
trying to handle the current directory, it is probably better to just
use $words[1] instead. Then if someone completes after ../gradlew or
/somewhere/else/gradlew then it will use the location they specified.
If there is no gradlew there, they're going to have other problems when=
they try to execute it anyway.

Oliver

Thanks for reviewing.
= I have updated the patch and attached it.=C2=A0

<= span class=3D"gmail_signature_prefix">--
Shohei YOSHIDA(syohex@gmail.com)
--0000000000000c140f0605fe1dc2-- --0000000000000c14110605fe1dc4 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Fix-gradlew-completion.patch" Content-Disposition: attachment; filename="0001-Fix-gradlew-completion.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lmvgfo030 RnJvbSA5ZWY1YTc1MjM5MzE2MDMzYzNkYjBkM2RlZTYwZmVhMzFiOTFiNDIwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTaG9oZWkgWU9TSElEQSA8c3lvaGV4QGdtYWlsLmNvbT4KRGF0 ZTogRnJpLCAyMiBTZXAgMjAyMyAxMTozNjoyMSArMDkwMApTdWJqZWN0OiBbUEFUQ0hdIEZpeCBn cmFkbGV3IGNvbXBsZXRpb24KCmdyYWRsZXcgaXMgbm90IHVzdWFsbHkgaW4gdGhlIFBBVEggc28g dGhlIGNvbW1hbmQgdG8gcmV0cmlldmUgdGFza3Mgd291bGQgZmFpbApkdWUgdG8gJ2NvbW1hbmQg bm90IGZvdW5kJy4gVGhlIGxvY2F0aW9uIGlzIHN0cmlwcGVkIGZyb20gJyRzZXJ2aWNlJyBzbyB1 c2UKJyR3b3Jkc1sxXScgaW5zdGVhZCBvZiAnJHNlcnZpY2UnCi0tLQogQ29tcGxldGlvbi9Vbml4 L0NvbW1hbmQvX2dyYWRsZSB8IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwg MSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL0NvbXBsZXRpb24vVW5peC9Db21tYW5kL19ncmFk bGUgYi9Db21wbGV0aW9uL1VuaXgvQ29tbWFuZC9fZ3JhZGxlCmluZGV4IGMxZjdjMDVlZS4uMjgw YWEyNDNmIDEwMDY0NAotLS0gYS9Db21wbGV0aW9uL1VuaXgvQ29tbWFuZC9fZ3JhZGxlCisrKyBi L0NvbXBsZXRpb24vVW5peC9Db21tYW5kL19ncmFkbGUKQEAgLTkyLDcgKzkyLDcgQEAgaWYgW1sg JHN0YXRlID09IHRhc2sgJiYgISAtcHJlZml4IC0gXV07IHRoZW4KICAgICAgICAgICAgICAgICB6 bGUgLVIgIkdlbmVyYXRpbmcgY2FjaGUgZnJvbSAkZ3JhZGxlX2J1aWxkZmlsZSIKIAogICAgICAg ICAgICAgICAgICMgUnVuIGdyYWRsZS9ncmFkbGV3IGFuZCByZXRyaWV2ZSBwb3NzaWJsZSB0YXNr cy4KLSAgICAgICAgICAgICAgICBmb3Igb3V0cHV0bGluZSBpbiAkeyhmKSIkKCRzZXJ2aWNlIC0t YnVpbGQtZmlsZSAkZ3JhZGxlX2J1aWxkZmlsZSAtcSB0YXNrcyAtLWFsbCkifTsgZG8KKyAgICAg ICAgICAgICAgICBmb3Igb3V0cHV0bGluZSBpbiAkeyhmKSIkKCR3b3Jkc1sxXSAtLWJ1aWxkLWZp bGUgJGdyYWRsZV9idWlsZGZpbGUgLXEgdGFza3MgLS1hbGwpIn07IGRvCiAKICAgICAgICAgICAg ICAgICAgICAgIyBUYXNrcyBhbmQgc3VicHJvamVjdHMgZWFjaCBzdGFydCB3aXRoIGEgbG93ZXJj YXNlIGxldHRlciwgYnV0IHdoZXJlYXMgdGFza3MgYXJlIGluIGNhbWVsQ2FzZSwgZWFjaAogICAg ICAgICAgICAgICAgICAgICAjIHN1YnByb2plY3QgY29uc2lzdHMgb2Ygb25lIG9yIG1vcmUgc2Vj dGlvbnMgb2Yga2ViYWItY2FzZSwgd2l0aCBlYWNoIHNlY3Rpb24gZW5kaW5nIGluIGEgJzonLgot LSAKMi4zOS4yCgo= --0000000000000c14110605fe1dc4--