From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,HTML_MESSAGE,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_SORBS_WEB autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 11853 invoked from network); 27 Aug 2023 07:02:44 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 27 Aug 2023 07:02:44 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1693119764; b=Ie6ai6i6AYfT5h04m9wyd1nbyqG8FZLLwSU+0j7+2kjzc3I0yEhBIRrKkQzb63WqRbLR1UPHff 90FCLqKMs2MzIyNF5b6YAprWDriNrnOzMU+jUzVNFtIcX44+nY9hiLglifiPuWbp5qAVKs9JM3 94r1EtH4SrDk6nVva2sB++FAXpAV3RPVgY9ws7DSYGOwsRZUedHuS0x5V6vBS8vJRKmvcmXroT A2QKzG+YrQfMrStUajB3pwyjeJm3ZgomGluQK2qBoyVgc14UKqIMxYfh2zmvTOj4p6RAWHWAk3 Wulb729x/AJc/eVSV0kDc99nq63UG2PM2SNeoQRorUWT2g==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-yw1-f176.google.com) smtp.remote-ip=209.85.128.176; dkim=pass header.d=gmail.com header.s=20221208 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1693119764; bh=1LuxQgcsbtiML16hgjcP82PJhcv+uV670j6RcEKsT0M=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=qsRaYoWuFSEAft2Gn2d43DlsbTu819gvO8lMrGZb8W3lGeV0QGJD7zOFHDdUwI7wcG4GkYI5w3 F1S7mV9McrqGKRzKd3LDBEb3b0gmx10cL07g+rM0LS7RL2XLx/BzJ0XES1kiYR61XCb5wgpDqu a885AkLbmpvw/bRXmBPBwLMGgn7eiswlCYBR32fBmAso38m9NcJXoviiyNd+RBfxdfrhDMiI9M R1h3dmFh25MYAGQ9/lXdb0/sYmJH+HwGcuZOmbFykjCg8vcbinDWwllZF0LYZ2PDTU582VQJqU s/cjwB2dQKUiapfM6jicIqe3fRLgfUuaAxs/DVjqRyvx8Q==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:To:Subject:Message-ID: Date:From:In-Reply-To:References:MIME-Version:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=2490FyR3THmXDs2UNRU/gwtim0YwVqA7LrVjTDL9Hg8=; b=p2+jR3iBbKL6UI4wtGA6jLnAZX CTYdbhj3pLgvzXlJJGF2rEdj0yB99XUpWBLEC8XC4DH39bbQsh09hD9rre3/esdtRi/N3nHVsSjfB AZNWzX3v9be6GBEQ1Lle09gLdNmx6Uhsvz3Xz+hUA5AcWiSsDLdVVCmBlMDnGsrr6lCNSlsR7nn5a YfJ/QGtUZRPLocfc6wvrqJXKIVLrdGX+Kju8ZvAtKZJdlPdar2gAVXj8HFUn+d1GxAzAEQGzfose0 toMQXx128+c0VUZ29JSaYQdosATMzivTVlUn6iWf6/khwgYx36neMI8i+dAfoOIjEdFUUcRWFg3Rm TE7ILZfw==; Received: by zero.zsh.org with local id 1qa9nI-000CJG-Nj; Sun, 27 Aug 2023 07:02:44 +0000 Authentication-Results: zsh.org; iprev=pass (mail-yw1-f176.google.com) smtp.remote-ip=209.85.128.176; dkim=pass header.d=gmail.com header.s=20221208 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-yw1-f176.google.com ([209.85.128.176]:62903) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1qa9n2-000Bzc-A3; Sun, 27 Aug 2023 07:02:29 +0000 Received: by mail-yw1-f176.google.com with SMTP id 00721157ae682-58d41109351so45068407b3.1 for ; Sun, 27 Aug 2023 00:02:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693119747; x=1693724547; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=2490FyR3THmXDs2UNRU/gwtim0YwVqA7LrVjTDL9Hg8=; b=spTqjNF1hkhdMS/BzYjHhPK8Br5O3AilH0snrP5+WNoWHEm6dSo8TBGTUPmrEi7VLQ qDtnYXGh3SrbI4cZdrbqu5ELKpqsQc1GU7bTVu9jp2KeaRZvqDmvFMmtRParAclpkaxX 11oen/YAyOknAI3d7i1OZI3ALYaG50ZH4VN0meO0/YYsyfAFh7aDmR1bSloSfzP/mIDN 3+j6cMD3rrmMyLOlWzPb2k2AlKoUEMRUFbMhU58o3g/qDcPoTLIKPskFqHEdGvisVZBM H3igRkK5AXoufJBmwhgz6Z4HFV/6uUe3gPVVktGjQzLsTcuq3sb5goMW2ftjK3IRCrr1 HJrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693119747; x=1693724547; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2490FyR3THmXDs2UNRU/gwtim0YwVqA7LrVjTDL9Hg8=; b=Ekv6boVNORzVNN3tuUetMf1ItXWh485ZKtweu0FIEhxP211yOI/3C8dL8jOKkYm+M2 l0wDUb+qcQJPfCW/vIXBlIAM3wNElef5A6Q9NXO7gN/V4+tnr527gSLarC1nFGNrGNrJ 2PFZEb/tZNVKCgWPnupjHP1aFSnT1P/FDPPeU+S/mn+zaM8vPfOR5AQT8ow5Wv2pMPUI yCF55zeXpw5rMDkbijqocKoHnPkdBL9cX71MUwO1h9AoVcIt2PuUdRZ1rqHTtwmPV76I /3dnxAYQNSnx+/B3dMuA0MTc+S7nei2wqzwI6/oYi8mzTb00rNxMpQElFynuTMDCewmE MGxQ== X-Gm-Message-State: AOJu0YzgfuAUZEeOg/WS1zoYjW6mFqjept7btjp8EcGpd/pggDr03kiH NsA9qJjXE3Ozc/I7nkOrmOCj1+crkrUEE3U2R5iHXlnG X-Google-Smtp-Source: AGHT+IEzj+JAoBFVnom5IedlBvLBcgbV1E4ZnVLHVKCxkUI878PreOFTD+AXJTFU+mSJx9m7PrHj93cvMh6LvaWaBEc= X-Received: by 2002:a0d:e2c5:0:b0:589:a4c7:ee40 with SMTP id l188-20020a0de2c5000000b00589a4c7ee40mr22097205ywe.2.1693119747142; Sun, 27 Aug 2023 00:02:27 -0700 (PDT) MIME-Version: 1.0 References: <20230823040004.171642-1-syohex@gmail.com> <20230823040004.171642-2-syohex@gmail.com> In-Reply-To: From: Shohei Yoshida Date: Sun, 27 Aug 2023 16:02:16 +0900 Message-ID: Subject: Re: [PATCH 1/4] Update system_profiler completion To: zsh-workers@zsh.org Content-Type: multipart/mixed; boundary="000000000000181dfe0603e22953" X-Seq: 52099 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: --000000000000181dfe0603e22953 Content-Type: multipart/alternative; boundary="000000000000181dfc0603e22951" --000000000000181dfc0603e22951 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable attached fixed version. On Fri, Aug 25, 2023 at 2:24=E2=80=AFPM Shohei Yoshida w= rote: > > > On Fri, Aug 25, 2023 at 1:56=E2=80=AFPM Jun T > wrote: > >> >> # TODO: Should this be static? Calling `system_profiler -listDataTypes` >> takes >> # about 0.07-0.08 secs on my machine. Does this list ever change (betwe= en >> # different versions of OS X)? >> _data_types=3D( SP{AirPort,Applications,Audio,...(snip)...,WWAN}DataType= ) >> # the dynamic alternative is: >> #_data_types=3D( ${${(f)"$(_call_program path system_profiler >> -listDataTypes 2>/dev/null)"}[2,-1]} ) >> >> At least on macOS Ventura (the latest), "system_profiler -listDataTypes" >> gives somewhat different list of data types. And I think the time >> required by this command is negligible (I can't notice any delay). >> So isn't it better to use the 'dynamic alternative' in the above comment= ? >> > > I think the dynamic alternative is better if possible. > > -- > Shohei YOSHIDA(syohex@gmail.com) > > --=20 Shohei YOSHIDA(syohex@gmail.com) --000000000000181dfc0603e22951 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
attached fixed version.

On Fri, Aug 25, 20= 23 at 2:24=E2=80=AFPM Shohei Yoshida <syohex@gmail.com> wrote:


On Fri, Aug 25, 202= 3 at 1:56=E2=80=AFPM Jun T <takimoto-j@kba.biglobe.ne.jp> wrote:

# TODO: Should this be static?=C2=A0 Calling `system_profiler -listDataType= s` takes
# about 0.07-0.08 secs on my machine.=C2=A0 Does this list ever change (bet= ween
# different versions of OS X)?
_data_types=3D( SP{AirPort,Applications,Audio,...(snip)...,WWAN}DataType )<= br> # the dynamic alternative is:
#_data_types=3D( ${${(f)"$(_call_program path system_profiler -listDat= aTypes 2>/dev/null)"}[2,-1]} )

At least on macOS Ventura (the latest), "system_profiler -listDataType= s"
gives somewhat different list of data types. And I think the time
required by this command is negligible (I can't notice any delay).
So isn't it better to use the 'dynamic alternative' in the abov= e comment?

I think the dynamic alternative i= s better if possible.

--
Shohei YOSHIDA(s= yohex@gmail.com)


--
Shohei YOSHIDA(syohex@gmail.com)<= img src=3D"http://b.hatena.ne.jp/entry/image/https://mail.google.com/_/scs/= mail-static/_/js/k=3Dgmail.main.ja.tLQrNXCHmdo.O/m=3Dm_i,t,it/am=3DnBHH5b_7= g8gZ7tIn1f7977tLmp39J3_3JgBC2Amo_5v9P4jWA_ug_FA/rt=3Dh/d=3D1/t=3Dzcms/rs=3D= AItRSTNJwrjV1i8LKqdsHFfbx47Tnlb-Bw">
--000000000000181dfc0603e22951-- --000000000000181dfe0603e22953 Content-Type: application/octet-stream; name="0001-Update-system_profiler-completion.patch" Content-Disposition: attachment; filename="0001-Update-system_profiler-completion.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_llt3rbly0 RnJvbSBlYjM2ODNiODg5ZmYyNDIwYmI1YTNhZDVmZTI1MDlkZGMyMzZhMmI3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTaG9oZWkgWU9TSElEQSA8c3lvaGV4QGdtYWlsLmNvbT4KRGF0 ZTogU3VuLCAyNyBBdWcgMjAyMyAxNTo1ODoyNiArMDkwMApTdWJqZWN0OiBbUEFUQ0hdIFVwZGF0 ZSBzeXN0ZW1fcHJvZmlsZXIgY29tcGxldGlvbgoKLSBhZGQgbmV3IG9wdGlvbiBjb21wbGV0aW9u cwotIGZpeCB0aW1vdXQgY29tcGxldGlvbiB0aGF0IHRha2VzIHNlY29uZHMKLSBnZW5lcmF0ZSBk YXRhIHR5cGVzIGR5bmFtaWNhbGx5Ci0tLQogQ29tcGxldGlvbi9EYXJ3aW4vQ29tbWFuZC9fc3lz dGVtX3Byb2ZpbGVyIHwgMTIgKysrKy0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRp b25zKCspLCA4IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL0NvbXBsZXRpb24vRGFyd2luL0Nv bW1hbmQvX3N5c3RlbV9wcm9maWxlciBiL0NvbXBsZXRpb24vRGFyd2luL0NvbW1hbmQvX3N5c3Rl bV9wcm9maWxlcgppbmRleCBmZTE5NzU3OWQuLjBmZDhiNDczYiAxMDA2NDQKLS0tIGEvQ29tcGxl dGlvbi9EYXJ3aW4vQ29tbWFuZC9fc3lzdGVtX3Byb2ZpbGVyCisrKyBiL0NvbXBsZXRpb24vRGFy d2luL0NvbW1hbmQvX3N5c3RlbV9wcm9maWxlcgpAQCAtNCwxNyArNCwxMyBAQCB0eXBlc2V0IC1B IG9wdF9hcmdzCiBsb2NhbCBjb250ZXh0IHN0YXRlIHN0YXRlX2Rlc2NyIGxpbmUKIGxvY2FsIC1h IF9kYXRhX3R5cGVzCiAKLSMgVE9ETzogU2hvdWxkIHRoaXMgYmUgc3RhdGljPyAgQ2FsbGluZyBg c3lzdGVtX3Byb2ZpbGVyIC1saXN0RGF0YVR5cGVzYCB0YWtlcwotIyBhYm91dCAwLjA3LTAuMDgg c2VjcyBvbiBteSBtYWNoaW5lLiAgRG9lcyB0aGlzIGxpc3QgZXZlciBjaGFuZ2UgKGJldHdlZW4K LSMgZGlmZmVyZW50IHZlcnNpb25zIG9mIE9TIFgpPwotX2RhdGFfdHlwZXM9KCBTUHtBaXJQb3J0 LEFwcGxpY2F0aW9ucyxBdWRpbyxCbHVldG9vdGgsQ2FtZXJhLENhcmRSZWFkZXIsQ29tcG9uZW50 LENvbmZpZ3VyYXRpb25Qcm9maWxlLERldmVsb3BlclRvb2xzLERpYWdub3N0aWNzLERpc2FibGVk U29mdHdhcmUsRGlzY0J1cm5pbmcsRGlzcGxheXMsRXRoZXJuZXQsRXh0ZW5zaW9ucyxGaWJyZUNo YW5uZWwsRmlyZVdpcmUsRmlyZXdhbGwsRm9udHMsRnJhbWV3b3JrcyxIYXJkd2FyZSxIYXJkd2Fy ZVJBSUQsSW5zdGFsbEhpc3RvcnksTG9ncyxNYW5hZ2VkQ2xpZW50LE1lbW9yeSxOZXR3b3JrLE5l dHdvcmtMb2NhdGlvbixOZXR3b3JrVm9sdW1lLFBDSSxQYXJhbGxlbEFUQSxQYXJhbGxlbFNDU0ks UG93ZXIsUHJlZlBhbmUsUHJpbnRlcnMsUHJpbnRlcnNTb2Z0d2FyZSxTQVMsU1BJLFNlcmlhbEFU QSxTb2Z0d2FyZSxTdGFydHVwSXRlbSxTdG9yYWdlLFN5bmNTZXJ2aWNlcyxUaHVuZGVyYm9sdCxV U0IsVW5pdmVyc2FsQWNjZXNzLFdXQU59RGF0YVR5cGUgKQotIyB0aGUgZHluYW1pYyBhbHRlcm5h dGl2ZSBpczoKLSNfZGF0YV90eXBlcz0oICR7JHsoZikiJChfY2FsbF9wcm9ncmFtIHBhdGggc3lz dGVtX3Byb2ZpbGVyIC1saXN0RGF0YVR5cGVzIDI+L2Rldi9udWxsKSJ9WzIsLTFdfSApCitfZGF0 YV90eXBlcz0oICR7JHsoZikiJChfY2FsbF9wcm9ncmFtIGRhdGEtdHlwZXMgc3lzdGVtX3Byb2Zp bGVyIC1saXN0RGF0YVR5cGVzIDI+L2Rldi9udWxsKSJ9WzIsLTFdfSApCiAKIF9hcmd1bWVudHMg XAogICAnKC0gKiktdXNhZ2UnIFwKICAgJygtICopLWxpc3REYXRhVHlwZXNbbGlzdHMgdGhlIGF2 YWlsYWJsZSBkYXRhdHlwZXNdJyBcCi0gICcoLWxpc3REYXRhVHlwZXMgLXVzYWdlKS14bWxbZ2Vu ZXJhdGUgeG1sIG91dHB1dF0nIFwKKyAgJygtbGlzdERhdGFUeXBlcyAtdXNhZ2UgLWpzb24pLXht bFtnZW5lcmF0ZSB4bWwgb3V0cHV0XScgXAorICAnKC1saXN0RGF0YVR5cGVzIC11c2FnZSAteG1s KS1qc29uW2dlbmVyYXRlIGpzb24gb3V0cHV0XScgXAogICAnKC1saXN0RGF0YVR5cGVzIC11c2Fn ZSktZGV0YWlsTGV2ZWxbbGV2ZWwgb2YgZGV0YWlsIGZvciB0aGUgcmVwb3J0XTpkZXRhaWwgbGV2 ZWw6KG1pbmkgYmFzaWMgZnVsbCknIFwKLSAgJygtbGlzdERhdGFUeXBlcyAtdXNhZ2UpLXRpbWVv dXQrW21heGltdW0gdGltZSB0byB3YWl0IGluIHNlY29uZHNdJyBcCisgICcoLWxpc3REYXRhVHlw ZXMgLXVzYWdlKS10aW1lb3V0K1ttYXhpbXVtIHRpbWUgdG8gd2FpdCBpbiBzZWNvbmRzKDAgbWVh bnMgbm8gdGltZW91dCldOnRpbWVvdXQgc2Vjb25kcycgXAogICAnKC1saXN0RGF0YVR5cGVzIC11 c2FnZSkqOmRhdGEgdHlwZTonIigkX2RhdGFfdHlwZXMpIgotLSAKMi40Mi4wCgo= --000000000000181dfe0603e22953--