Daniel, I've fixed the no-quotes issue with $@ and now I'm passing both compadd and git commit options using one -O parameter (the array names are separated with colon, as you suggested). Regards, Obszczymucha On 28 August 2015 at 00:28, Daniel Shahaf wrote: > Bart Schaefer wrote on Thu, Aug 27, 2015 at 16:19:52 -0700: >> On Aug 27, 11:11pm, Daniel Shahaf wrote: >> } >> } Apart from these two issues, the patch seems ready for commit to me. >> >> Let's get this (and 36304) in soon, so PWS can close -test-3 and >> release 5.1. > > I've already pushed 36304. > > I don't think this patch needs to delay 5.1; it's not a regression.