From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-36342-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 1017 invoked by alias); 31 Aug 2015 07:50:08 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 36342
Received: (qmail 28585 invoked from network); 31 Aug 2015 07:50:07 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM autolearn=ham autolearn_force=no
	version=3.4.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=oMttaBmMshw2xqWuqAd9FP56vKEEsDaF85AmJheNCs0=;
        b=OLA9QhbrvtaorV+b4CHlYadgzTw80YQDfh176cJMCpHurNgChDZ0Kq5lrOKOt2KXhn
         cRCe2n7PpIlpXlskB4fxfta03F9C1V6vhdd6v2H3SFa7hK1vSTySFQ15iyZpXASIOY2C
         7N5lbAMIpU8dGzKxOQhOOXX2b4+c0/gs0P7G0d8+4Vxy94OiQMcYKpWuQmzt1ZTLeKXy
         7d2iEUCQ3bu5UdR1HrA+12LftFkntvqVBx+lsWPZcl6ar/NPvQsiDnwTV/7YgStSfgFl
         FkX7dZbwOo11Jui3FINbAC+y/4EktbqafUwh4uPdhEiULY+ECBs5lMqLDS9tbB86Iv+y
         rvrg==
MIME-Version: 1.0
X-Received: by 10.140.144.207 with SMTP id 198mr36948423qhq.38.1441007402815;
 Mon, 31 Aug 2015 00:50:02 -0700 (PDT)
In-Reply-To: <20150830223945.GC12415@tarsus.local2>
References: <CAFiR=Jv1ycq5jWvbyHQX=Csjyv8H1xSUKA45Mj6152Why5qhjg@mail.gmail.com>
	<20150722115307.GC2171@tarsus.local2>
	<CAFiR=JvJefLthQnoQ2YY-nQF69jgAXo76dzMit7sBRBZVgiq_Q@mail.gmail.com>
	<20150827231152.GD21994@tarsus.local2>
	<150827161952.ZM1496@torch.brasslantern.com>
	<20150827232856.GF21994@tarsus.local2>
	<CAFiR=Jt0msq78gUyitXViLO4vRmA1b=WKUs4mTp01DLgLheoGg@mail.gmail.com>
	<20150830223945.GC12415@tarsus.local2>
Date: Mon, 31 Aug 2015 08:50:02 +0100
Message-ID: <CAFiR=JuWVbqPFMiRVDcfkejKFfbnKVQzzBTqBecmspijRFA9yw@mail.gmail.com>
Subject: Re: PATCH: 3.0.8: git completion update for cherry-pick
From: Mateusz Karbowy <mateusz.karbowy@gmail.com>
To: Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: zsh-workers@zsh.org
Content-Type: text/plain; charset=UTF-8

Thanks Daniel! :)

On 30 August 2015 at 23:39, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> Mateusz Karbowy wrote on Sat, Aug 29, 2015 at 17:53:57 +0100:
>> I've fixed the no-quotes issue with $@ and now I'm passing both
>> compadd and git commit options using one -O parameter (the array names
>> are separated with colon, as you suggested).
>
> Looks good.
>
> I've made a few changes (see attached series):
>
> 1. Some style tweaks
>
> 2. Avoid printing wrong [HEAD~$n] descriptions in __git_recent_commits
>
> 3. Extra safety check in case somebody passed just the traditional '-O
> expl' with no colon
>
> I'll commit the patch with those changes (as soon as I get an X-Seq
> number for this email).  Many thanks!
>
> Daniel
>