zsh-workers
 help / color / mirror / code / Atom feed
From: Antony Lee <antony.lee@berkeley.edu>
To: zsh-workers@zsh.org
Subject: Improvement to python module list generation used for command completion
Date: Fri, 24 Jul 2015 20:37:28 -0700	[thread overview]
Message-ID: <CAGRr6BETX9g1RbBm9Ud0hgHp0C90gHsmW5CL+A0NDx2e_rmL4g@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 762 bytes --]

Currently, both the completion for python -m and for pydoc require a list
of available python modules, generated in _python_modules.  This uses
pydoc's ModuleScanner, which is unbearably slow on systems with just a few
big packages installed because it also searches for submodules, and thus
has to import all packages(!) available on the path.

Instead, pkgutil.iter_modules (available at least since python 2.6) only
returns toplevel modules, so replacing

    local script='import sys, pydoc
def f(p,m,d):
    if m.find(".") < 0: sys.stdout.write(m+"\n")
pydoc.ModuleScanner().run(f)'

by

    local script='import pkgutil
for importer, name, ispkg in pkgutil.iter_modules(): print(name)'

in _python_modules yields a big improvement in speed.

Best,

Antony

             reply	other threads:[~2015-07-25  3:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-25  3:37 Antony Lee [this message]
2015-07-25 18:18 ` Jun T.
2015-07-25 21:33   ` Antony Lee
2015-07-26  1:03     ` Jun T.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGRr6BETX9g1RbBm9Ud0hgHp0C90gHsmW5CL+A0NDx2e_rmL4g@mail.gmail.com \
    --to=antony.lee@berkeley.edu \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).