From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,HTML_MESSAGE,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 27573 invoked from network); 15 Nov 2022 07:31:02 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 15 Nov 2022 07:31:02 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1668497462; b=ecNI5huXetc/ojafba2M9k9bWLXBTjAfZeemjBiX0EVt+b/AcEBZV9syM0QhjmlqCIcc9P03aO GAFywTSdpCAYnqputyTpsoOmds2OkeekUImvmzFDvxeP0OqkdueHfZrgFGEbzlQpjXfpqWNq4v RBVT/rBVJPtqVq/bHeEtDfu2Y0om5g+/lwaw5sn9XOiTTCa4ErffbzRWz3+YBGjHE73u5rjb9s kNGnkXbWOb8/+K2qhgc4Caxf3e4e3GqIbH2M0yjZFY3E/qSwScVu8Ghhmso03pYJoO2XU2moCm y5Too9HiGqkttdNb9n5PhNy/iSZdHM5B45/em/VMfWy5oA==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-ua1-f49.google.com) smtp.remote-ip=209.85.222.49; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1668497462; bh=ubjqIMAoJmRUD53+bv9EUBVomsRbK2I1wW6Yc2yGzjE=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=aFL2iIuSY5dUVhGL7xc6NNe68BvlAU+TCwpmI43eo2dwaVqXefDIrLpTVfm8nluvROY3+BP6d+ 8QOHCPd+hi+SEL3d2AI8qXQswb3PCHkOxvAqw+pDYG7XKbFV9IRVLHc8YdjVCXLjxnZ09SP+Hr 8zKGLwyVC2cc74/qveGu5HtqADI++h2b343idl08NiJaxDP8l+GtmfWUDRyDF1zqd+5qCYZzk7 IUy6hDFPs+stbylPniMg+9HzQwjTkrkuE27dUweEDFZ56mNfiti2JoRe/gwAYCRXmaQCLN4xX5 R87euiik5He0g76lLp9swhOAako6aD37Cp62D5MSvOpJzg==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=IclyUclEfQILN1c5mUY3ZHb5vO8Vd0h5GrHDfgRb2v8=; b=pWJ8tG/Qyn2JeJ7clfEdp/Bc0W ySEvcfMHyfztwdJwonL2KxINTx8Pg80M9WV25otz8ifee8tFH2uz8O1lsZD+rAhFM0g6TkiXnxw2s DK1wj8d9xEhYwvqCtNxc3nF9YASCkf1lBfTVUiYTGH2cz1WAnou11KDGG06I6dMlyX8/4lWn15mAs VztKEOg2Tk/gH1IJ9J0XMnmM09QAk+D85EMl9HXbHsR8rvRlJ6W1F23e0ZobYTVMiB+q/Akan7oFD MTxzghu//crP3xxXqhkTKNqrgNlaGD/R+hIltWeAthzAeexe0BlVVSOzzJQLJmWr9UUdEv2tbejzM lFaQOhaQ==; Received: by zero.zsh.org with local id 1ouqPN-0007XJ-U5; Tue, 15 Nov 2022 07:31:01 +0000 Authentication-Results: zsh.org; iprev=pass (mail-ua1-f49.google.com) smtp.remote-ip=209.85.222.49; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-ua1-f49.google.com ([209.85.222.49]:46790) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1ouqP8-0007Bl-NL; Tue, 15 Nov 2022 07:30:47 +0000 Received: by mail-ua1-f49.google.com with SMTP id c12so4620249uat.13 for ; Mon, 14 Nov 2022 23:30:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=IclyUclEfQILN1c5mUY3ZHb5vO8Vd0h5GrHDfgRb2v8=; b=lW+KO3qcx/A8XmJYS+zwMgkoG3tB+gnNO52hx0h3vvWql1UeJc8cUPHZe6ABZx2alB +Bm/XWpzbs8viQzzAFGoalzDv81j6QtJpeliqrRMMeNmpB5RAlRkLTZsrD4S7kugBvk0 Fy+1N7wlqg7S2KoABclrj6PO+SOeMp4gxm8fUAhcY0F1rrCplVYkmnzxht45EcHIPRLY q9oqhG5qb8oerPdcoh73/fIRnV+KgRvhdSSeihGfsiqGhrLs3oZtOWIYkJKKKhYyELUr 9BcWquZdrWDnTryaapwieWgOK1skFY/f01TW1YgLbWUPn3ArCWsZt7dDi6rwkffNkIgR fmRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IclyUclEfQILN1c5mUY3ZHb5vO8Vd0h5GrHDfgRb2v8=; b=xHv3pH+tgq63i2t1uysxFGBX9PnRj+6Bwe7HfR0FRbQ5MI2sX3nyCuTXigODG53toR FoWbhDFk+iYYEdVQmEfVsr6lfRcTFR1JV5HP8FIjWl/RN27doT8B3tHrxNuANNDb/NPE e56rDhP+vXMUe8fQpZg37qA3QCiqsYZ6MISs26z/hoJ/EqYItZFe5/MHtUWAvE1gkLMz 9OOoZ51lQu9huh8bwK9N8Myd+rY6iVeOd4QY7Upxdw7/vFnqnGHHBsnbfOjNOyMkzAG6 4IFd7OPSl+UFpCLjtkTuofRzuDmwPjnmBEKr+LuLwdCJgW/5E12XBPQuyiCuNWymfnt7 GkLg== X-Gm-Message-State: ANoB5pnOCKqR2R4AmkkSmmET2gVR3A2eSvXhQESltGj0FTkP0VerS8mt g2XcvWp7DG3n1xPl3POBZXXPdqEkz1zGL7ylSE9Y/TLR X-Google-Smtp-Source: AA0mqf66tfGET763DK95awqbZRspDofHWpcB0BbhiwS8XNhlg1CMgTOBsKq2XFKq9gMlG8MIpZBf5fh4J6fBLy1qfHs= X-Received: by 2002:ab0:36ad:0:b0:3e5:cdde:61d7 with SMTP id v13-20020ab036ad000000b003e5cdde61d7mr8736086uat.23.1668497445542; Mon, 14 Nov 2022 23:30:45 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Philippe Altherr Date: Tue, 15 Nov 2022 08:30:34 +0100 Message-ID: Subject: Re: [PATCH] Even more ERR_EXIT (was Re: More ERR_EXIT Re: Tests RE behavior of ERR_EXIT) To: Bart Schaefer Cc: Zsh hackers list Content-Type: multipart/alternative; boundary="0000000000008cdca705ed7d553a" X-Seq: 50971 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: --0000000000008cdca705ed7d553a Content-Type: text/plain; charset="UTF-8" Oops, I see this only now, just after sending my other reply. I will have a look later. I first need some sleep. Philippe On Tue, Nov 15, 2022 at 8:01 AM Bart Schaefer wrote: > On Mon, Nov 14, 2022 at 5:11 PM Bart Schaefer > wrote: > > > > [if workers/50929 makes 50897 redundant then] there's no point in > > bashing through if/case/for/while/repeat/select individually -- the > > only case we have to fix is this one: > > I was half right. Fixing that case revealed that it was necessary to > go through the others, because the "redundant" fix is one level too > far up the stack. > > Attached patch removes 50929 again, and amends this_noerrexit from > 50897 in each of the complex command exec* functions. Finally it adds > tests to E01options for each of the cases that Philippe previously > outlined, with the exception of "select" which is interactive. > > The tests from 50928 still pass with this patch. I spent a ridiculous > amount of time with every change I made flopping back and forth > between C03 working and the new E01 failing and vice-versa, before > noticing what happened when I nested a brace expression inside another > one. > > Also a minor fix for TRAPDEBUG that caused me some confusion earlier > in the process. > > Are there more cases that need testing? > --0000000000008cdca705ed7d553a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Oops, I see this only now, just after sending my other rep= ly. I will have a look later. I first need some sleep.

P= hilippe


On Tue, Nov 15, 2022 at 8:01 AM Bart Schaefer= <schaefer@brasslantern.com= > wrote:
= On Mon, Nov 14, 2022 at 5:11 PM Bart Schaefer <schaefer@brasslantern.com> wro= te:
>
> [if workers/50929 makes 50897 redundant then] there's no point in<= br> > bashing through if/case/for/while/repeat/select individually -- the > only case we have to fix is this one:

I was half right.=C2=A0 Fixing that case revealed that it was necessary to<= br> go through the others, because the "redundant" fix is one level t= oo
far up the stack.

Attached patch removes 50929 again, and amends this_noerrexit from
50897 in each of the complex command exec* functions.=C2=A0 Finally it adds=
tests to E01options for each of the cases that Philippe previously
outlined, with the exception of "select" which is interactive.
The tests from 50928 still pass with this patch.=C2=A0 I spent a ridiculous=
amount of time with every change I made flopping back and forth
between C03 working and the new E01 failing and vice-versa, before
noticing what happened when I nested a brace expression inside another
one.

Also a minor fix for TRAPDEBUG that caused me some confusion earlier
in the process.

Are there more cases that need testing?
--0000000000008cdca705ed7d553a--