From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,HTML_MESSAGE,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 16488 invoked from network); 3 Dec 2022 01:32:11 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 3 Dec 2022 01:32:11 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1670031131; b=qFuQAHEOrukWEZ7+xGS+ZD+fgaLGfCTdoURh6R1r+EHYR39I1nUiln6Qh3Y9fOSP0zXSZuS/Uv 56W9H0y6tRbVETbaZIX1Yp5idR4qv+sCmxOjkPjh63Scf0Tb0j3sdB8Z+egefEZwIcMJ0nRCDC a/S9CgRBx/xVjbUmf0A38vni7SzB82U9xqh2wIsnXnrrVbbovklj4x4Gfv2wwsUENI95ZtROQW Gl3VgfnPR89qHn4RtmP75+m5eteW9KibD5uH9eV6nRoDXkc6cWQSoeN8iiWg0uT8GguMeyuRH5 d5Nfl6QVaYxQNKe3uGSD/vI2d4bk9IJu/Z+ydWuC1bUrAg==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-vs1-f41.google.com) smtp.remote-ip=209.85.217.41; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1670031131; bh=JEaeQyymHNWjWTjk6QfXW/dXcp/rWfwAzfATjRHHUUw=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=gs7+vKcm5dqk2stGKRM2LtnJiprUHNs3EMhElKCfoFdpRwOqvGUyebvvt9lSudAXbqaARc4L3N y60y/9aBnnrJZcPVfDQ0RdhI9ca7h75Q8R0DL/Ap+fzxd3vflUnlGGC7vLGYe+EGhcPtB9nIoP SuJoYzgTgkW+nrzaUk+XX5Z+7vZBM4GoT3R7QEAOaoAa5aXOa+/U4cfWQtvul8HScqYdMAMzHS P5jtn1+uHsOgt28ntKn2hsaXOC1Ug2ATsXKlIcTNdpr7hsHc3gmlkeFWyGTJWU2V/K/NUyLwPt GzyK2F2Km2h6E0HlDzdmi5SdhpbrLzW4UM6uzBi1EsniNg==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=JEaeQyymHNWjWTjk6QfXW/dXcp/rWfwAzfATjRHHUUw=; b=J3rlgrQUGZ8MHw80g/uGlgW6C9 e7G3kGAYbkNaqEDZshhFsHfPsgFnI6jBRWnOfe9JG0IUeFNwZPgQrvPVddeWKDNXJG7wRCksiiNjp 5KccCjbP9o++VEiu6+G1EtK+9EAyZjm9pXcE2UzV7xPw4akWMA2ETH+9WA5lSZ3Xvji/URVh64eU5 qBQMEO8UEHDsqpbf9snW3G1R1CGlfRelaBCqov63H7i6Y1WzE4C+pe4XIbL6vjuDU3+PBInuDkCRf YDRfYoLgyfvHRyn1LYp/kwDOmdGOUnqSTbSnfslNnDurgPbD/FMHAuInRq+EYHlh14k2arOejaJHQ /Ks3TLNA==; Received: by zero.zsh.org with local id 1p1HNy-000DtP-SS; Sat, 03 Dec 2022 01:32:10 +0000 Authentication-Results: zsh.org; iprev=pass (mail-vs1-f41.google.com) smtp.remote-ip=209.85.217.41; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-vs1-f41.google.com ([209.85.217.41]:42523) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1p1HNS-000Db0-57; Sat, 03 Dec 2022 01:31:46 +0000 Received: by mail-vs1-f41.google.com with SMTP id 125so6245435vsi.9; Fri, 02 Dec 2022 17:31:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=JEaeQyymHNWjWTjk6QfXW/dXcp/rWfwAzfATjRHHUUw=; b=NE6KziHbLWArbKZg0PeF9CfPCdbxP2g9Sf6I8/lbdZ0NSsYFWU9JuRr0u0NacG1Ajd 93hIwcTAhCq3WyknPArLxEoSkbYhhhZH9U+Oj7awf1t+afGhUZNKx4AmGUGs5GrlKAnO T/VDa5prsPzpcI5HUwtLFQJMuX1Rj4GzA8HvCpzoAF4QA4BT6h2ywfPx1g+jP17hueBd Es/9UW+xFWBYamuMJzPM6rZ+DaAcab92Z0KBVAYBpHHSq1ToWvz5PK2y+q62NFlFpS6x CGXaFzjmvyOYaHHHo5mPEEGvjkQNSJIG78M7yjVcHaE0W/KiMMH6pVWSujBIjG6uF4Lc KvVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JEaeQyymHNWjWTjk6QfXW/dXcp/rWfwAzfATjRHHUUw=; b=XNcjJEwQxwYSaoje2hhUSDPW8uRLimFiIV4u5ou8UGo/BUf256Uuw/5+KCE3GGB3OZ cONoSRcsR18VOVdAjllUgZx51eDfHP6OjXKCXVby3S6e/iBiPEGjbJUB+MXrF3wmQaIh 0s2pPVmfDV9SQ8a8QvNCP7s87Kk77IqAjDNmcwZzNU5/FuDhDx7I4yVMpF0e1pnBeEOI OikWBZljy+E1JVAsfcNErZY7ZKS75DH22GJTFv4ymUoZzssjHTY91rp3cBgEU2GgwoXO EUqmmMqj1nWwxjwpMcpVv/f4lTroV1a8Wdj/0nAN0OB9UMEyZEA/aabCRR7Cab0oSN7/ /fqg== X-Gm-Message-State: ANoB5pkgBCiX8Tde/RANDNVcQRfKQy+tUyLG6Yfffot2u5+5M40VZYKP 6NE3/5wc0RP6TRB6BsjvmHwzlpQf596jkYTnG+2ihRVuhG8= X-Google-Smtp-Source: AA0mqf4ZOuYnN3vu4Vq22K2LNGbvnYhdQonh2jfuUNU03prDTu7m2b/ObqEv5cOdgNy0oE+yOB1DcqFZXtvdb+372XI= X-Received: by 2002:a67:fe99:0:b0:3b0:f637:6f1a with SMTP id b25-20020a67fe99000000b003b0f6376f1amr5101495vsr.56.1670031096676; Fri, 02 Dec 2022 17:31:36 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Philippe Altherr Date: Sat, 3 Dec 2022 02:31:25 +0100 Message-ID: Subject: Re: [Patch] Fix ERR_RETURN behavior in and/or statements To: Bart Schaefer Cc: Zsh hackers list , =?UTF-8?Q?Lawrence_Vel=C3=A1zquez?= Content-Type: multipart/alternative; boundary="00000000000048064a05eee26ad6" X-Seq: 51095 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: --00000000000048064a05eee26ad6 Content-Type: text/plain; charset="UTF-8" Hi Bart, With my last patch (patch-08-use-or-assignments-to-set-noerrexit-bits), I think that I'm done with code changes. The best way to understand all of my changes might be to first apply all my 8 patches and have a look at all the places that deal with noerrexit (just grep for noerrexit in all files). The noerrexit logic is now quite a bit smaller and also more regular. For example all places that deal with conditions (if condition, while condition, left of &&/||, and right of !) now behave in very similar ways. Same for all compound commands. You can then have a look at the individual patches. Philippe On Sat, Nov 26, 2022 at 4:47 AM Philippe Altherr wrote: > I'll take a look at all of this in a couple of days. >> > > Sounds good > > I just sent a 6th patch. With that, all the errexit issues I'm aware of > are fixed. > > I still have on my todo list to write a NEWS item that documents the > changes/fixes. So there will be a 7th patch but that one will only touch > the NEWS file. > > There is one last thing that I don't understand in the errexit code, > namely the NOERREXIT_UNTIL_EXEC bit used in execif. I will spend some time > studying it in the next few days. Hopefully, I don't discover new issues :-) > > Philippe > > --00000000000048064a05eee26ad6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Bart,

With my last patch (patch-08-u= se-or-assignments-to-set-noerrexit-bits), I think that I'm done with co= de changes. The best way to understand all of my changes might be to first = apply all my 8 patches=C2=A0and have a look at all the places that deal wit= h noerrexit (just grep for noerrexit in all files). The noerrexit logic is = now quite a bit smaller and also more regular. For example all places that = deal with conditions (if condition, while condition, left of &&/||,= and right of !) now behave in very similar ways. Same for all compound com= mands. You can then have a look at the individual patches.

Philippe


=
On Sat, Nov 26, 2022 at 4:47 AM Phili= ppe Altherr <philippe.alth= err@gmail.com> wrote:
I'll take a look at all of this in a c= ouple of days.

Sounds good
I just sent a 6th patch. With that, all the errexit issues I&#= 39;m aware of are fixed.

I still have on my todo l= ist to write a NEWS item that documents the changes/fixes. So there will be= a 7th patch but that one will only touch the NEWS file.

There is one last thing that I don't understand in the errexit c= ode, namely the=C2=A0NOERREXIT_UNTIL_EXEC bit used in execif. I will spend = some time studying it in the next few days. Hopefully, I don't discover= new issues=C2=A0:-)

Philippe

=
--00000000000048064a05eee26ad6--