From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,HTML_MESSAGE,MAILING_LIST_MULTI autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 19881 invoked from network); 24 Nov 2022 02:22:14 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 24 Nov 2022 02:22:14 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1669256534; b=neuo5ptKWd/fYDkZoa61ix+y7Rb2OG+eGArRRgn2ZUawS3m9iIVMa7vdcWHjwHirck7dvMPvm+ cQze06eGHoYxRK25ZQz2mXCFMg6X1KMuhWZD8xDN7PX1S5OdYkLOlc8x1MuPHXLtcur9P1q3Qn lg+R4YHJonO2Y+uFQMhyZJe4HEev7tTSPCFhGkuEnxe9QF9L4+ENVzF11Ink2/7YAID2qtbVmF kPfjI2PAt1LX9cA2Pl3QimfSpfapp40hVpyRyzY+7+H0+n8ArK73zkAcph1VwG854knnKMLl7O bJzYYOGvprU+cEn84G6EjkqfRAc4jPpck4wgViuiEbTRwg==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-vk1-f176.google.com) smtp.remote-ip=209.85.221.176; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1669256534; bh=QsD4LP8S3tAJDhNraB2AhKRdn9wdpc/MM/bSPu2vHxQ=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=FJHNxlBXw8/5H8sWmX+Xwaco8WmViYb/4tU+MKQfEYuVc9uc4qbgzGf1RLWkhK4kqjV9Z/L1ee /6ei9/U6D6rAA8w8UgHGaVUHpiz3UZwZzqK4ZhNwgW0J7IhBLJ9dEan65HO5DTV806CGU5sR5T mzeyc34ntekoKYrlGBA1EgAF6XeFbI42PZzbrvWsj8uPijfM4kYwTinrAzxN63Sr0fwUuGZdp+ /qxdcFyKBC0d+otMVUnWVfFHrJwFJag8SuLmSsOVk+lKhgomipfPBhnwFza4MUe9ZgyMMW+xCh fh1K3BHRxPwerTVMiZKQzvG/RpqWWVhBjMMrTwcEFFkrcQ==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=zDYGWbddSqW2nblm8aAexUat6XXrTw+LuhuhKWuORxg=; b=XtB9srXGtp2Ei1brZUHk8cIjCe NlNPmCqJf2hpg+eCGMJqveBppmnxyFPEEWmFwl1iu+vMMwxyZ3X66aojDPSo50J20CPINacyZLMfm SxBCYa6We66kP7WS/IubsdYKC6jjtBxt5ofOFazhCoSqF666Q9TkHhzRPP99XdBiBdriVv9dE2696 iYPgVfOwPi9tynBbTR42nsqYuPufxm7TbwlUBcuSPbruY9DmV8k04lPe4nicFHzAO5xqL895L6aot B0vrHHsC2AFw0WJNCPgmL3hjRo3mUJrlgdfTcmq0LaNpvsCWBgjKwhh3ooHLHLFuC5lp+do1MbT2z SPT0WLLQ==; Received: by zero.zsh.org with local id 1oy1sT-000GGv-8c; Thu, 24 Nov 2022 02:22:13 +0000 Authentication-Results: zsh.org; iprev=pass (mail-vk1-f176.google.com) smtp.remote-ip=209.85.221.176; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-vk1-f176.google.com ([209.85.221.176]:42837) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1oy1sC-000Fvd-9u; Thu, 24 Nov 2022 02:21:56 +0000 Received: by mail-vk1-f176.google.com with SMTP id o24so217764vkl.9; Wed, 23 Nov 2022 18:21:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=zDYGWbddSqW2nblm8aAexUat6XXrTw+LuhuhKWuORxg=; b=Zdbv/1HEtmVUhE8zCkJ0zgOhVgKlphtfb/xTodLELqBPY9Bw/4wdxmndn0XjCen8Qv uzkXaD7tgygnU8BW/rduZf2Vjz9JOXOymb3Lf4niQgGIsTLjZQ0XyJiPojPzS0bol6BL ckw4yEdqbhbyxoLWy2Y0jH4Y7FQmp/v5F/e9L9dC+wcc8hBHq0aXpABUcajFXscjfm4U wWX9xbBhLbBc/ddT5K0nTy1JSDETFJ4nc8uMnzDdiK+cz02qnSGAwQGduoXlgFuDLJ6a ljrz4sYDXPPwzlcqELkYbGNoXuz/a/VyLxm87ynpOKzsGQ6P/1kFdo/5NF1OV9N6bEjR gA+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zDYGWbddSqW2nblm8aAexUat6XXrTw+LuhuhKWuORxg=; b=jj3LR6nHVz7xOZupCpzn9LKZ3e/k4BuTOFb/7jh4ynaX/D9eAt7pL4Fc/RQBmGkzmR X3AN+In7AAVb+kefK/gY8uSf+a5jI4zfv2lubqBLjbo7cplljpYn3rC5EsJL9l8GzyAt q6ZJ/BJt6gjYv32wwUWm1vvcTc944PD/qM9WuDYxOJAHwgnRbMMorldRKnS+SYOYSjjI Y56b4LSHgTWeLRmJIVmpLB7GjGcvxiSfuNt/JbUQ8m6h1VhtbC88SHvF/Duazd5/6qX+ tOjdt4iLm6M+jxr59hzmXvQCG69wqotmsM+t7xN6YPiRvvzo0xfPWugGP41jCcL7dfxy Cq0Q== X-Gm-Message-State: ANoB5pmYkqa3OwewRgo11RGQzWiQmbv4QPl0UV8GediC2ik7JY6+Inoy rHDjNpKcYNXMrI+AuSVL3el5RtgqTPeDakTMMyyNaMcEPTM= X-Google-Smtp-Source: AA0mqf7T8IKffWS/5sopQvPAIIWkf5OcFfzpi6MiZUPkR7o5PoB+y8YoRDMTZ9nLAYP2E10MxP/MBXHh7UNOvvkmERo= X-Received: by 2002:a1f:5c14:0:b0:3b8:42bb:c1c4 with SMTP id q20-20020a1f5c14000000b003b842bbc1c4mr7932017vkb.31.1669256515102; Wed, 23 Nov 2022 18:21:55 -0800 (PST) MIME-Version: 1.0 References: <230a78bb-fa97-4f3a-94a2-86982316274b@app.fastmail.com> <20221123205715.GQ27622@tarpaulin.shahaf.local2> In-Reply-To: From: Philippe Altherr Date: Thu, 24 Nov 2022 03:21:43 +0100 Message-ID: Subject: Re: Submitting multiple patches (was: Re: [PATCH] Fix ERR_EXIT behavior in function calls and "always" statements) To: Bart Schaefer Cc: Daniel Shahaf , zsh-workers@zsh.org, =?UTF-8?Q?Lawrence_Vel=C3=A1zquez?= Content-Type: multipart/alternative; boundary="0000000000009f2b4a05ee2e116c" X-Seq: 51057 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: --0000000000009f2b4a05ee2e116c Content-Type: text/plain; charset="UTF-8" > > Namely, Philippe felt it important to > have one patch that completely backed out two or more of my previous > patches, > *followed by a patch that incorporated a useful part of one of**those > patches*. Did I do that? My original big/unique patch did indeed remove your fix to one of the tests in C03traps.ztst and at the same time added an equivalent but different fix. I realized this only after sending my original patch. My split patches no longer do that; patch-01-revert-mistaken-errexit-patches.txt no longer reverts your fix. I'm not aware of another of your changes that I revert in patch-01-revert-mistaken-errexit-patches.txt and add back in one of the later patches. Did I overlook something? Philippe On Wed, Nov 23, 2022 at 10:54 PM Bart Schaefer wrote: > On Wed, Nov 23, 2022 at 1:11 PM Bart Schaefer > wrote: > > > > The ONLY issue with Philippe's message, if there is any > > problem with it at all, is that two of the patches overlapped on one > > of the files, such that one backed out a change and then another put > > that same change back again. > > This also seems to reflect a philosophical point that it might be > worth mentioning in the development guide (which is probably overdue > for an overhaul in general). Namely, Philippe felt it important to > have one patch that completely backed out two or more of my previous > patches, followed by a patch that incorporated a useful part of one of > those patches. > > This isn't generally how we've approached things -- we just move > forward incrementally from the tip of the branch. > --0000000000009f2b4a05ee2e116c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Namely, = Philippe felt it important to
have one patch that completely backed out = two or more of my previous
patches, followed by a patch that incorpor= ated a useful part of one of
those patches.
=
Did I do that? My original big/unique patch did indeed remov= e your fix to one of the tests in=C2=A0C03traps.ztst and at the same time a= dded an equivalent but different fix. I realized this only after sending my= original patch. My split patches no longer do that; patch-01-revert-mistak= en-errexit-patches.txt no longer reverts your fix. I'm not aware of ano= ther of your changes that I revert in patch-01-revert-mistaken-errexit-patc= hes.txt and add back in one of the later patches. Did I overlook something?=

Philippe

On Wed, N= ov 23, 2022 at 10:54 PM Bart Schaefer <schaefer@brasslantern.com> wrote:
On Wed, Nov 23, 2022 at 1:11 PM Bart S= chaefer <= schaefer@brasslantern.com> wrote:
>
> The ONLY issue with Philippe's message, if there is any
> problem with it at all, is that two of the patches overlapped on one > of the files, such that one backed out a change and then another put > that same change back again.

This also seems to reflect a philosophical point that it might be
worth mentioning in the development guide (which is probably overdue
for an overhaul in general).=C2=A0 Namely, Philippe felt it important to have one patch that completely backed out two or more of my previous
patches, followed by a patch that incorporated a useful part of one of
those patches.

This isn't generally how we've approached things -- we just move forward incrementally from the tip of the branch.
--0000000000009f2b4a05ee2e116c--