Re: [PATCH] NEWS item about the ERR_EXIT fixes

[Philippe Altherr <philippe.altherr@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1171 bytes --]

>
> I think it's overly verbose; NEWS doesn't have to explain how
> ERR_EXIT works.  Here's a possible alternative:


Overall looks good to me but see comments below.

+  - Function calls, anonymous functions, and the `eval`, `.`, and
> +    `source` commands no longer propagate ERR_EXIT suppression.


This kind of suggests that these constructs always propagated the
suppression, which isn't the case, but the exact circumstances look too
complex to explain. Maybe replace "no longer" with "now never".


> +The ERR_RETURN option is now suppressed when a function containing
> +a compound sublist (`&&` or `||`) is called from within another compound
> +sublist.


 I find this a bit cryptic. It may also give the wrong impression that
functions containing a compound sublist are a special case. And finally,
the same is true for functions called in if/while conditions. Here is an
alternative:

The ERR_RETURN option is now always suppressed on the left of `&&` and `||`
> (now even in commands within functions called from contexts where
> ERR_RETURN is suppressed).


The part in parenthesis gives a hint on what changed but maybe that could
be left out.

Philippe

[-- Attachment #2: Type: text/html, Size: 1972 bytes --]