From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,HTML_MESSAGE,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 19564 invoked from network); 9 Dec 2022 09:31:34 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 9 Dec 2022 09:31:34 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1670578294; b=GKXqiOJR/R3O1VJ93E22d7zM/VLTdUH4MnEfE4Uuk6APOg2Enz0TfVUa0yEGxem0dG+gcIg85n O6agrgLddlStjhb9jJSrTO/UWTGslUcXbFahZwudd7Xp7w2t6c4IEV2U91VZ5ZwkoM3/oI0wr4 WNxEvEct1v33oME0sks0B9AXbeu3IolfAobJ1AWj5MmwOjbepFWWvVsvLRZPFPZ8v3DjuMm3zT VrkwspdNJnt1r0UeCrrsD6Ek4ouRlTobHWU/zvNXsEix3hd1mc1M4F3jtuVA+DGQDuSGMs3px6 xv54pjbOKkijF8cdHiqs9NlIYq1nRZUZ0x747RATPnUTFg==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-vs1-f43.google.com) smtp.remote-ip=209.85.217.43; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1670578294; bh=mieMSuvRGeb2AXQcAYm9HsIv/+hAjuKABN3MpJNd2yo=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=gRRevOcPEETvwoa+IVqPbJ/4lc8lYhqiZIaUdlqZUHhj2/GxstggetGyCPAsG1691aNXGmZ5lF 2MelflhMCBZSxGVYVZUZVp+Jw/zJgQ0dfBnBkBNeCPGmaISC8PR8RZZGQ43u/mlKEQt6aRra/8 E2i1fwz0G8bXyMod+ee1DKOqC2wn4pHPWsohwFmnT1O4VWX62Ru016Dnxn9mNbvLzMbwSpaQIN bkd5jKvIY1Khpj7CAtZunGSp4T416MGucEsqCaS4NnDaslM2VraZFqaxUkVOMbcAOC6BQlkHou NJCVLWdFiOWz4AYtbBnHBwoscJfhscfYS3l6q6s2BbMAlQ==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=eI6wzMqNPhDT6H/PT0sgW1uMd6mKDyKwjGEu+ojjOSg=; b=BfmC44QMKlcUT+fSCFrG/I1JU5 ADDYOyzj/HssT3CN3/6J0CPGO8Mx8TXNiJvlWKmbAbSWI9E44koWqZ7R3+HZjETtT2C1rlZpxM4v0 a2HgSoTX201TNAKYfY97q3LBepQ4CRE0suU7IMYVeVV3fSS/I96dKaTVwtqXNf8y6qGPtSz36R2Qf UjS0pIIjLTaLeLLXPPMVtrBY5ex3UfODdfWUey5QL91OL3sLgaqqMyCUov//55U/JcnLd39Tgovgc xp5vwftYuwdck37V4gHdMCANjdRHwt3kDlxR1VcWa5so1sygSCXaYpBxF/7Sr2BSsnNej0smEbi2Q odvfuINQ==; Received: by zero.zsh.org with local id 1p3ZjA-0001MR-OP; Fri, 09 Dec 2022 09:31:32 +0000 Authentication-Results: zsh.org; iprev=pass (mail-vs1-f43.google.com) smtp.remote-ip=209.85.217.43; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-vs1-f43.google.com ([209.85.217.43]:42583) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1p3Zid-00014G-MB; Fri, 09 Dec 2022 09:31:00 +0000 Received: by mail-vs1-f43.google.com with SMTP id 125so3883856vsi.9; Fri, 09 Dec 2022 01:30:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=eI6wzMqNPhDT6H/PT0sgW1uMd6mKDyKwjGEu+ojjOSg=; b=CvGLR3AiB94B5jlqxjFu+VFOTCAysgSkKxTgEkXKkab5lmg+PpIkC5AXr5cNhFpdAH amHUhBhhlO/5eRAu7kbEZTR4alG1/2N/tHahbun9bi+nLK/DcTkVrtJqEq/fKKDo33ae vY0fT+d2nT3ECOpwxQWN3yg3GluNrEeKVJM3MM+V5KlD1pevP75/0g+H1EW6zhC8A/xO 27mA9xGY6UykClsBFGuO8xb0dfwk1pglNVlE4HBqLcHsWTcIFMQe7Ml4Xkf98RJaC2AR TOasp0f4Bu2day8I66pKNgUDZ9iDnjYK81phh9IfcTXQTSOBfCNrvSqsUQS9Qzc2tFUz pR7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eI6wzMqNPhDT6H/PT0sgW1uMd6mKDyKwjGEu+ojjOSg=; b=sduJNeXSKDU50WGsA3Uh+V1KxnqoaDVa1vFMXIE2/9DrbIgB1PeZjjYdcE78DvMOPN slXk1Zl7pzzcnEL+uQIwdtHOiwE70mZIYoW7SVND8h028Fjk2mbH4MrhHYED1kkVYksp ZkaiG+Cv0mgdlymnhghl8Dt9PZsqHYkEZk4VVtFd+YUQYPdcUtz/hmLzqwb4HGE+R+yn jLxWCcGjJMVk7KRd+t9a6Ex8erTHTO7JnbTMMNBfRZQVoZPfmnQVHBPi/QrjmJZO6ZbJ 5GtAlgoWSl9RB9axLjjQJHIaujqOTtLtqBj2YU0dwAgIl/cFHaAzKKhoH5TBeZN6xwvN 0tBA== X-Gm-Message-State: ANoB5pnB4GYNC+ze62UTdDqwoJK/PcUU/FylsHQWPUcgUYa032Sc0rjs ERyqmQdrMgN3yHGpq2lIb4CUNXLvr38y1UaTsTRwhDMgeqM= X-Google-Smtp-Source: AA0mqf5Yxguk6da+j9kDYlWvX56GCameur3IpSzwA866dT6APwUkJb2ovurmvx8oJlcnKHZHGXt5bcRlWyiuykUVQkU= X-Received: by 2002:a67:eb92:0:b0:3b2:e50f:ca09 with SMTP id e18-20020a67eb92000000b003b2e50fca09mr8001960vso.29.1670578257776; Fri, 09 Dec 2022 01:30:57 -0800 (PST) MIME-Version: 1.0 References: <46fcb939-0ed9-4b51-959d-67339181e3e3@app.fastmail.com> In-Reply-To: <46fcb939-0ed9-4b51-959d-67339181e3e3@app.fastmail.com> From: Philippe Altherr Date: Fri, 9 Dec 2022 10:30:46 +0100 Message-ID: Subject: Re: [PATCH] NEWS item about the ERR_EXIT fixes To: =?UTF-8?Q?Lawrence_Vel=C3=A1zquez?= Cc: Bart Schaefer , zsh-workers@zsh.org Content-Type: multipart/alternative; boundary="0000000000009fd3b705ef61cf96" X-Seq: 51151 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: --0000000000009fd3b705ef61cf96 Content-Type: text/plain; charset="UTF-8" > > I think it's overly verbose; NEWS doesn't have to explain how > ERR_EXIT works. Here's a possible alternative: Overall looks good to me but see comments below. + - Function calls, anonymous functions, and the `eval`, `.`, and > + `source` commands no longer propagate ERR_EXIT suppression. This kind of suggests that these constructs always propagated the suppression, which isn't the case, but the exact circumstances look too complex to explain. Maybe replace "no longer" with "now never". > +The ERR_RETURN option is now suppressed when a function containing > +a compound sublist (`&&` or `||`) is called from within another compound > +sublist. I find this a bit cryptic. It may also give the wrong impression that functions containing a compound sublist are a special case. And finally, the same is true for functions called in if/while conditions. Here is an alternative: The ERR_RETURN option is now always suppressed on the left of `&&` and `||` > (now even in commands within functions called from contexts where > ERR_RETURN is suppressed). The part in parenthesis gives a hint on what changed but maybe that could be left out. Philippe --0000000000009fd3b705ef61cf96 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I think it's overly verbose; NEWS doesn't have to explai= n how
ERR_EXIT works.=C2=A0 Here's a possible alternative:

Overall looks good to me but see comments below.

+=C2=A0 = - Function calls, anonymous functions, and the `eval`, `.`, and
+=C2=A0 = =C2=A0 `source` commands no longer propagate ERR_EXIT suppression.

This kind of=C2=A0suggests that these constructs al= ways propagated the suppression, which isn't the case, but the exact ci= rcumstances=C2=A0look too complex to explain. Maybe replace=C2=A0"no l= onger" with "now never".
=C2=A0
+The ERR_RETURN option is now suppress= ed when a function containing
+a compound sublist (`&&` or `||`)= is called from within another compound
+sublist.

<= /div>
=C2=A0I find this a bit cryptic. It may also give the wrong impre= ssion that functions containing a compound sublist are a special case. And = finally, the same is true for functions called in if/while conditions. Here= is an alternative:

The ERR_RETURN option is now always suppressed on the left o= f `&&` and `||` (now even in commands within=C2=A0functions called = from contexts where ERR_RETURN is suppressed).

<= div>The part in parenthesis gives a hint on what changed but maybe that cou= ld be left out.

Philippe

--0000000000009fd3b705ef61cf96--