From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,HTML_MESSAGE,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 17096 invoked from network); 3 Dec 2022 01:37:11 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 3 Dec 2022 01:37:11 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1670031431; b=F2R1RrpzT64tr6zNFesUF7H5XQRK60/GrddV0lx9FFFpqvPig8zXb4wyz95H76vQhnutrFI7pu kPp4YeOhVo9wSEoOQiiTsdXlD16wVRI3tkHGEpq+oFOHuhQE1s/Jz+ydSRjTEIVoxQ8cZ3o+m/ g5vOQxvuISqa0TJB6tr3HHsSZSRpgJI71O6GSQAcFg34HPbkBPMV+EVMcnDqlAvMFcYRQ6cHCN V90cH2zz+0VHZfUSVaAFYhDjNpkgY1D5TuwcVQiMym0mAb+Z7hVOCBkCQKBqkEscUEE1LGGZuJ 9buk1WwsnvMM3mbtDz9pbVeTc71I/7hBURES0D++JRi9kw==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-vk1-f174.google.com) smtp.remote-ip=209.85.221.174; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1670031431; bh=Qw3VBUe+UQsGsHkjBmsznBW3svMaySj+LUvFe15e2gk=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=LbDR8eKm4oyGJFNAbb0fkyZqh1w34C4M8ChbcKwaiIWJD5GYnpDzOmqJ1RIeE0QJQFi96TY3yA g+w8BCsXLcoUfKAr+r6IRTyzLMjKGipaHymHF/WzDDYv+tjh+aheON/SeYS3/FBl9UgqVFZKTj JszkzUELgaiLwts1OFaBJiG6GKpn+BVFHBjfBnoncFCAYhmdHouOFO3BZclHBZB5QAIM776vj0 mlKn9TJgIHz0E3TQXVmRzlGliLs8+YXAuUiV5XU1kJwqta7rtk2Yosa2dUBFTz8amfekYSRvAe sRZVuiq3Ws/LYBILHNuleXQ45WI5FpfuO3B3oJJqSwDT+g==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=Qw3VBUe+UQsGsHkjBmsznBW3svMaySj+LUvFe15e2gk=; b=i7/0YmP+2k4ltIIi6fXTzDeH4j wcQWPKwTccbnwzKYt59PjXwGhLcLQlFOpBmsJ9UhHyekkcMeWV9oxvfjqnIXww8dgqShBQv3Zy0ki Y2RZFgirKb1kvDGoEIg/dTNaoqbvReLPsST29QGInUTpmz5QSbIQ34dfnhqiQnE5ABLky4CKtnM4v rTa/QHaQfOyfZh4X2+ohV2G4JLAkRrPL0V1S/Kh7Oa/2ZxlYfwW6z1PEYY3Oq2DZ26mNFoBs3+Vws /GhPEAFBl68/uK+m7qZBjLAYcKwEi5UKn4cIPB7iWfhipIhfSWmBVyl1T1xaS0fwKEB5mGJS79jCl 8EqdIX5Q==; Received: by zero.zsh.org with local id 1p1HSo-000EYA-A5; Sat, 03 Dec 2022 01:37:10 +0000 Authentication-Results: zsh.org; iprev=pass (mail-vk1-f174.google.com) smtp.remote-ip=209.85.221.174; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-vk1-f174.google.com ([209.85.221.174]:41903) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1p1HSM-000EIM-Co; Sat, 03 Dec 2022 01:36:50 +0000 Received: by mail-vk1-f174.google.com with SMTP id f68so3059241vkc.8; Fri, 02 Dec 2022 17:36:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Qw3VBUe+UQsGsHkjBmsznBW3svMaySj+LUvFe15e2gk=; b=COgg8oCRxVYRCQjaQPSdopJ3NaHRAsMcDVSbEBFk3Q0/vE1+DSn6vDbNnnpfyBbbcV M63G11oPLudzVB4RCz8Pptf8nxmeciWd0Bc375NmxiNPGcZIIf2CjiZ+wAVYnAz7r6S5 dsfzndf0Sf6h3BHl1Qc8lAQJukPFG1CyKiOcvRdraQ3GU+0Cm0os2OAEqvp4KVh7+JSH ygfpPAmWekm2yIsxGuR6+61y/q+WGrA8dIJccMeju+RX0WgdjjkMK5NDOGvtsf07Bb95 PTObRplP70lsLh9BwkJyFEWgclL1zS1G5u32vJspoMz1h6i2flKr7I3lQDwQ1P414W3E rGfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Qw3VBUe+UQsGsHkjBmsznBW3svMaySj+LUvFe15e2gk=; b=QuSA7nEYEPf9ZNKLoqzy8d1fx9UJIcGj3nj6kILUcmuxeuNjF4a5I4qfyG64wvtH2O 6Y1ITsAAC7httPqxVneR+FlnbvkB/XXz+8vTBVJcd9h+ZieaOXehbRbgg8lI41mouj89 1i4WB9rdpOQ2HPHB1BkKSbnulEqk9L3TvVxzr6/6cwtYtEZkRjsrWt9pPLS4Sjrk/OBS x6PmVPtqpj0ZVa3qPA3PlVtHbeZbVY+JTs+7Cl9BR6g61bLGh1UzqQkMq15isc5fphEK SEenl+qAjJRHr0sgbUbrVubbRSh44Pw13wNCAFJKKEmSiWY47bFBOxk7ev2LyrDPF2d5 9CdA== X-Gm-Message-State: ANoB5pkzEiaNQSvfjDPFmR1arduBY4zwETbBZD747Kkr3VT//YKvaRgK b/jlv4okSp8HUTM7U5O1/2W/GwKaGiei5sAmqPkaKKw3B8o= X-Google-Smtp-Source: AA0mqf73i0w42M20xeI5baXA99TaJT1ElHYxKds7ikWYDMbJXORW79Czf7z3JkFMb9vxi2cmbqEPC/MZ2YjtbiG3Dgg= X-Received: by 2002:a1f:b693:0:b0:3bc:7ad1:1e2e with SMTP id g141-20020a1fb693000000b003bc7ad11e2emr32814009vkf.7.1670031401348; Fri, 02 Dec 2022 17:36:41 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Philippe Altherr Date: Sat, 3 Dec 2022 02:36:30 +0100 Message-ID: Subject: Re: [Patch] Fix ERR_RETURN behavior in and/or statements To: Bart Schaefer Cc: Zsh hackers list , =?UTF-8?Q?Lawrence_Vel=C3=A1zquez?= Content-Type: multipart/alternative; boundary="00000000000070f4bb05eee27c7b" X-Seq: 51096 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: --00000000000070f4bb05eee27c7b Content-Type: text/plain; charset="UTF-8" Fyi: my 2 messages about my 7th patch (patch-07-remove-noerrexit-until-exec.txt) are currently stuck in the moderation queue. No clue why. Philippe On Sat, Dec 3, 2022 at 2:31 AM Philippe Altherr wrote: > Hi Bart, > > With my last patch (patch-08-use-or-assignments-to-set-noerrexit-bits), I > think that I'm done with code changes. The best way to understand all of my > changes might be to first apply all my 8 patches and have a look at all the > places that deal with noerrexit (just grep for noerrexit in all files). The > noerrexit logic is now quite a bit smaller and also more regular. For > example all places that deal with conditions (if condition, while > condition, left of &&/||, and right of !) now behave in very similar ways. > Same for all compound commands. You can then have a look at the individual > patches. > > Philippe > > > On Sat, Nov 26, 2022 at 4:47 AM Philippe Altherr < > philippe.altherr@gmail.com> wrote: > >> I'll take a look at all of this in a couple of days. >>> >> >> Sounds good >> >> I just sent a 6th patch. With that, all the errexit issues I'm aware of >> are fixed. >> >> I still have on my todo list to write a NEWS item that documents the >> changes/fixes. So there will be a 7th patch but that one will only touch >> the NEWS file. >> >> There is one last thing that I don't understand in the errexit code, >> namely the NOERREXIT_UNTIL_EXEC bit used in execif. I will spend some time >> studying it in the next few days. Hopefully, I don't discover new issues :-) >> >> Philippe >> >> --00000000000070f4bb05eee27c7b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Fyi: my 2 messages about my 7th patch (patch-07-remove-noe= rrexit-until-exec.txt) are currently stuck in the moderation queue. No clue= why.

Philippe


On Sat, Dec 3, 2022 = at 2:31 AM Philippe Altherr <philippe.altherr@gmail.com> wrote:
Hi Bart,

W= ith my last patch (patch-08-use-or-assignments-to-set-noerrexit-bits), I th= ink that I'm done with code changes. The best way to understand all of = my changes might be to first apply all my 8 patches=C2=A0and have a look at= all the places that deal with noerrexit (just grep for noerrexit in all fi= les). The noerrexit logic is now quite a bit smaller and also more regular.= For example all places that deal with conditions (if condition, while cond= ition, left of &&/||, and right of !) now behave in very similar wa= ys. Same for all compound commands. You can then have a look at the individ= ual patches.

Philippe

On Sat, = Nov 26, 2022 at 4:47 AM Philippe Altherr <philippe.altherr@gmail.com> wrote:=
I'll take a look at all of this in a couple of days.

Sounds good

I just sent a 6t= h patch. With that, all the errexit issues I'm aware of are fixed.

I still have on my todo list to write a NEWS item that= documents the changes/fixes. So there will be a 7th patch but that one wil= l only touch the NEWS file.

There is one last thin= g that I don't understand in the errexit code, namely the=C2=A0NOERREXI= T_UNTIL_EXEC bit used in execif. I will spend some time studying it in the = next few days. Hopefully, I don't discover new issues=C2=A0:-)

Philippe

--00000000000070f4bb05eee27c7b--