From: Philippe Altherr <philippe.altherr@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] More ERR_EXIT (was Re: Tests RE behavior of ERR_EXIT)
Date: Sun, 13 Nov 2022 21:55:58 +0100 [thread overview]
Message-ID: <CAGdYchvPG9XCQWAm=AD3Q4QtbihLzsG-REZAq1pw6zchkGKGhw@mail.gmail.com> (raw)
In-Reply-To: <CAGdYchtTNtEwOeeNSGkUKDRyu1ZWAPF_z8bCtaPe8od=qKptRA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1609 bytes --]
Here is one thing that could explain why the "where" statement is an
outlier (at least compared to the other compound commands that I have
tested so far). It's the only case where after evaluating "false && true"
you have to first evaluate a whole other command, the loop condition,
before deciding whether you trigger an ERR_EXIT for the "while". For the
other compound commands, you evaluate the "false && true" and then
immediately decide whether you trigger an ERR_EXIT for the compound command.
Here is an observation that could save some complexity. A non-zero exit
status either immediately triggers an ERR_EXIT, like in "false" or it
doesn't like in "false && true" and instead bubbles up to the first
enclosing function or subshell thanks to exception 3. Thus, compound
commands other than subshells never have to trigger an ERR_EXIT. That's a
nice and not necessarily obvious side benefit of exception 3. I wonder
whether the code was designed without that insight or maybe without knowing
about exception 3 altogether. Without exception 3, compound commands
sometimes have to trigger an ERR_EXIT and that could explain some of the
current code and behavior.
Philippe
On Sun, Nov 13, 2022 at 7:37 PM Philippe Altherr <philippe.altherr@gmail.com>
wrote:
> NOERREXIT_UNTIL_EXEC is what protects the tests between keywords "if"
>> and "then" and those between "while" and "do" from triggering
>
> ERR_EXIT.
>
>
> Really? NOERREXIT_UNTIL_EXEC is only ever set in execif. How can it impact
> the code of a while statement? There is no trace of it in execwhile. What
> am I missing?
>
> Philippe
>
>
[-- Attachment #2: Type: text/html, Size: 2475 bytes --]
next prev parent reply other threads:[~2022-11-13 20:56 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-12 22:16 Philippe Altherr
2022-11-13 3:59 ` Philippe Altherr
2022-11-13 4:11 ` Bart Schaefer
2022-11-13 13:55 ` Philippe Altherr
2022-11-13 14:24 ` Philippe Altherr
2022-11-13 15:45 ` Philippe Altherr
2022-11-13 16:52 ` Bart Schaefer
2022-11-13 16:45 ` Bart Schaefer
2022-11-13 16:53 ` Bart Schaefer
2022-11-13 18:37 ` Philippe Altherr
2022-11-13 20:55 ` Philippe Altherr [this message]
2022-11-13 22:27 ` Bart Schaefer
2022-11-13 23:10 ` Lawrence Velázquez
2022-11-13 22:12 ` Bart Schaefer
2022-11-15 1:11 ` Bart Schaefer
2022-11-15 7:01 ` [PATCH] Even more ERR_EXIT (was Re: More ERR_EXIT " Bart Schaefer
2022-11-15 7:30 ` Philippe Altherr
2022-11-15 19:50 ` Philippe Altherr
2022-11-15 7:26 ` [PATCH] More ERR_EXIT (was " Philippe Altherr
2022-11-15 19:18 ` Philippe Altherr
2022-11-15 21:08 ` Bart Schaefer
2022-11-16 2:41 ` Lawrence Velázquez
2022-11-16 6:31 ` Philippe Altherr
2022-11-16 5:51 ` Bart Schaefer
2022-11-16 7:56 ` Philippe Altherr
2022-11-16 14:21 ` Philippe Altherr
-- strict thread matches above, loose matches on Subject: below --
2022-11-09 5:29 Tests RE behavior of ERR_EXIT Bart Schaefer
2022-11-10 5:22 ` [PATCH] More ERR_EXIT (was Re: Tests RE behavior of ERR_EXIT) Bart Schaefer
2022-11-10 5:47 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGdYchvPG9XCQWAm=AD3Q4QtbihLzsG-REZAq1pw6zchkGKGhw@mail.gmail.com' \
--to=philippe.altherr@gmail.com \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).