From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 20418 invoked from network); 27 Apr 2022 00:34:39 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 27 Apr 2022 00:34:39 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1651019679; b=chy4VzqfsVsVrqVxBGRFsfuqvB5IjZ9rLMLAa+MbVJFS8znv2OtsveFIB5cmmN9Umu9bxBwPP0 dPRTYO5XQNlFr4EyNBXQ17WEH//tzUMOKXjpQuJmbHNR9pXYFJ5eIf0TunajXnR66Dst0ze9l4 oSfOHlFRNDU2IvAWgeA29N7k2C8cSXyu40HPeZM9y2JGykmG5X6qpxpjzBM3wbZwF3Yc+bLKt4 Zo5q0/2r+VQm+b82Den7EWUXa4LwQo7Ipht1q7lb1P1IflTyvLuf8X0qD2b+q7CvNblTWbaBdU is5pWF+CpFXB0wN/GDNaGuHLABTsJvKBR7r5tn3z9TDvnQ==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-ed1-f52.google.com) smtp.remote-ip=209.85.208.52; dkim=pass header.d=brasslantern-com.20210112.gappssmtp.com header.s=20210112 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1651019679; bh=mFZ7DWMUHY41EoJ3x4PBu3bFisyh+giXXRhnSTvIm9g=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=aKOTdlfIGJE4xngiBIgftUBzYGvPbNmtbjvMV7K6K+n9DYz7h0V8RIe9DqRmY0cmRR0gDh/ZuU 8GYLZzVM6M0bxjnyIUSHx4xNqpprKakQLPEK3x0xvWraX+asbBX9AQtMoOIIBmgi1WTG52pouK 7NlhJBH29NJqb5tfhxArs/fJnCTj+1xkqvyo4AMzjWnbSivdbPpLa1PuHfddsm1aRu4XhxVa4e S0XV8P+HKryAjp9i94dHK+OudrNOp3L9zd6BVsdKn/DZVXufR5qHL1an7xyxJfuHYvfCCl0iSC De8bcAbK4Z9JwMsqEhvh3tYaHrZiRrOs8HqmeXjf+fhyhw==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=mFZ7DWMUHY41EoJ3x4PBu3bFisyh+giXXRhnSTvIm9g=; b=fD/96L+kevfIpLxREl3vdGrxIw n11zxRmBTrHns9/L5Cq3DI9l3rq3tL0KVGhSk6w1I2BverG1xMafIMDwqAUCiuBOefqg6taKFHuWt GwmjN22k5S2nf7qlDMHPMG4ewl+JnhdnyXD4LX5U7XAFvMPqXb2Jq9rdFFr/tmGZ/nt5PGeVBBCzi PjAwiLcuU/Hc+RaWKC7voxW4f2pqF/3yT0iPv4TGysvMpgc2RtKHTUdKFwNUtoheQe7di3O7IpzUQ 0Q5RjuM4or7qrRZf5jUoLZu0E5G6zXqg6e0KVV7mR8CD1eUpQKwxHp6gfv8RIbMIiUuhlY4eYP3qJ mukVmGag==; Received: from authenticated user by zero.zsh.org with local id 1njVdd-000Ei6-Aa; Wed, 27 Apr 2022 00:34:37 +0000 Authentication-Results: zsh.org; iprev=pass (mail-ed1-f52.google.com) smtp.remote-ip=209.85.208.52; dkim=pass header.d=brasslantern-com.20210112.gappssmtp.com header.s=20210112 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-ed1-f52.google.com ([209.85.208.52]:40724) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1njVd2-000EPf-NT; Wed, 27 Apr 2022 00:34:01 +0000 Received: by mail-ed1-f52.google.com with SMTP id p18so181077edr.7 for ; Tue, 26 Apr 2022 17:34:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mFZ7DWMUHY41EoJ3x4PBu3bFisyh+giXXRhnSTvIm9g=; b=0pHkZrrbE6+0T0V5DYpuWrS5pxtwDXLvNaecB8/bppSZxA2E6o0OXShODpEqCRxZqP eOleKfguupKZtuYDnBAzSSYckkZPA92Z1nnP0v4yWBUg0pNI28i0TCbktu0taQfDwiZ2 7blzxWxoXdG0G0gcvPJCUejKmlly7utrhFGX0RECBCN5G8KE1xZ8Bz8ZGxb1f5vhBDlL sPlRqxOAofSATnQHyPZkWJ8OfnWU1MIUMDq6s6C1LNZ79bID5ojZPY7TfSuYDXCyeyJ+ gZ6deqtBtLDKsT5p1lfppoc6Z2sgLvj+JyOFBMqg6liCreGVSjtI4RHtmvK4wTwFsaDZ 4HEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mFZ7DWMUHY41EoJ3x4PBu3bFisyh+giXXRhnSTvIm9g=; b=BF/duY/mwmqaxPIe4C60UeV0iP2XX41tppvI4/rvocTokKDcI/3cZZoXY5p8x0Kdug 9oqUHOVtFo8bSy9FAKRpq5FjOOpmjGXBt8nD7y7lNVfBgjy0vCSuhlGxmPJz5SytGvVl w+JZQAMnHyDx6A54F9YebiM4tUmAybJWpCM9oYdCwahhNYwm23TKNePAWUc4Fxqs3Zqj 1RceyIaCQZ13snz3Y8vyzKocA2M1V5hskU7YKPykFTuWb76RlOX/ct5k6xyNosLknA4p 6lGLNEiX9graR7OHiXLgbpxdTC0sVlZHYhHdrHVpgjTnq88o2H00SHll1upsaH5eGVCY yc1Q== X-Gm-Message-State: AOAM533HJLtaCzmqybTXhO+r221PrWGRgi+RvayW3MzhhwNSUSsu4JzI 8eWTaLNk5UyNY4sH2c2dc4MbzUXXqZwVpsuyOfkuvg== X-Google-Smtp-Source: ABdhPJxgEIoXNoq92yeTsx8alBEF6vYmm/E2EFNYya+VBENKUJav6CNTZdf5dlu75j8XaEsYMsEb/54Lm1czUphXSzk= X-Received: by 2002:a05:6402:84c:b0:423:e5a2:3655 with SMTP id b12-20020a056402084c00b00423e5a23655mr27810766edz.28.1651019640274; Tue, 26 Apr 2022 17:34:00 -0700 (PDT) MIME-Version: 1.0 References: <20220425192036.p6awbyro2a2lp7bq@chazelas.org> <1592299421.100566.1650961915601@mail2.virginmedia.com> In-Reply-To: <1592299421.100566.1650961915601@mail2.virginmedia.com> From: Bart Schaefer Date: Tue, 26 Apr 2022 17:33:49 -0700 Message-ID: Subject: Re: ZSH performance regression in 5.8.1.2-test To: Peter Stephenson Cc: Zsh hackers list Content-Type: text/plain; charset="UTF-8" X-Seq: 50109 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: On Tue, Apr 26, 2022 at 1:32 AM Peter Stephenson wrote: > > Not sure how much difference it makes but to avoid additional system calls > we could cache the result, invalidating it when we open a new file. I considered that but there's no good way to isolate it to input.c ... SHIN could be the same FD number across open/close/open, for example. However, I think isset(SHINSTDIN) could be tested earlier in shingetchar to reduce the number of system calls.