From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-42189-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 13540 invoked by alias); 30 Dec 2017 17:44:42 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
List-Unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
X-Seq: 42189
Received: (qmail 7555 invoked by uid 1010); 30 Dec 2017 17:44:42 -0000
X-Qmail-Scanner-Diagnostics: from mail-qk0-f182.google.com by f.primenet.com.au (envelope-from <schaefer@brasslantern.com>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1.  
 Clear:RC:0(209.85.220.182):SA:0(-1.9/5.0):. 
 Processed in 10.544065 secs); 30 Dec 2017 17:44:42 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS,
	T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1
X-Envelope-From: schaefer@brasslantern.com
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=brasslantern-com.20150623.gappssmtp.com; s=20150623;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to;
        bh=sHhvHy5i4dh6tpnL9xiffvnA5lZ6EqPs3grFgUoMhm0=;
        b=jSF6+8DA60a/0uxvI2lnJa5LWISwL+v8s2gP9nnMl4zuQkvyV8wc5Ied+Hcl+zha9f
         JTDSd6d/rV1vorkzYLfKg1haTWk7AigDyYAYuEcBsxmbKHrHoOJDdXx9LbfrpTY8A1Fj
         /Z7NA7bVnHQI/oWCiY7nTD35kSNBosaPgKyWC0qGyyTxpUMD1DA/bMeZbUcsR1l8wjkR
         +g66laRvcZibh5502IVoHk2kHhH0MsLUWnT6ukuEpSuc+8aYHfsOdAYnIu8V+U8SeBFi
         6V/F0oii01juxCaQ85vuRx8gY0u0bFmgByikl6ne9Ly71JFraNw34yxVsCyAWwpXM3jY
         /e8A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:in-reply-to:references:from:date
         :message-id:subject:to;
        bh=sHhvHy5i4dh6tpnL9xiffvnA5lZ6EqPs3grFgUoMhm0=;
        b=K4yTI+9JrR28YTFkLGVwzfgclbyCG7/adlfmUz/YZQyGD7CsOpupXKfWl3IeJmCETN
         EqBQCZOGMtlaFjW+MWDeecmOntWxPsY4vMFIUCy+Ue+lf4i8CMiLaUXv8HjyWbxxo1Em
         b3uuLBrWZzHAoMdAT7phZVVRqWDkvhLl1v3sJuy2/FIgaRhiO6XOTTcGguqJ29NoQlbd
         FwI7vzKdvLaKZ+UNiNFa8TneB8c3wtYdmsIfl0kUlEYxST8BBVNoA+Rdu7odfndGx+fe
         QiV78dpxk5STQCcILrMHPtwUKU2qbKDWgsX/PdtNIFPGKUGXgtDhmWWtERO6xTPsq9k0
         i1Ng==
X-Gm-Message-State: AKGB3mKVvbalQUXP3mdHTC5GTdCo/UbSDcLMTM/09pJiA1ZZmJzhbwwA
	SUOvd7RvIGKWxc7xDPCBCx0w4f1ZcLO5LTJx0d2M1A==
X-Google-Smtp-Source: ACJfBouVklp36b9nCDiQi9w0uqpy4GMLf7g144GxtHh56R5Dq0o6vBA69DZO+7EslK/3KzDDxDDYbzc0gnnA1Z3nAYc=
X-Received: by 10.55.151.71 with SMTP id z68mr49469743qkd.83.1514655868744;
 Sat, 30 Dec 2017 09:44:28 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <etPan.5a47b193.2c35fec7.13d7@zdharma.org>
References: <etPan.5a47b193.2c35fec7.13d7@zdharma.org>
From: Bart Schaefer <schaefer@brasslantern.com>
Date: Sat, 30 Dec 2017 09:44:28 -0800
Message-ID: <CAH+w=7Y0ATw8DY3_yHtRqXXSrTAruFJi_uV=dKtrGOXCViCYHQ@mail.gmail.com>
Subject: Re: [PATCH] zsystem flock: zclose descriptor after unsuccessful lock
To: "zsh-workers@zsh.org" <zsh-workers@zsh.org>
Content-Type: text/plain; charset="UTF-8"

On Sat, Dec 30, 2017 at 7:32 AM, Sebastian Gniazdowski
<psprint@zdharma.org> wrote:
> The patch adds preceding zclose(flock_fd) to all return 1 and return 2 code paths.

Nothing wrong with the patch but the original code structure looks
funny.  Why do we return without calling zwarnnam() when errflag?  I
suppose the assumption is that it only gets set if we already output
some other error message?