From: Bart Schaefer <schaefer@brasslantern.com>
To: Marlon Richert <marlon.richert@gmail.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: [PATCH] Re: Bug: Callback to widget set with `zle -Fw <widget>` shouldn't change $LASTWIDGET
Date: Mon, 16 Jan 2023 16:01:42 -0800 [thread overview]
Message-ID: <CAH+w=7Y4jT5kNNSkCXZMcFg7kzTew3LDfLgq8zPkr30D5=QSsA@mail.gmail.com> (raw)
In-Reply-To: <CAHLkEDuuosi7udHsQ9uaBRcv5poEUU_i1iSRGgEXFbtBkzHQOQ@mail.gmail.com>
Is this good enough, or is there a need to consider that the handler
might delete the previous last widget? What does/should happen in
that case (or when a widget deletes itself, for that matter)?
diff --git a/Src/Zle/zle_main.c b/Src/Zle/zle_main.c
index 686c6f5b4..cfa0a739d 100644
--- a/Src/Zle/zle_main.c
+++ b/Src/Zle/zle_main.c
@@ -737,6 +737,7 @@ raw_getbyte(long do_keytmout, char *cptr, int full)
) {
/* Handle the fd. */
char *fdbuf;
+ Thingy save_lbindk = lbindk;
{
char buf[BDIGBUFSIZE];
convbase(buf, lwatch_fd->fd, 10);
@@ -779,6 +780,7 @@ raw_getbyte(long do_keytmout, char *cptr, int full)
*/
errtry = 1;
}
+ lbindk = save_lbindk;
}
}
/* Function may have invalidated the display. */
next prev parent reply other threads:[~2023-01-17 0:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 15:06 Marlon Richert
2022-11-16 18:24 ` Bart Schaefer
2022-11-17 13:04 ` Marlon Richert
2022-11-17 13:28 ` Roman Perepelitsa
2022-11-17 16:18 ` Bart Schaefer
2023-01-11 7:45 ` Marlon Richert
2023-01-17 0:01 ` Bart Schaefer [this message]
2023-01-17 9:22 ` [PATCH] " Peter Stephenson
2023-01-17 18:00 ` Bart Schaefer
2023-07-16 10:28 ` dana
2023-07-17 8:42 ` Peter Stephenson
2023-07-17 15:17 ` Bart Schaefer
2023-07-17 15:52 ` dana
2023-07-17 15:57 ` Bart Schaefer
2023-07-17 16:57 ` Bart Schaefer
2023-07-20 4:01 ` dana
2023-07-20 4:25 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7Y4jT5kNNSkCXZMcFg7kzTew3LDfLgq8zPkr30D5=QSsA@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=marlon.richert@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).