From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: problem with 'ls | less' shell function
Date: Wed, 19 Oct 2022 17:10:50 -0700 [thread overview]
Message-ID: <CAH+w=7Y7X4AvdzxU1sdHUyT6oLR7zcW8qXoQEHsm6ubW=9kUqw@mail.gmail.com> (raw)
In-Reply-To: <Y0+0olfiaDplISd7@localhost>
On Wed, Oct 19, 2022 at 1:28 AM <zsugabubus@national.shitposting.agency> wrote:
>
> I think what happens is that zsh fails to correctly set the foreground
> process group in `fg`. `less` is not in the foreground pgrp that's why
> it immediately gets suspended by SIGTTIN after it receives SIGCONT.
First sentence partly wrong, second sentence right.
When a shell function is suspended with ^Z, the parent shell forks
again to create a process for the shell function, but doesn't change
the process group of the pipeline. When "fg" brings the shell
function process back, that process is made group leader, but it then
needs to reset the group leader again to the pid of its own foreground
job, which it does not ... or, conversely, upon suspend the parent
shell needs to avoid changing the group leader of the new process.
At this point I'm not sure which of those needs to happen or where.
It's all in or around the call to addproc() at exec.c line 1734.
next prev parent reply other threads:[~2022-10-20 0:12 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-17 9:17 Thomas Klausner
2022-10-17 14:50 ` Mikael Magnusson
2022-10-17 15:36 ` Thomas Klausner
2022-10-19 8:26 ` zsugabubus
2022-10-19 10:04 ` Jun T
2022-10-19 13:36 ` Jun. T
2022-10-20 0:10 ` Bart Schaefer [this message]
2022-10-20 16:26 ` Peter Stephenson
2022-10-21 5:45 ` Jun T
2022-10-21 7:40 ` Jun T
2022-10-21 21:22 ` Bart Schaefer
2022-10-21 21:24 ` Bart Schaefer
2022-10-22 23:22 ` Bart Schaefer
2022-10-22 23:43 ` Bart Schaefer
2022-11-03 23:10 ` Bart Schaefer
2022-11-04 6:09 ` [PATCH] " Bart Schaefer
2022-11-04 15:10 ` [PATCH] " Jun T
2022-11-05 0:09 ` Bart Schaefer
2022-11-06 19:12 ` Bart Schaefer
2022-11-07 8:43 ` Jun T
2022-11-07 19:33 ` Bart Schaefer
2022-11-07 19:44 ` Roman Perepelitsa
2022-11-08 0:46 ` Bart Schaefer
2022-11-08 0:44 ` Bart Schaefer
2022-11-08 5:03 ` Bart Schaefer
2022-11-09 5:03 ` Bart Schaefer
2022-10-19 9:33 ` Jun T
2022-10-19 10:01 ` Jun T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7Y7X4AvdzxU1sdHUyT6oLR7zcW8qXoQEHsm6ubW=9kUqw@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).