From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 15754 invoked from network); 30 Mar 2022 16:41:53 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 30 Mar 2022 16:41:53 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1648658513; b=Qg2WavCSjGOABMcZh8qOAlDnQn5LbgpTEniZ4gdGmJ0gTPn5Rz/MUFXwJRVMZpr9BH20+5p4rn 3xbNxAafnTMHaWDB+n8bC2+WU22zUO3WIgAMjmbwOyfdr9K+QeWb4LQFAP3eb/JJXdT+Y6SsfW thFT+3hjp1vf/ZbTMKvBo7hjY9Qz+ApKgXx7c23P+NXXG78r5Qa625y+i+cG7z3rhF5P7sig/n YRGFWCuYvB/WvviBoFX8UyNIAgsLEk96qVCQFbjw4hDGxg8VOAv7ANc37M9J13tRlP89R7fvzs evXZg1ZV0ed2wvw1eb69W8LEumGocez2Ubxh4ULhw/+seg==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-lj1-f171.google.com) smtp.remote-ip=209.85.208.171; dkim=pass header.d=brasslantern-com.20210112.gappssmtp.com header.s=20210112 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1648658513; bh=TMjzJgsWZZny0ggus8HAp0LtMSacthslR/4m6dPFlB8=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:Cc:To:Subject: Message-ID:Date:From:In-Reply-To:References:MIME-Version:DKIM-Signature: DKIM-Signature; b=hV3OpYMjqkpQrj0zNi4F5KlX1XikKOWobrpLRMSSeVM7TutASqwqRaV0CEDQXYMHzIw7vGbGE3 XOJD+HSi9igcJsotnwH1yECdty5Be6a39LbTIPh6wkd3eOfE0Tu6LN7Mk6O8o3EvByLgbbQ1ii ujXUFbWwPjmyiG1YOMaoZeyQBnuc7PvAXOyY/ZtOHrbNBpfjsU+gWAGF/a1ROgDDhprVLkAUJ6 cC6UzLldITGVmUewuezatLNmb0PsGkYX8Jt9HL8iMsKKovJ9leY3lTg+ewXxKg9OivAqmJByLQ BNQxyCmzJV3AFVjLqsTbEZmitICNrtuab28JMWzjT0aInA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=lyxcOkG7kbEuu6HTSwBQwGETHdw5s3KXJ8j0pYTkkuo=; b=YF7gxqlCA9LE9I3w5lCz+4X93+ r7QRRiueFIl/FFoTtvzUa0ODq3rcnHxvPz4ppq2kBCrZT3vHVUUAc/KLnlnpHTYcX49/QRpvjI4vw JQMif8aNZkT2I7BxNE+z++LUGWQ1CTIq27NT1S2HNprp5GroFHGeZ8uObQajR5uh0knlASQ8vy9Ya CwDAXJ1EZMsNSom3fe8zMW5bfcSa0ePqCZo9KhdK1a7mh0qB664yFNrnD8GIcKzzEaC60Hg+2fhpk gUirqqTWlnviwVBGn9Gl7ouZSBiLbvHYk5v/+9PkIzG+PWDy9J4c4Xk42ZPQ/jKM6lIvu8GYUia1H pp/jdf/g==; Received: from authenticated user by zero.zsh.org with local id 1nZbOJ-0004BL-E8; Wed, 30 Mar 2022 16:41:51 +0000 Authentication-Results: zsh.org; iprev=pass (mail-lj1-f171.google.com) smtp.remote-ip=209.85.208.171; dkim=pass header.d=brasslantern-com.20210112.gappssmtp.com header.s=20210112 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-lj1-f171.google.com ([209.85.208.171]:47065) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1nZbNm-0003rP-FJ; Wed, 30 Mar 2022 16:41:19 +0000 Received: by mail-lj1-f171.google.com with SMTP id a30so20992301ljq.13 for ; Wed, 30 Mar 2022 09:41:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=lyxcOkG7kbEuu6HTSwBQwGETHdw5s3KXJ8j0pYTkkuo=; b=Wdxib3ZHQzzQLrCAVsSFHetzRD5n7jonBPaFx+WHDfzvTlZu9SF43+74x15wUqRchb 8h9DG/66F4x81USgCKz64fgGpjkQi6KcmXz1M/i9lQKSR0ZuLu1R28AhLiLDdF4h7UfI 4BV2qfJojo9uvuQBbMb77XjYk6uLTAKquOzfD1+49d5R7hyY/a0wiF1utTnKZ+AKS8mg 9y/PyDMr39IHTgHUeg7T/ddD2wiGA99GZQal2CoUbv0RrI4PfRWUTo1jDhqrfXNZbsEb jmJzVpoEntTNgKMCmLtu4ga5vJ1yN0zZALbtpUHCvA45pzBXVe6pKbYa99avIHY/Uj6Y sXDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=lyxcOkG7kbEuu6HTSwBQwGETHdw5s3KXJ8j0pYTkkuo=; b=xnWdNtGNGXa0O9TkwqnmUJ3HWbM6jooeQPNomknOluYWDeGp2GFFYpqyQMdK0N0/NE erhbF+WUnrJ78at7OoPiNj3flvUV8x5KC87+V/8iq+GA5+5cjAfSVI268Z7Z9V8aIWL/ JzvMfVl0SiDm3rNlHhx29d23j0x60n0IBEkk528NfrxGWP8DfMUm8+yGp40tFEXz2DVZ JU/nYAtqREWMxB7PnPP2gqDoBIBa1NRmVnMwYZVgeeKmSB8G1VwSrXbeNpFpG8VdXeYm 0yFesAaB8T8Utgv292GnB9cGHWBVOzku01RRiNt/hFrq+n/saQe99lBPXtWjz9pZI4Nq g6IA== X-Gm-Message-State: AOAM532lq//EV9FPGAKDiMP2RumFHSev7g++14DEGDGYuBmd7Fwc9kN+ Q9RjMO9gq5on9lYMCotdlQVIq0K4D64d1xGYj5XReA== X-Google-Smtp-Source: ABdhPJwPp/jbZ5ISEKCmC2BUMj6AY1qhlMGcADlR4rGWMYE8lzSerTe6D97aQmoLNYFafibkL/Vr1DgUtJMOkhWV6k8= X-Received: by 2002:a2e:8745:0:b0:248:600:6649 with SMTP id q5-20020a2e8745000000b0024806006649mr7317466ljj.63.1648658477472; Wed, 30 Mar 2022 09:41:17 -0700 (PDT) MIME-Version: 1.0 References: <20220326014030.2802-1-mikachu@gmail.com> <20220326014330.3050-1-mikachu@gmail.com> In-Reply-To: <20220326014330.3050-1-mikachu@gmail.com> From: Bart Schaefer Date: Wed, 30 Mar 2022 09:41:06 -0700 Message-ID: Subject: Re: PATCH 2/2: [WIP] Efficient dedup for unsorted completions To: Mikael Magnusson Cc: Zsh hackers list Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Seq: 49926 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: On Fri, Mar 25, 2022 at 6:44 PM Mikael Magnusson wrote: > > This implements my idea for sorting a temporary array and then using > that for deduplication. Minor nit, but after this patch I get: compcore.c: In function =E2=80=98makearray=E2=80=99: compcore.c:3289:26: warning: unused variable =E2=80=98i=E2=80=99 [-Wunused-= variable] 3289 | int dup, i, del =3D 0; | ^