From: Bart Schaefer <schaefer@brasslantern.com>
To: Marlon Richert <marlon.richert@gmail.com>
Cc: "Lawrence Velázquez" <larryv@zsh.org>,
"Zsh hackers list" <zsh-workers@zsh.org>
Subject: Re: Let run-help filter cmd_args before calling run-help-<command> (was Re: [RFC][PATCH] Try calling command with help flags in run-help)
Date: Fri, 30 Jul 2021 09:55:13 -0700 [thread overview]
Message-ID: <CAH+w=7Y=yBfgTR=QDRm2cMZkrrhVJRtccT1mpyBpcXKf_9jaTw@mail.gmail.com> (raw)
In-Reply-To: <CAHLkEDu7+k=f=B=A0uLWTj0676VYM9fM_=RcB0e2sgeHPeULoA@mail.gmail.com>
This one appears clean. Thanks.
On Thu, Jul 29, 2021 at 5:11 AM Marlon Richert <marlon.richert@gmail.com> wrote:
>
> On Wed, Jul 28, 2021 at 8:58 PM Bart Schaefer <schaefer@brasslantern.com> wrote:
> >
> > On Sun, Jul 18, 2021 at 11:46 AM Lawrence Velázquez <larryv@zsh.org> wrote:
> > >
> > > On Sun, Jun 20, 2021, at 2:01 PM, Lawrence Velázquez wrote:
> > > > On Sat, Jun 5, 2021, at 3:15 PM, Marlon Richert wrote:
> > > > > New patch here with test cases, plus a rewrite of run-help-git. All the
> > > > > tests succeed for both the new and old versions of the run-help-*
> > > > > functions (except for the old run-help-git, because the new
> > > > > run-help-git uses `git help` instead of `man`).
> > > > >
> > > > > Attachments:
> > > > > * 0001-Let-run-help-filter-cmd_args-before-calling-run-help.txt
> > > >
> > > > bump
> > >
> > > bump bump
> >
> > Nothing obviously wrong with the code patch, but one of the test cases
> > fails for me:
> >
> > --- /tmp/zsh.ztst.50384/ztst.out 2021-07-28 10:56:06.301935368 -0700
> > +++ /tmp/zsh.ztst.50384/ztst.tout 2021-07-28 10:56:06.301935368 -0700
> > @@ -1,2 +0,0 @@
> > -git is WHENCE:{git}
> > -GIT:{'help' 'git'}
> > Test ./Z03run-help.ztst failed: output differs from expected as shown above for:
> > BUFFER_STACK='git --exec-path'
> > Was testing: git with option
> > ./Z03run-help.ztst: test failed.
>
> Looks like I somehow managed to omit some lines from the tests in the
> patch. Here's a new patch, differing only in the `run-help git` tests:
prev parent reply other threads:[~2021-07-30 16:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 20:47 [RFC][PATCH] Try calling command with help flags in run-help Marlon Richert
2021-05-25 20:57 ` Bart Schaefer
2021-06-02 18:26 ` [PATCH] Let run-help try to show function source from file (was Re: [RFC][PATCH] Try calling command with help flags in run-help) Marlon Richert
2021-06-20 21:23 ` Lawrence Velázquez
2021-07-18 18:38 ` Lawrence Velázquez
2021-07-28 2:03 ` Bart Schaefer
2021-06-02 20:58 ` Let run-help filter cmd_args before calling run-help-<command> " Marlon Richert
2021-06-03 4:34 ` Bart Schaefer
2021-06-03 4:38 ` Bart Schaefer
2021-06-03 21:26 ` Marlon Richert
2021-06-03 21:45 ` Lawrence Velázquez
2021-06-03 21:52 ` Bart Schaefer
2021-06-03 22:00 ` Lawrence Velázquez
2021-06-03 23:33 ` Bart Schaefer
2021-06-05 19:15 ` Marlon Richert
2021-06-20 18:01 ` Lawrence Velázquez
2021-07-18 18:45 ` Lawrence Velázquez
2021-07-28 17:58 ` Bart Schaefer
2021-07-29 12:11 ` Marlon Richert
2021-07-30 16:55 ` Bart Schaefer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7Y=yBfgTR=QDRm2cMZkrrhVJRtccT1mpyBpcXKf_9jaTw@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=larryv@zsh.org \
--cc=marlon.richert@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).