From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 14529 invoked from network); 30 Jul 2021 16:56:05 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 30 Jul 2021 16:56:05 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1627664165; b=dFubTCSpM1Dm1BP5wPtyJ0pXOAFmdLUMG8Oc6LHooLWS5QlvHaXDHLXUJdbHEUGXHgZR+T8vF6 tSfrqv5yCkDvRC6Nlk6/FtvnL5DkiJGXGLdznETp0ud1oAFvo/XzUPgnI6EyiFAMPERJucSZlq K+UvKmDNC+qozWMbgxTQ37GovFI7VpvNf/Fj0UU+Adq+mgbwvirfY++VfdksTwLOpYPULY82ZA LSUHeXtt2C8gFg+N7zRMYU/5y7sLjzFTkXT3FozrjvSZKJPX4inZGvEUC3qJvgIogH4k4KjYZ6 pdCyEDEtPzM5R7gRtO/eHENk5sUNPWj9AIbb/DG6WvV3zw==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-yb1-f169.google.com) smtp.remote-ip=209.85.219.169; dkim=pass header.d=brasslantern-com.20150623.gappssmtp.com header.s=20150623 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1627664165; bh=3JP40rUhvP6Ku3ml6ayf5rg08BvRR+LQWA+ChVq16j0=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:Cc:To:Subject: Message-ID:Date:From:In-Reply-To:References:MIME-Version:DKIM-Signature: DKIM-Signature; b=QxI/H0WFHX1t4LKcZhqTZ5CSC9WdR7w+LQJHnH9R/3ODUfUiviW9dwJqX7R6BGmGkjqUv81CnE T8uv2ad9SUnR7TMdBV2BQpoIkFcEl+g0IjGIo7s4GXl8uovzUY4f+1b5HWWgJZ0o7Bz6/M2AXv uOkClZ3Q3eOj26I5MMq1TkQpr2Q4HjBvs1F3Df6v+JHOIkmxHmQtIkFgV+ROHX8uWWgOYj7lGp 1ywe0wIqjNGH3c0T92F5HMIYlXLS3TC6qu0FCnwtHW3CyheB1/y9Ae6I86yfJQ3NeY+RQL4Nfd qsyIVcusxn4cQp+uxm2C2FyycyOWSPlVrWbn5Mt1haFauQ==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=OoP3+j1j3ZaeMgvQpgAB8Ye3B0nZEMvQvjL0JvvYF/M=; b=1URT3TURlmJmHpXro6YuJZdHh8 lFaDEfUpDepm43I05QhbVf+QKCoNVdg/m9mjuipKzpbEuPue91pEi0J15gJcw8sv5Z8LZhJdLdykk Aw+3n7Kiy7nhVm0FYgduMNF48k834FPc4SA4scM+MIgX2VCwfNw20Dt11H378PT+1TNaSnQp3QsQv s1lJs3oyohgpFqGhKPzZ+I7zGPZy+NiOTkm/px2y06PQnVIbWqOvV04KuFqU5uSSLpZkDUhQGVQSc +ssaexH8uF1cDY0hWiDl8M4klcSfYY3CjsCA9ZqSynFPA37N8kyEmx4DKt9eaHDU2HOxEqJmNTTRW 3QsS3PNQ==; Received: from authenticated user by zero.zsh.org with local id 1m9Vno-000MPg-3T; Fri, 30 Jul 2021 16:56:04 +0000 Authentication-Results: zsh.org; iprev=pass (mail-yb1-f169.google.com) smtp.remote-ip=209.85.219.169; dkim=pass header.d=brasslantern-com.20150623.gappssmtp.com header.s=20150623 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-yb1-f169.google.com ([209.85.219.169]:40491) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1m9VnB-000M68-Rm; Fri, 30 Jul 2021 16:55:26 +0000 Received: by mail-yb1-f169.google.com with SMTP id s48so16997790ybi.7 for ; Fri, 30 Jul 2021 09:55:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=OoP3+j1j3ZaeMgvQpgAB8Ye3B0nZEMvQvjL0JvvYF/M=; b=Yhc7qK+IMoJJ5c6w9HZO22StUvvOb4vOv8vVhEvq8CrAMB4O6iZ+ngi41+csycZdkn sZOq1DRuWmDUPNPXe4/Uw+ScvEsBbhg5DM8p7lRqgs5Xmzz5g7LDUg5A5H9eXHBiEQWk EPLQdkiTPaooXpg+k5bAzEO8LlDY+lI27iHwhCfW7wui7ZEckPqsDWTbnTkgh7BwZRoG PgQQ/cZ7774bCjcEm/CkiPecz9/grB8XT6JR62CjA9xFb4yoOrSti7C5ji8vYdYlt6mV p0U2C8fYP3S1WDt9vRgtOLQ4ObP8XtfC3LSJxcCS7oF/u9QKsLYs+dFY3ucl8Crql2er 0Ukw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=OoP3+j1j3ZaeMgvQpgAB8Ye3B0nZEMvQvjL0JvvYF/M=; b=QZVuOyc31QYxdSW8jWuOluWUigbuq0yyWG20VdeeVx7kaIS0Ww9NmKUqA71ejDlZqq mTPjpSbxErOqxf+B6VLfVEF6+LG0FHE82Qe+P3xMdQFJu9eAZtmVJc9UhGjJRz5CGoYi Bc6N1HmV1Z7RTcP5yq7NLJt32gOqFFIB5a503I6tc3kCvlUTclLCyfvITRGQgs3RwU8p 7xxQpxiyL9OYwmAqRa/Zzh8Jg986sFQ33tdjVfdWMYQNnqfZO04BuFbq+wJKXg1PHdBn uU5waRTXTMeIvzZoZz7V+oRW40jug0saBMpKw4CIx/oLT8FB3J+F80ogIXax1iSNfUn7 /zfg== X-Gm-Message-State: AOAM530UbqdGyXX2Ksm0lBQZstY0Y4Sh2fYe9LjTlIjzjyCJJ3OG6f9u sTkhmlT7ZYf3pD7Bf1z1R3DkKomI56EkI7mN0THO1A== X-Google-Smtp-Source: ABdhPJzHz7p8WUDG35ORy0lINZWHIEJ4FNgYrsrQj45QB9yrQcX0GpgCNNp4Q8EhFsBIfV2xDBC6LSRguwWv8M3DS5A= X-Received: by 2002:a25:31c5:: with SMTP id x188mr4482293ybx.291.1627664124598; Fri, 30 Jul 2021 09:55:24 -0700 (PDT) MIME-Version: 1.0 References: <3f494f65-cede-41f5-862f-cfd8424668ea@www.fastmail.com> <0f3f4217-44f6-4bf9-b2d2-2110ae10d40e@www.fastmail.com> In-Reply-To: From: Bart Schaefer Date: Fri, 30 Jul 2021 09:55:13 -0700 Message-ID: Subject: Re: Let run-help filter cmd_args before calling run-help- (was Re: [RFC][PATCH] Try calling command with help flags in run-help) To: Marlon Richert Cc: =?UTF-8?Q?Lawrence_Vel=C3=A1zquez?= , Zsh hackers list Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Seq: 49222 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: This one appears clean. Thanks. On Thu, Jul 29, 2021 at 5:11 AM Marlon Richert w= rote: > > On Wed, Jul 28, 2021 at 8:58 PM Bart Schaefer = wrote: > > > > On Sun, Jul 18, 2021 at 11:46 AM Lawrence Vel=C3=A1zquez wrote: > > > > > > On Sun, Jun 20, 2021, at 2:01 PM, Lawrence Vel=C3=A1zquez wrote: > > > > On Sat, Jun 5, 2021, at 3:15 PM, Marlon Richert wrote: > > > > > New patch here with test cases, plus a rewrite of run-help-git. A= ll the > > > > > tests succeed for both the new and old versions of the run-help-* > > > > > functions (except for the old run-help-git, because the new > > > > > run-help-git uses `git help` instead of `man`). > > > > > > > > > > Attachments: > > > > > * 0001-Let-run-help-filter-cmd_args-before-calling-run-help.txt > > > > > > > > bump > > > > > > bump bump > > > > Nothing obviously wrong with the code patch, but one of the test cases > > fails for me: > > > > --- /tmp/zsh.ztst.50384/ztst.out 2021-07-28 10:56:06.301935368 -0700 > > +++ /tmp/zsh.ztst.50384/ztst.tout 2021-07-28 10:56:06.301935368 -070= 0 > > @@ -1,2 +0,0 @@ > > -git is WHENCE:{git} > > -GIT:{'help' 'git'} > > Test ./Z03run-help.ztst failed: output differs from expected as shown a= bove for: > > BUFFER_STACK=3D'git --exec-path' > > Was testing: git with option > > ./Z03run-help.ztst: test failed. > > Looks like I somehow managed to omit some lines from the tests in the > patch. Here's a new patch, differing only in the `run-help git` tests: