From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 22073 invoked from network); 21 Apr 2021 20:41:20 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 21 Apr 2021 20:41:20 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1619037680; b=tj3DIz4CNd6zDrZqR86sLTfiLuGg556vQdyc/XGK7NM9GRmFRNXRiBUg+h4l0N6hVX3A75RyL7 EDrdKT4V+/BFXxetIrc6oxPiNbSKi3K271QqAesycWNdDH0K7XDwEWG7mcoCzidSLYL1NWE6f1 mwoR6XLnbW/xdPMp3z15gH6qfJ+P80dBl38tqd077B3cw6E2tFPFARf0C3htPTcT5vTdZgmKFH lDYQNX8h9pFDohuB/DUhZ9QjIQFnTvFQd96KpgeGb5bh8+rVmJFV6p8KV6QkA+yeRLRGcebWgi TiebYApxKwETxd/V7Cdk9rrcgr/VuPUEcRGYJFqZVZJdDg==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-ot1-f52.google.com) smtp.remote-ip=209.85.210.52; dkim=pass header.d=brasslantern-com.20150623.gappssmtp.com header.s=20150623 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1619037680; bh=+ZFdWePyIpxEPf5wZX9ZsoNz6de9tR3mFp2BhqxVhGI=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=oOk3DyxVpBROX1SziIQPHFWAgRnllZvwm9awQY1J5pA88OvqygsPdiSX0LPR0BbEE8zJGBCUSq ikOkS9d/eA9Z5bcdiKXCQCuJPuFZN9k+b4of90xDxk7ylBthqYalfu/CmoIdPEWpLr+sNZFQWs XLJYVZTQ8cDvoB0DJ61QgPvMTFOShTrRInsvgUKz4GD/0XtRBspzsDBGZZhQRYacI/2Qxwcvgr g5YJMRV2YmialnTMNSe3XjqfWMrlWqXq/i0kwHWmY+qdzQA9YNwVmXiYRhnNIngmbjh35xDTqv P5TW0iHcT+IsiQu7mn1l7yHdb+x+lXkS6CLdYROhsv4rbA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=lkdZdLJgbL2qGWbSUDYFUa4YKzKGKb6uY40gv248mTY=; b=mvFiCMC+OTMpXqA7cXWIt8anZW X6YI8DwA5HLEbpJl5HHViJNfoNMB9H6YvbotcBd6djgy4OnqfrpjbnDq9v8Pj3PEIkgKSxUKjeeQR eP97wekNCNqTsHEZ2EdWTxbeay4nmbI/9t8luvR1LPO84KvlEyuDnk4NW98rCLp0P69iiXubEZ+SB TKGfdCezzCo1mq0AWHy1fBC9SicYS0lugJMlyBG+u/r54V1e/UuFLbNjiwMteWW7Jp0w0lRLHm19R I13CphgyJQkQ8IP5kly2RmX0URs27eOeER9ZftuICdOM/3+5vvHFAY4iKloA7rEKup2C1tgISjmPM f7ftvckw==; Received: from authenticated user by zero.zsh.org with local id 1lZJew-0001Ix-A5; Wed, 21 Apr 2021 20:41:18 +0000 Authentication-Results: zsh.org; iprev=pass (mail-ot1-f52.google.com) smtp.remote-ip=209.85.210.52; dkim=pass header.d=brasslantern-com.20150623.gappssmtp.com header.s=20150623 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-ot1-f52.google.com ([209.85.210.52]:41553) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1lZJeC-000125-KZ; Wed, 21 Apr 2021 20:40:33 +0000 Received: by mail-ot1-f52.google.com with SMTP id v19-20020a0568300913b029028423b78c2dso31489002ott.8 for ; Wed, 21 Apr 2021 13:40:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lkdZdLJgbL2qGWbSUDYFUa4YKzKGKb6uY40gv248mTY=; b=gued9gGn6ILtNbHjkwid0+Gk/ZKObvf20lWKyeInVB6sye2dxpset67K3QzMlBYyvy i57Ubo57vky074rzFuFytL1g+Bi49u5VkXJHVbZ/p7xGHIatYCtoI/VXG3aNOrRTtePu c7CUWKy36OiBK4GxmW09v8hr8QkYwyUoksvzDB6UIRc/kG8vX4oR1XdnGwZ6veE3WQik SdDJ3p/LZDHURND36ACaBGUkt1PsvMs2Y7y7qNcJbqSGivSzFbXjnTo71OqH9qu2O557 /lI1AXmtOB9B/MrwFHBaCj5lNIhTw9ghg3Tb13StDJrklNP5T+Q3UWCKv4nzpv1756ef Ypmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lkdZdLJgbL2qGWbSUDYFUa4YKzKGKb6uY40gv248mTY=; b=h//JD8W0CO+aOQI9KxoStn355woW7SNhR5iiR5+73oYvxGg/txCrgdTqkVBt4p0Y+B cCw+sejTk8UKowjX8QTBoGUKrV5IbROdwNOd8xFYx0s4ttEAXturXxrgEZCCBPnkL/k/ 0WX/zlqUmH+d8NL1Kca/vKlPeZ3J+wVVEzSPVPxYCI3CZVlVdiEgFJGoumRnjfus0tZc IQTX0WGNRItgGmXxAMuQSF97jWoQtkPD6GYlDiHT6SwKq1Wt84D0h3EWQfTu0mCLMq9T e0+m0hwN97Xc9+PsZTXiZEODu4vzwMd/3+Bbuj2ckHbRYYJQGq6O0nM/rwdqXR8EX40Y RUmg== X-Gm-Message-State: AOAM531jyu8DFiJbmwJju4VbveyTRQktJEMx/fr7B9uIJYhUo975rsXS RpqPanJg99B+7LKzyu142Cntq5ooBxmNhC4pDbksDQ== X-Google-Smtp-Source: ABdhPJz0x+5t1TD58FSRhYWKvcfRTvDGEH/T7MSw9mYdEVyYxRYffaqinv4Iip80iR0lhhQKCAJw2u/yVg5PaCS4FM8= X-Received: by 2002:a05:6830:55b:: with SMTP id l27mr25110otb.260.1619037631371; Wed, 21 Apr 2021 13:40:31 -0700 (PDT) MIME-Version: 1.0 References: <95CDA630-4EE5-4003-8D9C-CCCB9A47F109@gmail.com> <4D587C0C-EB5F-4A58-A0AE-D45E43F432CD@gmail.com> In-Reply-To: From: Bart Schaefer Date: Wed, 21 Apr 2021 13:40:20 -0700 Message-ID: Subject: Re: [PATCH] Add execute-command() widget function (was Re: [RFC][PATCH] Add change-directory() widget function) To: Marlon Richert Cc: Daniel Shahaf , Zsh hackers list Content-Type: text/plain; charset="UTF-8" X-Seq: 48646 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: On Wed, Apr 21, 2021 at 4:37 AM Marlon Richert wrote: > > Thank you both (Bart & Daniel) for your input. I added better safeguards against the non-PS1 cases, rewrote the function to be more generic and added comments. New patch attached. I remain confused about why .push-line-or-edit rather than .push-input ? I think you're making this more complicated than necessary.