zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: Marlon Richert <marlon.richert@gmail.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [PATCH] Fix a logic bug in _zle
Date: Mon, 31 May 2021 14:56:34 -0700	[thread overview]
Message-ID: <CAH+w=7YBq1UtKT_E8FTjySU2kQecxetzX8N4CW3JtL-UdGhvfA@mail.gmail.com> (raw)
In-Reply-To: <CAHLkEDsedEs-O-6OLaFPdPOGM33n4A9px2sqCtm_rEFA49qmsw@mail.gmail.com>

On Mon, May 31, 2021 at 10:49 AM Marlon Richert
<marlon.richert@gmail.com> wrote:
>
> On Mon, May 31, 2021 at 8:08 PM Bart Schaefer <schaefer@brasslantern.com> wrote:
> >
> > For purposes of the commit log, we should be told what this means in
> > terms of a behavior change.
>
> Is it good enough this way?

Better, but you could have just said that in the email text rather
than embed it in the patch file.

However, I can't figure out when $state[1] == widget-function is ever
true.  Did you possibly mean widget-or-function ?  If not, can you
give an example?


  reply	other threads:[~2021-05-31 21:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-31  8:50 Marlon Richert
2021-05-31 17:08 ` Bart Schaefer
2021-05-31 17:48   ` Marlon Richert
2021-05-31 21:56     ` Bart Schaefer [this message]
2021-06-01  8:53       ` Marlon Richert
2021-07-18 22:31         ` Lawrence Velázquez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH+w=7YBq1UtKT_E8FTjySU2kQecxetzX8N4CW3JtL-UdGhvfA@mail.gmail.com' \
    --to=schaefer@brasslantern.com \
    --cc=marlon.richert@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).