From: Bart Schaefer <schaefer@brasslantern.com>
To: Marlon Richert <marlon.richert@gmail.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: Proposal: Let compinit make standard widgets with _generic instead of _main_complete
Date: Sun, 4 Apr 2021 12:31:35 -0700 [thread overview]
Message-ID: <CAH+w=7YBw90q-r1Zoyn=gSFgOtx6+13K-kOVXi0kdVG=GMV0bw@mail.gmail.com> (raw)
In-Reply-To: <CAH+w=7YAxLGd=cTFkOqHXiUpk1iPp=7u3-qvEKmE6dTSELcoMA@mail.gmail.com>
On Sun, Apr 4, 2021 at 11:35 AM Bart Schaefer <schaefer@brasslantern.com> wrote:
>
> The problem with calling _generic at all (right now) is that it messes
> with $curcontext in a way that may break other functions that rely on
> _main_complete behavior. If we can invert the call sequence so
> _main_complete remains first, then _generic itself can be tweaked so
> that it does NOT mung the context in that circumstance
Sorry, that's also an incomplete explanation, and it might not be only
_generic that needs tweaking.
Suppose I want to invoke _complete_debug. It's supposed to emulate
complete-word, but has a hardwired call to _main_complete. If
complete-word is _generic, then when I try _complete_debug I won't get
a backtrace that actually matches what happens when I complete-word.
If instead _main_complete runs _generic, the backtrace from
_complete_debug is correct, and there's an opportunity to build some
additional intelligence into _complete_debug because it can check
which widgets are _generic. Similar things apply to _complete_help,
etc.
next prev parent reply other threads:[~2021-04-04 19:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 22:23 Marlon Richert
2021-03-20 18:09 ` Bart Schaefer
2021-03-20 23:52 ` Bart Schaefer
2021-03-21 15:19 ` Marlon Richert
2021-03-22 1:46 ` Bart Schaefer
2021-03-22 7:16 ` Marlon Richert
2021-04-03 19:37 ` Lawrence Velázquez
2021-04-04 18:35 ` Bart Schaefer
2021-04-04 19:31 ` Bart Schaefer [this message]
2021-04-09 19:11 ` Oliver Kiddle
2021-04-09 19:35 ` Bart Schaefer
2021-05-09 20:51 ` Lawrence Velázquez
2021-05-10 17:11 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7YBw90q-r1Zoyn=gSFgOtx6+13K-kOVXi0kdVG=GMV0bw@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=marlon.richert@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).