From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: from zero.zsh.org (zero.zsh.org [IPv6:2a02:898:31:0:48:4558:7a:7368]) by inbox.vuxu.org (Postfix) with ESMTP id C3556254DA for ; Sat, 17 Feb 2024 07:30:00 +0100 (CET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1708151400; b=YQMrfvB1QnWd7PMoB6TmWVjVhbO+LmHX99pcAHXE6JTJQ0LzdeeqdpJaEWIHricSnWkFbjgHrg nlh5JRqlgd+K/mtUp5KyWnUfszYnehNpdXsyQUCYTrxFLRy6p6suhgUecwm2fsQvVxNNRW3GLU oLdFmqulhPP2nEgd6imTDCpQAmo7h3FPRo3KFf7wlyOH/SEMQqQUDi6fmga/WJKh/XpgUQ5EyO dGAvpc8TfQYyJ732lE16pcPECeT0t5otCDiQxjdOdj5kSkCZD9aFmPD6ESqavjbwSNnsnGredT ObH6pql/VIo1RCytT3MFPbxmpYcMur/rpUJg/9Ct7hM9Ng==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-lf1-f50.google.com) smtp.remote-ip=209.85.167.50; dkim=pass header.d=brasslantern-com.20230601.gappssmtp.com header.s=20230601 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1708151400; bh=HbXOdb9/5NiX6owR8+FpeIvH02Dm2SB+DZ5F2FRmwfU=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:To:Subject:Message-ID: Date:From:In-Reply-To:References:MIME-Version:DKIM-Signature:DKIM-Signature; b=I/tK3iLXyy1PzGqunXB5pyh7+Cl7xC0Sd+DH82SbhpkV8+oI7d6K3tOQDdKko7UIGog4JKe2VP jLYlFBiuVm2vFVmz9rKG4Axbkr6aoWBbx/mpM0nq9ruBk8r+THMvS1T9CqrB1Oq4pYJfkpIlZ9 75urHy1kc6d5MZVREgSeP7rKM0uVl3tb7kvpSK+57+1IdW30+0cX9Tf/Bcd53XnmwDVn/8jTAb eOHIAW+oew3/SqlyKYmsSC3Yyr8YUHUW+Mu1VBc3BExXyiKMOqKHM8KJHpH3RmyC6rgnhLz9mz PRzzFTlgA9pN+ifrTbnPqYGpL3nMGeXaYKnqz/fu223PRA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:To:Subject:Message-ID:Date:From:In-Reply-To:References: MIME-Version:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=2SVKP865DMFpBMNvNNXebUYRGJXB7O1ziFClZ8MHB08=; b=hWKU575whqxUzIDhnly3LLbouv T8z2u6JMZDB+qLGtAnVPW1xpdMCEIHt0SdpdESWB9OPw3tIvyLWbSHXvQtVOWnxjN8R2Dh1hRHRZc Y2WMU6K0ioBatkmrtCKWRHPBx6WVEkQMOqm/ttGN3PqHG8/41AgclKSCtsSDn3xoC1WGmz39aREEy h0KEa2WpheHVDnibIYYe/QVC5DMpXlkQ7ZK8eBmHw1DOfwGHINaUsLiNokLrttmhSolp/Wjas7OV+ nSVt64qPA9aUTPw1nbsX4XsBuOnUvnQ5gP1PwJi3x2NYiw3HHykOF1PutK2tlf2yQLbBo4q7AP0n/ UYuJgm0Q==; Received: by zero.zsh.org with local id 1rbED0-000IMi-HW; Sat, 17 Feb 2024 06:29:58 +0000 Authentication-Results: zsh.org; iprev=pass (mail-lf1-f50.google.com) smtp.remote-ip=209.85.167.50; dkim=pass header.d=brasslantern-com.20230601.gappssmtp.com header.s=20230601 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-lf1-f50.google.com ([209.85.167.50]:58519) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1rbECQ-000I2R-JD; Sat, 17 Feb 2024 06:29:23 +0000 Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-5114b2b3b73so3248284e87.0 for ; Fri, 16 Feb 2024 22:29:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20230601.gappssmtp.com; s=20230601; t=1708151361; x=1708756161; darn=zsh.org; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2SVKP865DMFpBMNvNNXebUYRGJXB7O1ziFClZ8MHB08=; b=UPSifO41rCrCj/HVa7iUt+IVIxd5l2+I+tArox+9uLmj1yK0/FLHZNygoh/EUuFjQB f3uA7YDmNdIpt3/u/8s0PlbkWPNytxbHXQjhNqJ/AO/QSe7yAnRRnlJu01PF0KiglKru 4qoc0/Zh7d4Q+n8xyVp+IKEttfpQDfImz9v/IgpQlJH39hyaitXrUtjSRIsb+zj2o8Ok LyYykgXsOARIpt67jy/5cc8Cqx8H53VGoUsxlnyzFtUvb5AjeyWMv7S9Lj4364ZFUKWD pOMWcXu5WSbMrk7PSwzNVoQmeWe56NhUHhrclinkktPnuTW01+nY8Vuuc4ekR+Ju3zLT s+yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708151361; x=1708756161; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2SVKP865DMFpBMNvNNXebUYRGJXB7O1ziFClZ8MHB08=; b=XCpgEpWmaRfWhpL/pAmzg8caGLismBMcJWRWOvNnEGJli9amrK2NZXHXHHkH6VbZd1 n35CyDwE86QtltGuzk9znyeOVg8+OeGZ/ifJoEYP4A+kz5sAyrt/N5B19qW8eVU5s4bI PHzQ5aVw0bT1lNbm/EOr2q4zQuIKCQCh4F/PywljxjTBoqQYyRZmWOsTiEDFXIsY4Psq Fvpk7Tm7CYxj255YZngY9TIUI5rZRP5B/vd7bdMpMVx0+1hlgLdySRoitoJYQp18KDOb WSKAfFybDV7Ucm4k47CnhVd/k1EcV+llVcFmwzuBT9YBDB7AD2SjIWBLh6jnh29anNJv Lptw== X-Gm-Message-State: AOJu0Yxx/lbtTsxzJgGxTaUqy48vYXPVmdjAmiIer5Ine98A5CzHOvvf Zj1tcVPm2F3qqAG3H/z36Fg0/+vb44F2O9enNQtx8hEwXvpcwv0ltUcZmih2rbk/damE/6UH8dG I2IpnLlkRkIO2RQ13oH1i5G6WN6wX2Fjlrdy3pZTAuosp0SEvIA== X-Google-Smtp-Source: AGHT+IE3/UwbQRXWr0qHgQa2apN7/JLVVZ3sw7FBehIhRyxCZ8R0jrjFXnNhiVP1igy1uTaSHKmp6CUuX2LElsz/Nh0= X-Received: by 2002:ac2:5dfa:0:b0:511:ac60:2b01 with SMTP id z26-20020ac25dfa000000b00511ac602b01mr4274745lfq.32.1708151361408; Fri, 16 Feb 2024 22:29:21 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Bart Schaefer Date: Fri, 16 Feb 2024 22:29:10 -0800 Message-ID: Subject: Regression of typeset output with "private" To: Zsh hackers list Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Seq: 52554 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: On Fri, Feb 16, 2024 at 12:09=E2=80=AFPM Bart Schaefer wrote: > > Tangentially, I think there's a regression with "private": > > () { > zmodload zsh/param/private > private foo=3Dlocal > typeset -p foo > } > > That now prints nothing, whereas in e.g. 5.7 it would say > typeset foo=3Dlocal > which isn't precisely accurate either. Traced this to here: >> commit f99f7dca7552d21782354f675c0741896c9785f1 >> Author: Peter Stephenson >> Date: Mon Oct 8 10:10:42 2018 +0100 >> >> 43616: Various parameter setting and display fixes. Specifically to this (pardon any excessive gmail line wrapping): - if (printflags & PRINT_TYPESET) { - if ((p->node.flags & (PM_READONLY|PM_SPECIAL)) =3D=3D - (PM_READONLY|PM_SPECIAL) || - (p->node.flags & PM_AUTOLOAD)) { + if (printflags & (PRINT_TYPESET|PRINT_POSIX_READONLY|PRINT_POSIX_EXPOR= T)) { + if (p->node.flags & (PM_RO_BY_DESIGN|PM_AUTOLOAD)) { /* * It's not possible to restore the state of * these, so don't output. */ return; } Leaving out PM_RO_BY_DESIGN restores the old behavior. I understand the motivation here (the comment), and if we were printing all values ("typeset -p" with no other arguments) it would make more sense, but in the context of explicitly asking for "typeset -p foo" it surely ought to print ... something?