zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: "Lawrence Velázquez" <larryv@zsh.org>
Cc: Daniel Shahaf <d.s@daniel.shahaf.name>,
	Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: Patch bumping (was Re: Feature Patch: Use completion to view parameter values)
Date: Tue, 13 Apr 2021 14:50:17 -0700	[thread overview]
Message-ID: <CAH+w=7YCcxhAZGiY-pdn-P_uXS9ndSwLyF7wixXdzmrGy2_LFQ@mail.gmail.com> (raw)
In-Reply-To: <2EE1CCA0-E8C3-4A9F-898B-F823890EA58C@zsh.org>

On Tue, Apr 13, 2021 at 2:32 PM Lawrence Velázquez <larryv@zsh.org> wrote:
>
> This effectively retains my current policy for types A and B.  I'd
> be fine with this, but we haven't heard Bart's rationale for longer
> intervals.

Mostly that in cases where there's been feedback to which the patch
submitter has not responded, pinging them is more likely than anything
to elicit either no response or a "sorry, ran out of time to work on
this", and in either case pinging again the same number of days later
is probably more annoying than helpful.  Patches that have been
entirely ignored or that are waiting on someone to push, are a
different matter.

> Should I continue bumping developer-only patch discussions at all?
> If so, I'm inclined to let them simmer for longer -- perhaps a month
> (as per workers/48516).  I feel pretty pesky basically reminding
> committers to commit their own patches, but everyone forgets things
> now and then.  Is it helpful or annoying?

In my case, once is helpful, twice in 10 days would be annoying.  But
I don't know how other committers allocate their time (and it's
currently more difficult for me to commit other people's patches than
it ought to be, and I can't say when I'll get that rectified).


  reply	other threads:[~2021-04-13 21:50 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-28 20:53 Feature Patch: Use completion to view parameter values Marlon Richert
2021-03-29  7:39 ` Daniel Shahaf
2021-03-29 11:55   ` Marlon Richert
2021-03-29 17:11     ` Daniel Shahaf
2021-03-29 17:20       ` Bart Schaefer
2021-03-29 18:14         ` Daniel Shahaf
2021-03-29 20:00           ` Marlon Richert
2021-03-29 20:05             ` Daniel Shahaf
2021-03-29 20:35               ` Marlon Richert
2021-04-01  4:28                 ` Marlon Richert
2021-04-01 18:40                   ` Daniel Shahaf
2021-04-02  0:50                 ` Oliver Kiddle
2021-04-10 20:20                   ` Lawrence Velázquez
2021-04-11 20:06                     ` Marlon Richert
2021-04-11 21:24                     ` Patch bumping (was Re: Feature Patch: Use completion to view parameter values) Bart Schaefer
2021-04-12  8:18                       ` Marlon
2021-04-13 12:32                         ` Daniel Shahaf
2021-04-13 18:08                           ` Lawrence Velázquez
2021-04-15  9:39                             ` [META] Tone of voice / Writing style in patch reviews (was Re: Patch bumping) Marlon
2021-04-15 10:33                               ` zeurkous
2021-04-13 13:35                         ` Patch bumping (was Re: Feature Patch: Use completion to view parameter values) Daniel Shahaf
2021-04-13 21:31                           ` Lawrence Velázquez
2021-04-13 21:50                             ` Bart Schaefer [this message]
2021-04-14 12:52                             ` Daniel Shahaf
2021-04-13  2:47                       ` Lawrence Velázquez
2021-04-12 20:22                   ` Feature Patch: Use completion to view parameter values Marlon
2021-04-12 21:49                     ` Bart Schaefer
2021-04-13  4:50                       ` Marlon Richert
2021-03-30  5:41           ` Mikael Magnusson
2021-03-31 22:55             ` Daniel Shahaf
2021-03-31 23:03               ` Daniel Shahaf
2021-03-29 20:10         ` Peter Stephenson
2021-03-29 11:48 ` Mikael Magnusson
2021-03-29 12:06   ` Marlon Richert
2021-03-29 12:07     ` Marlon Richert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH+w=7YCcxhAZGiY-pdn-P_uXS9ndSwLyF7wixXdzmrGy2_LFQ@mail.gmail.com' \
    --to=schaefer@brasslantern.com \
    --cc=d.s@daniel.shahaf.name \
    --cc=larryv@zsh.org \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).