From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 23768 invoked from network); 16 May 2021 15:46:27 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 16 May 2021 15:46:27 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1621179987; b=0or32Jp1/Fi+1pgDQOiZ813dDcsIJoHk3Vn+LwvI8dQBNPky+7/Oenl5oZ3/o0Qr01p5kMU60m DVER2Xu8VkGb9+G13zTMgawYQjuqgMNmNePBmGqD1ucHxFHiyaOL7cbY6bQof4rNwm2nxkXvy0 0ILgRFuj6m09OK09cuv9quZjuH4iLyv4vJ2u52oDNgB32ljgKfdOmwVlP03zgNJsKv/L5w5xIH fbPAvtrRYS9IyOsizDxUNa/tlzi+1OXx/HMacUClqkdoU2814910qlyBtMCHgIXgRc+ct/xMk2 Hij/KQFFn593r2bJlfDIH/v2r3TTAniYdhNG8rcOFpmrHA==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-ot1-f48.google.com) smtp.remote-ip=209.85.210.48; dkim=pass header.d=brasslantern-com.20150623.gappssmtp.com header.s=20150623 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1621179987; bh=0solvM1dJVnwJ+w+h+7A26M0JfM/nXZJ5izzWYb4EXo=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=lAcGtBTP4NW4Zt69TzmmudUOd2KpcqwJ/RpU4xOJ5eqITjpZDhCdcHao8iRmKqanVuqpOZn2ZV eUs017Bvzan1xl3TKE2NMZ4dgfUu2A9fjfnyWavvcffdyv1Yca8Lu0fpj5Yjw2jkK4XEPdsQDv D/rOWREUwtzhaIyPShSHWUGMmvUdOlOEf3VQ8JmDCuGJ2ykhSCSvgv6psy40wBGPpZYsRwYdHI yS/Z6gMfAz18ds04+tFoPNIxwqo5zTWP55cDIFeQU/rIKCubel02TT0RJs958/jUvlIwJVw0Gj +Hmzd+9QvTpz3rZwPD2bzrPdTZ9inEFaq91YapT8tVUj8A==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=SBMsU4JL9usN2pVaLVDlRXT8nb7xDZlAiTu5mI5cSCM=; b=pplg3srP2PwsOM5eWMpO2OCzoC MRfwjtj96h3Xr12J3paFv5FdiE2KPMftpDYI9YZTGyzfHUlMKWXpr6ZRVVAPqTk+cyeCJe8e5yGPC j+y1YIYgXvmBgVXZ6LpqkkIyu2aGqN7L9CAeyFu2wGnZWHs1CZAu/ThK4b78aFH/JFrCfANb6k4tK iPo9/RnQrpOGq02tZY6JZYwNEj2QOyeZzxciGA1Wvtkn4PPgQQVpHIxfhfVdzITWv4Y07qdLCuHPQ lCwcmcycUfrlVLAWYjnktr/wFA5RrxitwWM54dIT0UN+TP45D4o7l2ndOyqjBzGwY1VOAId5vAVHQ 5KvwoD5w==; Received: from authenticated user by zero.zsh.org with local id 1liIyI-000NcA-Gi; Sun, 16 May 2021 15:46:26 +0000 Authentication-Results: zsh.org; iprev=pass (mail-ot1-f48.google.com) smtp.remote-ip=209.85.210.48; dkim=pass header.d=brasslantern-com.20150623.gappssmtp.com header.s=20150623 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-ot1-f48.google.com ([209.85.210.48]:35356) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1liIy4-000NKB-DB; Sun, 16 May 2021 15:46:13 +0000 Received: by mail-ot1-f48.google.com with SMTP id 69-20020a9d0a4b0000b02902ed42f141e1so3547325otg.2 for ; Sun, 16 May 2021 08:46:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SBMsU4JL9usN2pVaLVDlRXT8nb7xDZlAiTu5mI5cSCM=; b=maHKzfRe2NOlICgTtmk6BXHshP97n1ZCts3jCPnvHL5Kmea1MQuAG9vBm4LDBqZtaJ h+91TMkFH6vDgh/O3TrDLKws6rc8BBmEVWW0bgsG8JDn9y49eFF4tahCwOkLBWhtDy7B l2lC/tEhkhWWUms4WiCU6jAoq8xCmr58/WBj2kWyAWegnLnrXYeHc/hsv50hNQAlbYLj /LzPcucKJwwp+kKiaPy+Qt24TpYl2diZVD/L8adrBool4mrXprCnQxXagUnO6/Rq9ZJq Yu/OGRg/1HkdVjSk/IcRmm+oARHJ7+C3gAQAYrl/+SKzHU59bGE4fakVEMgkIliL1cvw +tFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SBMsU4JL9usN2pVaLVDlRXT8nb7xDZlAiTu5mI5cSCM=; b=GLGEDcXWUGJ6q5rJm3oBEgCw1W3egEUCIzvM2gpID22TQfl1myC8+mF5ODXGFbeZMk uX1Q2PE9XuYOeb+Sah2xovNdvkYPf/3P6o+79GCjm6sRgBczNnLthdwiPOkdp6HdD9LL M8DBJpnvDAxvDOiUZrKqPLW5OOlD5yT1dOo5PLhlrrshTSbz4DbJ9LSZUtUXOeI1W8t1 LyaG+VFTSFQseczcs9wydcGSrh/ege74UqnM7HQnzfGzEjKlH91tq3+M1Eb3J7rrlHc8 J1rcNeYGBbdGg3GleUnJihQJSfNkn1BrQN9HBeRrbnI2pgdabdgfeTmHzWaI+qV2Om7/ pdsw== X-Gm-Message-State: AOAM533bhuCS5eNLDc/VUu2dzorg4jvHE/cuZVv4Bt3Bd2xubZDVVmuk DzqOQh5mK8Tjo1KOhSCg/0AYRfYocyzWLxvJg3dCmg== X-Google-Smtp-Source: ABdhPJynAthQQq0fChzzB/f34I2kjqQW0KuzvFdh11IAI6kaY+OSY6K7PuCU677VwIAPUbSGT4ehS/oKXBTfqCk2fe0= X-Received: by 2002:a9d:170b:: with SMTP id i11mr41526293ota.161.1621179971056; Sun, 16 May 2021 08:46:11 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Bart Schaefer Date: Sun, 16 May 2021 08:46:00 -0700 Message-ID: Subject: Re: 'while do done' hangs interactive zsh To: Arseny Maslennikov Cc: Zsh hackers list Content-Type: multipart/mixed; boundary="0000000000004bbbdf05c27460cd" X-Seq: 48840 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: --0000000000004bbbdf05c27460cd Content-Type: text/plain; charset="UTF-8" On Sun, May 16, 2021 at 7:28 AM Bart Schaefer wrote: > > > Even more, if the user enters "while do; done" in an interactive zsh > > instance, the busy loop is not interruptible by ^C, ^\ or ^Z; the shell > > has to be killed via some external means. > > I can NOT reproduce this in the latest revision from git, but I can > reproduce it in zsh-5.8. Specifically, the shell is interruptible by ^C. I haven't attempted to bisect where this was introduced; there are no obvious deltas to signals.c, loop.c, or parse.c to explain it. It is impossible to interrupt the parser with SIGINT. zhandler is entered with signal queueing enabled; when signals are allowed again, zhandler is called again and we pass through this code: 675 if (list_pipe || chline || simple_pline) { 676 breaks = loops; 677 errflag |= ERRFLAG_INT; 678 inerrflush(); 679 check_cursh_sig(SIGINT); 680 } 681 lastval = 128 + SIGINT; Because we're still in the parser, none of (list_pipe || chline || simple_pline) is true, so we never set breaks or errflag, only lastval. I'm not immediately sure what to do about that; perhaps just move the errflag setting outside that test? The attached makes both "while do" and "do done" into parse errors; I didn't want to try messing with the tokenizer, so better solutions are welcome. I mention tokenizing because in "for do" the string "do" is not a token; "while do;" could conceivably mean to execute the command "do" as the test condition. --0000000000004bbbdf05c27460cd Content-Type: text/plain; charset="US-ASCII"; name="while-do-done.txt" Content-Disposition: attachment; filename="while-do-done.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_korchcpk0 ZGlmZiAtLWdpdCBhL1NyYy9wYXJzZS5jIGIvU3JjL3BhcnNlLmMKaW5kZXggYjA5Yzc5ODlhLi4x NTM2MzNiYjEgMTAwNjQ0Ci0tLSBhL1NyYy9wYXJzZS5jCisrKyBiL1NyYy9wYXJzZS5jCkBAIC0x NTI1LDEwICsxNTI1LDE2IEBAIHBhcl93aGlsZShpbnQgKmNtcGx4KQogICAgIGluY21kcG9zID0g MTsKICAgICB3aGlsZSAodG9rID09IFNFUEVSKQogCXpzaGxleCgpOwotICAgIGlmICh0b2sgPT0g RE9MT09QKSB7CisgICAgLyoKKyAgICAgKiBJZiB0aGUgdmVyeSBmaXJzdCB0aGluZyBhZnRlciAi d2hpbGUiIGlzICJkbyIsCisgICAgICogZWN1c2VkIGhhcyBhZHZhbmNlZCBvbmx5IHR3byBwb3Np dGlvbnMuICBUaGlzCisgICAgICogaXMgbm90IGEgdmFsaWQgd2hpbGUtZG8gY29uc3RydWN0aW9u LgorICAgICAqLworICAgIGlmICh0b2sgPT0gRE9MT09QICYmIChlY3VzZWQgLSBvZWN1c2VkKSA+ IDIpIHsKIAl6c2hsZXgoKTsKIAlwYXJfc2F2ZV9saXN0KGNtcGx4KTsKLQlpZiAodG9rICE9IERP TkUpCisJLyogQXMgYWJvdmUgYnV0ICJkbyBkb25lIiBpcyBub3QgdmFsaWQgKi8KKwlpZiAodG9r ICE9IERPTkUgfHwgKGVjdXNlZCAtIG9lY3VzZWQpIDwgOCkKIAkgICAgWVlFUlJPUlYob2VjdXNl ZCk7CiAJaW5jbWRwb3MgPSAwOwogCXpzaGxleCgpOwo= --0000000000004bbbdf05c27460cd--