From: Bart Schaefer <schaefer@brasslantern.com>
To: Frederick Eaton <frederik@ofb.net>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [BUG] insert-last-word gets stuck at comments
Date: Tue, 27 Jul 2021 13:19:57 -0700 [thread overview]
Message-ID: <CAH+w=7YH6ycWWpKKgznByWc0oK9nVS+7rOFmPSgzeZiKzVpG9w@mail.gmail.com> (raw)
In-Reply-To: <20210727055227.4aobyf75yyckctve@localhost>
On Mon, Jul 26, 2021 at 10:52 PM Frederick Eaton <frederik@ofb.net> wrote:
>
> I've read the documentation for insert-last-word and
> smart-insert-last-word and I can't figure out how they are different.
>
> So they are the same when interactive_comments is not set? However,
> according to my experiments it seems that insert-last-word also
> ignores comments when interactive_comments is set, so I am not able to
> understand the difference.
I think what's happened is that a (now very old) change to the way the
history mechanism stores/fetches words, had an unexpected side-effect
on insert-last-word.
Where we've ended up is that insert-last-word can never "see"
comments, but smart-insert-last-word is able to see them if the
setting of interactive_comments changes from on to off between the
time the comment got entered into the history and the time
smart-insert-last-word is run. Which of course almost never occurs.
There's code in the insertlastword function that's (according to the
comment) supposed to stop us getting stuck, but apparently in the case
where the line is entirely empty that isn't working. It may be
possible to fix it.
next prev parent reply other threads:[~2021-07-27 20:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 7:06 Frederick Eaton
2021-07-26 22:50 ` Bart Schaefer
2021-07-27 5:52 ` Frederick Eaton
2021-07-27 20:19 ` Bart Schaefer [this message]
2021-07-28 1:36 ` Bart Schaefer
2021-07-28 9:06 ` Peter Stephenson
2021-07-28 15:40 ` Bart Schaefer
2021-07-29 8:14 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7YH6ycWWpKKgznByWc0oK9nVS+7rOFmPSgzeZiKzVpG9w@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=frederik@ofb.net \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).