help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: John Heatherington <jheatherington@gmail.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: Regression affecting completion with NO_CASE_GLOB
Date: Thu, 2 Jun 2022 19:34:26 -0700	[thread overview]
Message-ID: <CAH+w=7YSbV09ZsdK9J9aT4jPgqS8u4Lq=AxQ=94D63k3U+ha5g@mail.gmail.com> (raw)
In-Reply-To: <CA+h-xEA7UCtgLxtk=ysOhVr3JD8J9w9jgcu2FEFjBeMV2vD3HA@mail.gmail.com>

On Thu, Jun 2, 2022 at 5:28 PM John Heatherington
<jheatherington@gmail.com> wrote:
> After bisecting, I found a regression originating in the commit:
> d82604843bf2b743e04666d4644dd109831252f7
> The change was originally introduced to correct cfp_matcher_range,
> which doesn't call bld_line, so it seems like this could be fixed by
> putting the burden of adjusting the index on bld_line instead.

Indeed, it makes sense that if the semantics of an argument to
pattern_match_equivalence() has changed, then all callers need to
adapt to that.

There are two ways to go here:  Revert the pattern_match_equivalence()
change and alter cfp_matcher_range() to add one to the index that it
passes, or change the other two callers to decrement their indices by
one.  I tested the latter and it works as expected, but I think the
former might be the more sensible approach.

  reply	other threads:[~2022-06-03  2:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-03  0:27 John Heatherington
2022-06-03  2:34 ` Bart Schaefer [this message]
2022-06-03  2:41   ` Bart Schaefer
2022-06-03  3:03     ` John Heatherington

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH+w=7YSbV09ZsdK9J9aT4jPgqS8u4Lq=AxQ=94D63k3U+ha5g@mail.gmail.com' \
    --to=schaefer@brasslantern.com \
    --cc=jheatherington@gmail.com \
    --cc=zsh-workers@zsh.org \
    --subject='Re: Regression affecting completion with NO_CASE_GLOB' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).