From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 12111 invoked from network); 3 Jun 2022 02:35:27 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 3 Jun 2022 02:35:27 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1654223727; b=Y6j2j39zziKWcrZ9UOlbYJQ9xtB0jcExdVSP0xptxV151ymnHlyAmzJtXHTIf+1+JpD/WA3bB5 aAN1RLAMO4t2RN7CHlL/QrVO8RUi9Rp/sim2oxZ0LaUo+7mX295geoXvfxp0F0b5mc7JFtAqED eR7aUrD+Vh662+i92IWxokOSlzAcWVMCcqZ7MABCc1aounCjF4/hQPDrmoVVy6Tj1FPGcrY1Xt pc8xTSs2XqS8sOiFJ7YdJwNDlvGtUb9S8qdSb223+LG3uGBLEH7FlzjBYqRgiAzQsB99NT/c3/ kKXX6lh3KDrWJHx9XW0V7xEdpwpeO48t0UQWjyfsAdYsLg==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-ed1-f53.google.com) smtp.remote-ip=209.85.208.53; dkim=pass header.d=brasslantern-com.20210112.gappssmtp.com header.s=20210112 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1654223727; bh=pqgtVDz2Q0YMgQaAW1inG1Ym7jvctcRqfhtkgD90owI=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=gsvkfpfe9QzYG5qJrJlmA4oSQdN6zALXNHldVrjIod9D8adiSBabg0aMgngao9fMyV4R3JdKb1 VwlQKfcSQTK8I0uhZtKftuv1Y7svjG3eBteyTKKhoUmudjxfjjwNuvCcZ6kNmIaAVqfymMBEzT LmvY+OzibAO3l3CMYDztTqqM1ogfvi9Rq0Q9KaWASgNe48lwbhgOnhMbNY3JTPGIZucBokaOQT broR6b4cpeZ2JM5RaKvd7AZd+4+005dygG4ALhiV1JYr65mZhmTTRHPWSH5EQA0Be4CZjRlBmJ glJdPcW0IsimDesl3nWcYLdgwnrjHySkHLBp157I8y8ZgQ==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=qRrjchZeiFMsWzFAdACCA63HY2A2iBkFn9q5Sw46+z0=; b=e6oGbeOGhts3uu0WNLoz/GIbFj MDQxiEhx/U6xW64OzP3BDjfvgYmXDC1s8OCwqv+csIOFTPyWwYwd8mCSeq9w0/vC/9+uMz6/lmtRw BE57lCPP6L4ATAO1YN0imvjV/B+Y2AvZgMm8xHAKOS7yjYUBc3e4QQgrW4rcRM/g5aGUuI4dQeJsj dHP/SjbO0oqWzpzEJc8b+Q9Ornuz9w1pYS0OAlyqNaxF9KmOI74aJ3BLUZXDD4Ia1OGTcRbzSWHQ6 Z+buuDWbG6MvpnEK8g1wHsoHtInQ2aLrl8EZoNi/qcDY9IQXJzqHFsWMjOp4ApXCbMcQFE0xiCB6q Me9s7QOQ==; Received: from authenticated user by zero.zsh.org with local id 1nwx9q-000EV4-V8; Fri, 03 Jun 2022 02:35:26 +0000 Authentication-Results: zsh.org; iprev=pass (mail-ed1-f53.google.com) smtp.remote-ip=209.85.208.53; dkim=pass header.d=brasslantern-com.20210112.gappssmtp.com header.s=20210112 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-ed1-f53.google.com ([209.85.208.53]:36624) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1nwx9X-000E9J-OW; Fri, 03 Jun 2022 02:35:08 +0000 Received: by mail-ed1-f53.google.com with SMTP id fd25so8481367edb.3 for ; Thu, 02 Jun 2022 19:35:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qRrjchZeiFMsWzFAdACCA63HY2A2iBkFn9q5Sw46+z0=; b=YM90UHRpsHw4eOZE7W+LC/7yx3Rm86Zy+M3S8Eh/AMUAoOysbBi3G9k54VEzxxtr4Z FiQF1ccc0fClRcSUDDX53h8NBsofPu9QONMuKgslVCdBfCipdIqbmkM1JGOtTmln79Jh mmzhbappBX9v/GTHkY4jCXZx4g+ZPwn9L/DxgW2xUqx8JfDRQtaT8cjWAhSBbqTjfD2S 6z0heo30jmVt5Z+1P+gR6e8rla7A+y1BMgEyONnckr1ABeJq5vaG9NvBB9lt/FC9VNzH jeJrY5M3EAPEjGPXM8Kbr6AxZF+JcdHZMaAduqMgS1OtPrK78HvVjRUlu19QEEDL0zkp nQ5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qRrjchZeiFMsWzFAdACCA63HY2A2iBkFn9q5Sw46+z0=; b=341NvGq5gh7tiCarCv3eEGa5wl5bomM5yPUndm3XIwYbnesE+sz1CddxnzdClVjO2X QIX5BQwykaiGurIbtnui6K5r6gq/MB6H577NbxSNvoflr7FMHzjOUU6baTJ+EWnzjn9Z HzOamj8qjwUuaLvm80Pk2gmWWAUHCitPVyjnyG86vgOC3ATW/ZlY1nk1d+tnVt6EHMuO ZsByXTJ7QqdsQ7S0OBXecurMyg6iH4loaqKiErdAgYD5tumj/PHVky8JK8a5Nw3E5gjp g9BX58RhIKJ5ewI240M3FWn5Gi3bqenmfCtCaP6N/lqJRDZtsTbW1nKhg/rN+XP7Yupl +hBQ== X-Gm-Message-State: AOAM531ez2B4XV/w3N7h8MRl2bgNXGe/m33jYPMB9w6q70y4x2YWVggG v5qi7pGEzjK8XSMA7mq9RrjBoKF5wpdi3VEZ4/Hpqw== X-Google-Smtp-Source: ABdhPJw8PFn8d/H1X/XPijc5MU0hI2ozqass95DOPZzoxe5tNpODOnijjf4wQIXNelPW3DoiuoLid5QpDcdp5jCNxVE= X-Received: by 2002:a05:6402:510a:b0:42b:66c3:d4fd with SMTP id m10-20020a056402510a00b0042b66c3d4fdmr8526601edd.260.1654223707422; Thu, 02 Jun 2022 19:35:07 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Bart Schaefer Date: Thu, 2 Jun 2022 19:34:26 -0700 Message-ID: Subject: Re: Regression affecting completion with NO_CASE_GLOB To: John Heatherington Cc: Zsh hackers list Content-Type: text/plain; charset="UTF-8" X-Seq: 50324 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: On Thu, Jun 2, 2022 at 5:28 PM John Heatherington wrote: > > After bisecting, I found a regression originating in the commit: > d82604843bf2b743e04666d4644dd109831252f7 > [...] > > The change was originally introduced to correct cfp_matcher_range, > which doesn't call bld_line, so it seems like this could be fixed by > putting the burden of adjusting the index on bld_line instead. Indeed, it makes sense that if the semantics of an argument to pattern_match_equivalence() has changed, then all callers need to adapt to that. There are two ways to go here: Revert the pattern_match_equivalence() change and alter cfp_matcher_range() to add one to the index that it passes, or change the other two callers to decrement their indices by one. I tested the latter and it works as expected, but I think the former might be the more sensible approach.