zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: "Jun. T" <takimoto-j@kba.biglobe.ne.jp>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: zargs with -P intermittently failing in zsh 5.9 and macOS
Date: Sat, 28 May 2022 20:30:59 -0700	[thread overview]
Message-ID: <CAH+w=7YSv=XsM-aFX7D9UYAs_Og9ep07k8kj3kAc883RKTMwqQ@mail.gmail.com> (raw)
In-Reply-To: <957FB7CE-B2AE-4C22-9CC5-0883B2FAB62D@kba.biglobe.ne.jp>

On Fri, May 27, 2022 at 10:26 AM Jun. T <takimoto-j@kba.biglobe.ne.jp> wrote:
>
> I was thinking B is enough, because:
> WIFEXITED: has exited spontaneously
> WIFSIGNALED: has been killed by a signal
> WIFSTOPPED: still alive but now stoeepd
> WIFCONTINUED: has been stopped but now continued
> So these 4 are mutually exclusive.

OK.  However, reading through your patch again ... the changed code
kept track of stopped jobs.  Has that never been necessary?  Perhaps
the right thing to do is to continue recording the state on WIFSTOPPED
but to change to clearing the saved status on WIFCONTINUED?

> Or we can use both B and C, and add a DPUTS() if addbgstatus() is
> called more than once for a single pid.

That would be the "defensive programming" approach.


  reply	other threads:[~2022-05-29  3:31 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-24 16:09 Eric Nielsen
2022-05-24 17:32 ` Bart Schaefer
2022-05-24 20:21   ` Eric Nielsen
2022-05-24 20:35     ` Bart Schaefer
2022-05-26  8:57   ` Jun T
2022-05-26 11:21     ` Jun. T
2022-05-27  3:39     ` Bart Schaefer
2022-05-27  4:18       ` Lawrence Velázquez
2022-05-27  5:29       ` Jun T
2022-05-27 16:10         ` Bart Schaefer
2022-05-27 17:25           ` Jun. T
2022-05-29  3:30             ` Bart Schaefer [this message]
2022-05-29 14:47               ` Jun. T
2022-05-29 20:07                 ` Bart Schaefer
2022-05-30 11:16                   ` Jun T
2022-06-07  6:51                     ` Jun T
2022-06-09  2:56                       ` Bart Schaefer
2022-06-12 16:43                 ` Eric Nielsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH+w=7YSv=XsM-aFX7D9UYAs_Og9ep07k8kj3kAc883RKTMwqQ@mail.gmail.com' \
    --to=schaefer@brasslantern.com \
    --cc=takimoto-j@kba.biglobe.ne.jp \
    --cc=zsh-workers@zsh.org \
    --subject='Re: zargs with -P intermittently failing in zsh 5.9 and macOS' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).