From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 5402 invoked from network); 29 Nov 2023 19:18:40 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 29 Nov 2023 19:18:40 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1701285520; b=aqM5c9DJZmYfRTQTFnhxZEFswvRQqCpJeXBsi207/zaRBN9idHEkFvjhvo1+LR6579ZXiM+L8f Ome3TeR6p2CgCa4O4n9+W0j5aPzi5LEn1N+p0uggiqCi3n0Qmt8fcYvkqVoOGKlNq4fhxSGUnL 2CHpGTlVN5rjOCosXxYpWlgRDuKmXYnLZoIHrcytLOqBvBlHcnWnYZM7TmOTjm3B7qq8dxjYGL ETvy4duuR8DdTl+Hak7J3o6ExZjifHh46F+fmF02qGmJlTNPZRfNWTtJ7Ltg4QUw9Yk6/EWgOP IrKP/1pmFqBYjHEnX6eIx2qaTwrPrSGkE+IEIeqtJHdTQg==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-ed1-f51.google.com) smtp.remote-ip=209.85.208.51; dkim=pass header.d=brasslantern-com.20230601.gappssmtp.com header.s=20230601 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1701285520; bh=8KQozDGt8c6CRedepp8bfzZfqlR5OtE1691oL2T/dEs=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:Cc:To:Subject: Message-ID:Date:From:In-Reply-To:References:MIME-Version:DKIM-Signature: DKIM-Signature; b=keLRPZUv2UcivPJ3kj4hWRyFe8sryrL2PY9t6NtcBcqBGxQkJOsect9IoQfcd69SMWUE42SRkx QpiKTBw7YCu4E2+o38Mfwy9Yg3cD4XJuWa4j331sAU3Jcgh78vS6N+eO2VNViYHfjftLWeSnP8 xrqdJrQelbs+/gaTLrR71RaV7/qRb8PAbQqifYX2Kaz/b7DEoWz5iiNMJFH1rEryoQdpfIJwym wigoCvKyQ0O6fenwDUKxxjBe/MBPmNW7wbFszqvL5QjsjeuOusORkehhmq/7C7TKl9Un8rxCRa J0wF9MNHfVb/7i/56zQy5ugzjpKWv/dZq/X0GvSJtsHIig==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=KHznyTbOxnn2a9DmhDQVfglOF4rpn8k/XrwMg7qkVi4=; b=DFzBib6LcxH3dfOK4wgQY0z2pc n9XE/Enjqs3zjQ9oA+1tk3JJf1FTE00LVcThVMvWWZ9Kzs/DY5ISlmfi0ioRCKdraNw3VXT9NilMk EoKeb7RLpamh4QdCQgrN6ICbk1aEkgBzLtS6eWy58o7lgkmtBgs0vfhKjAy6gF8WyB/rU2tRyar4t mgY1+/EZpzHsPvYJVPh23Skx42YY6sRVXe3QC3/QGRPwvFO5NM9ccynoUS/lfqr5Xmwjn0ysRhK5w 8NKSIvvswikCkfk9m5oBQCNZzbEnmbFIfWM8uZtllk5tpEvJWxnSzvGOC20G6Czz+Xgnp7buf9R4b qc+OX7YA==; Received: by zero.zsh.org with local id 1r8Q52-000CmD-1o; Wed, 29 Nov 2023 19:18:40 +0000 Authentication-Results: zsh.org; iprev=pass (mail-ed1-f51.google.com) smtp.remote-ip=209.85.208.51; dkim=pass header.d=brasslantern-com.20230601.gappssmtp.com header.s=20230601 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-ed1-f51.google.com ([209.85.208.51]:61778) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1r8Q4i-000CTO-Lm; Wed, 29 Nov 2023 19:18:21 +0000 Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-54bb9024378so190739a12.3 for ; Wed, 29 Nov 2023 11:18:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20230601.gappssmtp.com; s=20230601; t=1701285500; x=1701890300; darn=zsh.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=KHznyTbOxnn2a9DmhDQVfglOF4rpn8k/XrwMg7qkVi4=; b=q1naRLvzo4sRoFkVD6M4TkpUn1aBmnNjAdQAVJPGm7vgbJzYWqCEHwsbX1APHe4I/i HMc+VXy2an7hUauJG7U6rn0wDpTzdffpmHp4ygIj7iiEgkmqH0tTQNStslmh2PyMaIRc 26HFprTr7p+ok9TeC7SijoDGkzjlGIcjn1RpowsdEpkeUJsg2qR1hINbWmGWfKGVbMKp jowc12RXQT2+PuLKypdZl7xYaaf/aDa/+Kf+ZkDXUCbG1D6RPTUydPQqfBhrgzqQETOT Te5gD6418Za0mFIToqugyleRYNGhG1nUdkd2QgXovMdNqPkhrp6ecFkpS8Lr8caQSYlv APxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701285500; x=1701890300; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KHznyTbOxnn2a9DmhDQVfglOF4rpn8k/XrwMg7qkVi4=; b=FOyP0kKzvzsdlBl0O21fmgOI+oRKp9U4RR/l/JexaZKV1yire1s3a02gki7itrHvBq Mk3twTdfe6sZNfF/JUz5gCSaksyPKAd22LX+leaZAsR2uh7/YcAhsz79o89mBOESDlaW 0NsovV5EqujaPOhUDgR9iHv7SH+NYv8nvBO5NSaFBxICM8mus8rKG788dy+Pg7wiE8K/ vm+TnyEwWSv93vTJq6ILYC+CixBA8cm6qc0yLOcFXhdlmvtstqBWADbLrdQWmNNeaAyT dyNJrVvKzABoJJ4jX1IQrFdNfr4GRkkuo0+IPibC/R3LTYYk17nvNxbDy2CskdIv830o Szrw== X-Gm-Message-State: AOJu0YwGbCcBHTmywKzZJLFL6DKOMdX8SB2pd2MGPPFFeIWp80ZCmnYh fxQ1YIUctitWLzfeK0jlxUXyGAtYzLqWRNTX8VIFAg== X-Google-Smtp-Source: AGHT+IHlrtxJ+hKGKPTuhhDkD/N8lWofszU+kJ3U5E3zBoh9Px5NI4L05ZfrcygMkeCt9I8pdgqFtzGr7OOvVqQg3lE= X-Received: by 2002:a17:906:41:b0:a09:589f:94b4 with SMTP id 1-20020a170906004100b00a09589f94b4mr12381992ejg.63.1701285499994; Wed, 29 Nov 2023 11:18:19 -0800 (PST) MIME-Version: 1.0 References: <207461559.9336309.1701221332233.ref@mail.yahoo.com> <207461559.9336309.1701221332233@mail.yahoo.com> In-Reply-To: <207461559.9336309.1701221332233@mail.yahoo.com> From: Bart Schaefer Date: Wed, 29 Nov 2023 11:18:08 -0800 Message-ID: Subject: Re: PATCH: Improve quote handling in _ant completion To: German Riano Cc: "zsh-workers@zsh.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Seq: 52335 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: On Tue, Nov 28, 2023 at 5:30=E2=80=AFPM German Riano wro= te: > > In the current completion, if a task description contains a quote (') the= completions do not render properly > > In this patch I propose to build the tmp array via > tmp=3D( ${(f@)"$(command)"} ) > and print one line at a time. Does this smaller change work instead? (I suspect the "eval" could be eliminated by tweaking this further.) diff --git a/Completion/Unix/Command/_ant b/Completion/Unix/Command/_ant index 36c7c0e89..aea3f51ec 100644 --- a/Completion/Unix/Command/_ant +++ b/Completion/Unix/Command/_ant @@ -122,7 +122,7 @@ case $state in read default_target junk fi # Output target again indicating its the default one. - print -n "'${default_target}:(Default target) ' " + print -rn -- "${(qq):-${default_target}:(Default target) } " ;; (Searching:*|Main:targets:|Subtargets:|BUILD:SUCCESSFUL|Total:time:*) ;; > Also I am proposing to shield 'find_targets' with '(( $#functions[find_ta= rgets] )) ||' so that users can easily override the function. No particular objection to this, though I wonder if it should be tied to the "targets" style and _call_program (Oliver?)