From: Bart Schaefer <schaefer@brasslantern.com>
To: Philippe Altherr <philippe.altherr@gmail.com>
Cc: zsh-workers@zsh.org
Subject: Re: errexit and (Z)ERR trap regression
Date: Wed, 26 Jun 2024 14:43:32 -0700 [thread overview]
Message-ID: <CAH+w=7YWCGtkbZZY2f4gWdZ624hz+4xBhFfZbaoyZGhETu-3WA@mail.gmail.com> (raw)
In-Reply-To: <CAGdYchvP9x83UtFH855_ddE1m88cMJdNmk27+RwzHC9KSJ=ucA@mail.gmail.com>
On Wed, Jun 26, 2024 at 5:43 AM Philippe Altherr
<philippe.altherr@gmail.com> wrote:
>
> I think that the correct fix is the following:
>
> if (isandor || isnot)
> noerrexit = oldnoerrexit | NOERREXIT_EXIT | NOERREXIT_RETURN;
> else
> noerrexit = oldnoerrexit;
This doesn't seem necessary to me. For one thing, it's equivalent to:
noerrexit = oldnoerrexit;
if (isandor || isnot)
noerrexit |= NOERREXIT_EXIT | NOERREXIT_RETURN;
But assigning (noerrexit = oldnoerrexit) presumes that noerrexit was
(improperly?) cleared at or after the point where olderrexit was
recorded. If that were the situation, then --
> For reminder, here is the current code:
>
> if (isandor || isnot)
> noerrexit |= NOERREXIT_EXIT | NOERREXIT_RETURN;
-- would be insufficient for the existing test cases, I think. That
is, either (olderrexit == noerrexit), or it's not necessary to
OR-together olderrexit with the new values.
> Here are two other examples fixed by this patch:
>
> zsh -c 'trap "echo Trapped!" ERR; true && if true; then false; fi'
> zsh -c 'trap "echo Trapped!" ERR; true && {false} always {true}'
These two cases also pass with my patch from workers/52973. Do you
have an example where my patch doesn't work?
next prev parent reply other threads:[~2024-06-26 21:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 17:12 Martijn Dekker
2024-06-21 18:46 ` Bart Schaefer
2024-06-21 20:02 ` Lawrence Velázquez
2024-06-21 20:36 ` Bart Schaefer
2024-06-22 5:49 ` Lawrence Velázquez
2024-06-24 23:02 ` Bart Schaefer
2024-06-26 12:42 ` Philippe Altherr
2024-06-26 21:43 ` Bart Schaefer [this message]
2024-06-27 2:01 ` Philippe Altherr
2024-06-27 16:43 ` Bart Schaefer
2024-06-27 17:09 ` Philippe Altherr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7YWCGtkbZZY2f4gWdZ624hz+4xBhFfZbaoyZGhETu-3WA@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=philippe.altherr@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).