From: Bart Schaefer <schaefer@brasslantern.com>
To: Mikael Magnusson <mikachu@gmail.com>,
Michele Venturi <dardo82@gmail.com>
Cc: zsh-workers@zsh.org
Subject: Re: How to fix run-help-* functions?
Date: Mon, 13 Mar 2023 13:41:04 -0700 [thread overview]
Message-ID: <CAH+w=7YWy4CZoFuY5a1kPkjWMo+T5pVG--GsZUyQfA5q3b05aw@mail.gmail.com> (raw)
In-Reply-To: <CAH+w=7YL4_q5YHxC5GmuqaP1nNhUpmP7BKsxu==B-TpLB9zciA@mail.gmail.com>
On Mon, Mar 13, 2023 at 1:31 PM Bart Schaefer <schaefer@brasslantern.com> wrote:
>
> It does a push-line so that the run-help function can retrieve it with
> getln. See workers/49218
>
> If there's no line pushed, the run-help function is going to push a
> blank one (with print -z) immediately after getln fails, so there's
> several things that need to (not) happen if the widget is not used.
This seems to cover it:
diff --git a/Functions/Misc/run-help b/Functions/Misc/run-help
index d52c1b032..0bf84447a 100644
--- a/Functions/Misc/run-help
+++ b/Functions/Misc/run-help
@@ -98,9 +98,9 @@ do
if whence "run-help-$1:t" >/dev/null
then
local cmd_args
- builtin getln cmd_args
+ builtin getln cmd_args &&
builtin print -z "$cmd_args"
- cmd_args=( ${(z)cmd_args} )
+ cmd_args=( ${(z)${cmd_args:-"$*"}} )
# Discard the command itself & everything before it.
shift $cmd_args[(i)${run_help_orig_cmd:-$1}] cmd_args ||
next prev parent reply other threads:[~2023-03-13 20:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 14:30 Michele Venturi
2023-03-07 17:13 ` Philippe Troin
2023-03-13 11:09 ` Michele Venturi
2023-03-07 17:22 ` Bart Schaefer
2023-03-07 17:31 ` Peter Stephenson
2023-03-07 17:40 ` Bart Schaefer
2023-03-07 18:34 ` Michele Venturi
2023-03-08 0:03 ` Bart Schaefer
2023-03-13 11:14 ` Michele Venturi
2023-03-13 16:06 ` Bart Schaefer
2023-03-13 18:19 ` Mikael Magnusson
2023-03-13 20:31 ` Bart Schaefer
2023-03-13 20:41 ` Bart Schaefer [this message]
2023-03-20 14:37 ` Michele Venturi
2023-03-21 1:05 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7YWy4CZoFuY5a1kPkjWMo+T5pVG--GsZUyQfA5q3b05aw@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=dardo82@gmail.com \
--cc=mikachu@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).