From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 7517 invoked from network); 22 Jun 2023 17:50:47 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 22 Jun 2023 17:50:47 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1687456247; b=PjOpDz+Df6pyTSGJehFy9bMu5355nylggiQCxO2RpLK/ZDx8NRthXFKg/q47qSIiC7aoN2lqC4 d4kSRtAm6TZWjAjZ7sGYKr/wFsMK0fWgGQaRgAJfM3ZW5The0IZ9kIsX7LBpG5xJ30qpsoSp6T qEpXmLiZWTdI2UttKAXuP4T70fY0oii2dpOYTfEEdHJ5OgkB84UzjdSpRq0p47qrxG2fzqBfa0 YMoWtI9GMK2k2bgVQp83E/F3iJnuO8ciOvIo1oRA4Cj6N0FaljaxLOErV3f3ARbepwPdPv2QhT q2WtZ8EkVgjcgPmgj5pwraq7+jMmXJtV4toujBmzcwS2/w==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-ej1-f43.google.com) smtp.remote-ip=209.85.218.43; dkim=pass header.d=brasslantern-com.20221208.gappssmtp.com header.s=20221208 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1687456247; bh=Ehn7IqwVUzPxk88FjdVEFAmeLecQ6UA7yNWhFZB8sLM=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=RRu7KyC31CkWrbkbZckAtY5UPXKAionYi/xXo6JOTJa7cSxpF4tJ1rLMVH4ZDKDlmK+qFqcx8v a7xsvsr4CDt0lMc67q0AHZZgS2nmQg72vu2oVDHyOR2iShbEgsylyCqYHuIUdakLyoNcm4Bn2G blIsRD1qlEPz0/6qpdymMDrKLYjiHsl/YO6ViIewtgGyPaMYEF1udvBpeFLJjI6RroXfNj5qU/ nUNm2ve2Cdu/1ApfW+R7BY9h+t8qgUCxJ0Q7TpR7klrJtwaSEs8mmcgrxyqBKeSSCNem+q+CQF 05tfYrwhCpzd+mVjZSWCqBx4ZgNVm0cj7q34R3HMIIXZJQ==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:To:Subject:Message-ID: Date:From:In-Reply-To:References:MIME-Version:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=49z7Y6pGM87/lDJRpdclA/bti6lVTb9fQewLLphcuPQ=; b=XdPysnLrRYYl2MpDV0kmT3yd58 9vw8Xt1ObTdqYY6O2bNWZUqkiMGex8zSUZCE7mX1WwIGNm0Ia/wvGb6WNeiMOlDZCznSglIa9XI7U vcp3TTauotDLvWvwmLPj1R6kujaiQJr0Bo5fEQ10xf8k95/O83rdjVtTPddb0UKQdb+9QJGx7P2oH xPV2QuvtjBVzyNWbeGPWHdiOSmwBKHT5UxldGV2Czg2u4pkS4+W2Ojy+gldAYkTthqOZUPhmRVnia U7kVwDCHM7MnjX4/5v5o0+bzu9g3ZWWyRmKp5cXXbnJE4UPBf5qqxSiEi0j4705svLZk57M34HAJs fHlOOr2A==; Received: by zero.zsh.org with local id 1qCOSE-0003DA-MV; Thu, 22 Jun 2023 17:50:46 +0000 Authentication-Results: zsh.org; iprev=pass (mail-ej1-f43.google.com) smtp.remote-ip=209.85.218.43; dkim=pass header.d=brasslantern-com.20221208.gappssmtp.com header.s=20221208 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-ej1-f43.google.com ([209.85.218.43]:49456) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1qCORa-0002th-8m; Thu, 22 Jun 2023 17:50:10 +0000 Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-9889952ed18so734904166b.3 for ; Thu, 22 Jun 2023 10:50:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20221208.gappssmtp.com; s=20221208; t=1687456205; x=1690048205; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=49z7Y6pGM87/lDJRpdclA/bti6lVTb9fQewLLphcuPQ=; b=VdYLCTEH2CnUBjYu26cyrqV+yhUNrYhylrE997toZ5CrW/fEjKgdZqSFik/3gD+bDK RmaC1tkTiThH0n8kccbgJLFUvsZL4y9kjXBDNt2Tg/ME4RfgduUUMq9uOtYo1go+ROYd vZPuuGfflOcG2+CT36Ni0X1oq+vtjmwmWzqw/mDg/iwtOiVM7AV8yEdisLDE9lTVFGpJ B9JYPz1lisTppObraN2JgCtSp/Z0HXa9mhFKIkWCbU+3mxSoWCdgLnUfxvRL+rKAUzA7 L7BxhRJR7AzEMiOzo1718PykGyKov3psniTo4B1sZvqAWqKXfp4+/W/5BRE2AOW0UKuq Rh4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687456205; x=1690048205; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=49z7Y6pGM87/lDJRpdclA/bti6lVTb9fQewLLphcuPQ=; b=SMljgwNJQUGsHNZHiwUwrNa9bF51DUVyaTxLTozjM777DprOr/zIGM5nFou6+RA+ej JJ6HpEAQqRNXuasGI2ocsK/eEEXrLl4FV1M/g4vINBOjHNvDmzfuefojz9/AXtxFCuYN g946Sjw5jZ+ve5JY9CjqkCOhqHlQ7+NDG2R+zt3mp2QaH2qJ55jaPutn3R7qwZRfq3yJ neBkaY6Io1jbJk6LopuYTp2YDYRzM/eh4gTZfZ4JEooYm7aGiwBmOEJ8LtK2axzGRheo pVTwqk2OGTOJXtYzvXJsVyEndoYX8dTBXa4WqZHyGE4JN1REODY2mQvN7HSV0VaLxxUQ wKeg== X-Gm-Message-State: AC+VfDw8WVWnEJR0Cv6TdXSAO0kNnlcSEnXIoHPzeVYmB9iRMuqMEjEo /45qaLTRTJszvQ7FlkcWwL3q4f4OtHGbZDoiQq1fv+jRCAERAXNH9XI= X-Google-Smtp-Source: ACHHUZ4SPjpoqpvly1xMxXgocZT2kSudqb13axANbC0salL4CRqC2+8Dz69JPKxIYFw7NLwHZhfGeaXpXTrRaW0rBeA= X-Received: by 2002:a17:907:745:b0:978:928:3b99 with SMTP id xc5-20020a170907074500b0097809283b99mr15605812ejb.46.1687456204972; Thu, 22 Jun 2023 10:50:04 -0700 (PDT) MIME-Version: 1.0 References: <9849-1684455235.063540@_q24.9gsR.Efjj> <92928-1684946470.047218@Qy70.4SHd.nnDI> In-Reply-To: From: Bart Schaefer Date: Thu, 22 Jun 2023 10:49:54 -0700 Message-ID: Subject: [PATCH] Re: namespaces limitation To: Zsh workers Content-Type: multipart/mixed; boundary="000000000000ac1b2905febb8388" X-Seq: 51887 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: --000000000000ac1b2905febb8388 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, May 18, 2023 at 5:14=E2=80=AFPM Oliver Kiddle wrote: > > integer .var.d=3D0 > (( .var.d++ )) > zsh: bad floating point constant > > It'd be good if it could identify this as a namespace variable. This should be correctly handled after this patch, test is included. If you find other broken edge cases please point them out. On Thu, May 25, 2023 at 3:09=E2=80=AFPM Bart Schaefer wrote: > > On Wed, May 24, 2023 at 9:41=E2=80=AFAM Oliver Kiddle wrote= : > > > > integer .var=3D56 > > > > would be disallowed. > > I had it that way at one point and backed off because ksh allows it. Patch below leaves this unchanged (so still allowed) and adds a test for it= . > Strictly speaking (to the extent that any of this is strict), > namespaces are supposed to otherwise obey the rules for identifiers, > which with the exception of positional parameters are not allowed to > begin with a digit ... so I think I'll just go with that. > > I still haven't worked out how to deal correctly with .var.3x The below enforces that identifiers following a namespace prefix must either begin with a non-digit or must consist entirely of digits. For possible future enhancements, this does not apply when the identifier before the first "." does not itself begin with a ".", that is, ${var.3x} is allowed. I haven't determined how/where to document that latter special case. Perhaps it's not necessary to do so, given that omitting the first "." is explicitly discouraged. > > Also questionable is the following which currently works: > > > > .a.=3Dddd This is rejected by the patch (not an identifier / bad substitution). I think the extra checks add very little if any overhead to the unaffected cases but I haven't run benchmarks. > > We also currently allow a.=3Dddd but I think that is less > > questionable. We allow empty association elements. > > I'm still not entirely sold on the x.y <=3D> x[y] mapping idea, but if > we follow JavaScript's (somewhat questionable) lead on this, empty > elements have to use bracket-notation rather than dot-notation. I've not [yet] enforced the bracket-notation requirement, so as a special case of the ${var.3x} case above, ${var.} is also allowed. A point against following JS is that JS doesn't have the braces around the reference to delineate the empty element. --000000000000ac1b2905febb8388 Content-Type: text/plain; charset="US-ASCII"; name="namespace-limiting.txt" Content-Disposition: attachment; filename="namespace-limiting.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lj7frfhy0 ZGlmZiAtLWdpdCBhL1NyYy9tYXRoLmMgYi9TcmMvbWF0aC5jCmluZGV4IDEyYzhkNmY2Yi4uYTA2 MDE4MWVkIDEwMDY0NAotLS0gYS9TcmMvbWF0aC5jCisrKyBiL1NyYy9tYXRoLmMKQEAgLTY0MSw3 ICs2NDEsOSBAQCB6emxleCh2b2lkKQogCQlyZXR1cm4gTUlOVVNFUTsKIAkgICAgfQogCSAgICBp ZiAodW5hcnkpIHsKLQkJaWYgKGlkaWdpdCgqcHRyKSB8fCAqcHRyID09ICcuJykgeworCQlpZiAo aWRpZ2l0KCpwdHIpIHx8CisJCSAgICAoKnB0ciA9PSAnLicgJiYKKwkJICAgICAoaWRpZ2l0KHB0 clsxXSkgfHwgIWl0eXBlX2VuZChwdHIsIElOQU1FU1BDLCAwKSkpKSB7CiAJCSAgICBpbnQgY3R5 cGUgPSBsZXhjb25zdGFudCgpOwogCQkgICAgaWYgKGN0eXBlID09IE5VTSkKIAkJICAgIHsKQEAg LTgzNSw3ICs4MzcsOSBAQCB6emxleCh2b2lkKQogCWNhc2UgRG51bGw6CiAJICAgIGJyZWFrOwog CWRlZmF1bHQ6Ci0JICAgIGlmIChpZGlnaXQoKi0tcHRyKSB8fCAqcHRyID09ICcuJykKKwkgICAg aWYgKGlkaWdpdCgqLS1wdHIpIHx8CisJCSgqcHRyID09ICcuJyAmJgorCQkgKGlkaWdpdChwdHJb MV0pIHx8ICFpdHlwZV9lbmQocHRyLCBJTkFNRVNQQywgMCkpKSkKIAkJcmV0dXJuIGxleGNvbnN0 YW50KCk7CiAJICAgIGlmICgqcHRyID09ICcjJykgewogCQlpZiAoKisrcHRyID09ICdcXCcgfHwg KnB0ciA9PSAnIycpIHsKQEAgLTg1Nyw3ICs4NjEsNyBAQCB6emxleCh2b2lkKQogCQl9CiAJCWNj dCA9IDE7CiAJICAgIH0KLQkgICAgaWYgKChpZSA9IGl0eXBlX2VuZChwdHIsIElJREVOVCwgMCkp ICE9IHB0cikgeworCSAgICBpZiAoKGllID0gaXR5cGVfZW5kKHB0ciwgSU5BTUVTUEMsIDApKSAh PSBwdHIpIHsKIAkJaW50IGZ1bmMgPSAwOwogCQljaGFyICpwOwogCmRpZmYgLS1naXQgYS9TcmMv cGFyYW1zLmMgYi9TcmMvcGFyYW1zLmMKaW5kZXggMDIxZDM0MWU4Li4yYjA4MzdlMDMgMTAwNjQ0 Ci0tLSBhL1NyYy9wYXJhbXMuYworKysgYi9TcmMvcGFyYW1zLmMKQEAgLTEyMjYsNiArMTIyNiwy NiBAQCBpc2lkZW50KGNoYXIgKnMpCiAgICAgaWYgKCEqcykJCQkvKiBlbXB0eSBzdHJpbmcgaXMg ZGVmaW5pdGVseSBub3QgdmFsaWQgKi8KIAlyZXR1cm4gMDsKIAorICAgIC8qIFRoaXMgcGFydGx5 IGR1cGxpY2F0ZXMgY29kZSBpbiBpdHlwZV9lbmQoKSwgYnV0IHdlIG5lZWQgdG8KKyAgICAgKiBk aXN0aW5ndWlzaCB0aGUgbGVhZGluZyBuYW1lc3BhY2UgYXQgdGhpcyBwb2ludCB0byBjaGVjayB0 aGUKKyAgICAgKiBjb3JyZWN0bmVzcyBvZiB0aGUgaWRlbnRpZmllciB0aGF0IGZvbGxvd3MKKyAg ICAgKi8KKyAgICBpZiAoKnMgPT0gJy4nKSB7CisJaWYgKGlkaWdpdChzWzFdKSkKKwkgICAgcmV0 dXJuIDA7CS8qIE5hbWVzcGFjZSBtdXN0IG5vdCBzdGFydCB3aXRoIGEgZGlnaXQgKi8KKwkvKiBS ZWplY3QgaWRlbnRpZmllcnMgYmVnaW5uaW5nIHdpdGggYSBkaWdpdCBpbiBuYW1lc3BhY2VzLgor CSAqIE1vdmUgdGhpcyBvdXQgYmVsb3cgdGhpcyBibG9jayB0byBhbHNvIHJlamVjdCB2LjF4IGZv cm0uCisJICovCisJaWYgKChzcyA9IGl0eXBlX2VuZChzICsgKCpzID09ICcuJyksIElJREVOVCwg MCkpKSB7CisJICAgIGlmICgqc3MgPT0gJy4nKSB7CisJCWlmICghc3NbMV0pCisJCSAgICByZXR1 cm4gMDsKKwkJaWYgKGlkaWdpdChzc1sxXSkpCisJCSAgICBzID0gc3MgKyAxOworCSAgICB9CisJ fQorICAgIH0KKwogICAgIGlmIChpZGlnaXQoKnMpKSB7CiAJLyogSWYgdGhlIGZpcnN0IGNoYXJh Y3RlciBpcyBgcycgaXMgYSBkaWdpdCwgdGhlbiBhbGwgbXVzdCBiZSAqLwogCWZvciAoc3MgPSAr K3M7ICpzczsgc3MrKykKQEAgLTIxNDgsNyArMjE2OCwxMiBAQCBmZXRjaHZhbHVlKFZhbHVlIHYs IGNoYXIgKipwcHRyLCBpbnQgYnJhY2tzLCBpbnQgZmxhZ3MpCiAJICAgIHBtID0gKFBhcmFtKSBw YXJhbXRhYi0+Z2V0bm9kZTIocGFyYW10YWIsICp0ID09ICcwJyA/ICIwIiA6IHQpOwogCWVsc2UK IAkgICAgcG0gPSAoUGFyYW0pIHBhcmFtdGFiLT5nZXRub2RlKHBhcmFtdGFiLCAqdCA9PSAnMCcg PyAiMCIgOiB0KTsKLQlpZiAoc2F2KQorCWlmICghcG0gJiYgKnQgPT0gJy4nICYmICFpc2lkZW50 KHQpKSB7CisJICAgIC8qIGJhZGx5IGZvcm1lZCBuYW1lc3BhY2UgcmVmZXJlbmNlICovCisJICAg IGlmIChzYXYpCisJCSpzID0gc2F2OworCSAgICByZXR1cm4gTlVMTDsKKwl9IGVsc2UgaWYgKHNh dikKIAkgICAgKnMgPSBzYXY7CiAJKnBwdHIgPSBzOwogCWlmICghcG0gfHwgKChwbS0+bm9kZS5m bGFncyAmIFBNX1VOU0VUKSAmJgpkaWZmIC0tZ2l0IGEvVGVzdC9LMDJwYXJhbWV0ZXIuenRzdCBi L1Rlc3QvSzAycGFyYW1ldGVyLnp0c3QKaW5kZXggOGExYmUxZTM2Li4wYjFhOGRkNGEgMTAwNjQ0 Ci0tLSBhL1Rlc3QvSzAycGFyYW1ldGVyLnp0c3QKKysrIGIvVGVzdC9LMDJwYXJhbWV0ZXIuenRz dApAQCAtMTAwLDcgKzEwMCw1NSBAQCBGOkJyYWNlcyBhcmUgcmVxdWlyZWQKID4uazAyLmFycmF5 CiA+Y2hhcmFjdGVycwogCisgIGsuPWVtcHR5CiAgIGsuMj10ZXN0Ci0gIHByaW50ICR7ay4yfQor ICBwcmludCAke2sufSAke2suMn0KIDA6UGFyc2Ugd2l0aG91dCBsZWFkaW5nIGRvdCAoZnV0dXJl IHByb29maW5nKQotPnRlc3QKKz5lbXB0eSB0ZXN0CisKKyAgLms9T0sKKyAgcHJpbnQgJHsua30K KzA6QmFyZSBuYW1lc3BhY2UgaXMgdXNhYmxlIChrc2ggY29tcGF0aWJpbGl0eSkKKz5PSworCisg IC5rLj1lbXB0eQorMTpOYW1lc3BhY2UgbXVzdCBwcmVjZWRlIGFuIGlkZW50aWZpZXIsIGFzc2ln bm1lbnQKKz8oZXZhbCk6MTogbm90IGFuIGlkZW50aWZpZXI6IC5rLgorCisgIHR5cGVzZXQgLmsu PWVtcHR5CisxOk5hbWVzcGFjZSBtdXN0IHByZWNlZGUgYW4gaWRlbnRpZmllciwgdHlwZXNldAor PyhldmFsKTp0eXBlc2V0OjE6IG5vdCB2YWxpZCBpbiB0aGlzIGNvbnRleHQ6IC5rLgorCisgIHBy aW50ICR7LmsufQorMTpOYW1lc3BhY2UgbXVzdCBwcmVjZWRlIGFuIGlkZW50aWZpZXIsIHJlZmVy ZW5jZQorPyhldmFsKToxOiBiYWQgc3Vic3RpdHV0aW9uCisKKyAgLjIuYj1ub3QKKzE6TmFtZXNw YWNlIGlkZW50aWZpZXIgbXVzdCBub3QgYmVnaW4gd2l0aCBhIGRpZ2l0LCBhc3NpZ25tZW50Cis/ KGV2YWwpOjE6IG5vdCBhbiBpZGVudGlmaWVyOiAuMi5iCisKKyAgdHlwZXNldCAuMi5iPW5vdAor MTpOYW1lc3BhY2UgaWRlbnRpZmllciBtdXN0IG5vdCBiZWdpbiB3aXRoIGEgZGlnaXQsIHR5cGVz ZXQKKz8oZXZhbCk6dHlwZXNldDoxOiBub3QgdmFsaWQgaW4gdGhpcyBjb250ZXh0OiAuMi5iCisK KyAgcHJpbnQgJHsuMi5ifQorMTpOYW1lc3BhY2UgaWRlbnRpZmllciBtdXN0IG5vdCBiZWdpbiB3 aXRoIGEgZGlnaXQsIHJlZmVyZW5jZQorPyhldmFsKToxOiBiYWQgc3Vic3RpdHV0aW9uCisKKyAg Lm5vdC4yYj1xdWVzdGlvbgorMTpJZGVudGlmaWVyIHN0YXJ0aW5nIHdpdGggYSBkaWdpdCBtdXN0 IGJlIGFsbCBkaWdpdHMsIGFzc2lnbm1lbnQKKz8oZXZhbCk6MTogbm90IGFuIGlkZW50aWZpZXI6 IC5ub3QuMmIKKworICB0eXBlc2V0IC5ub3QuMmI9cXVlc3Rpb24KKzE6SWRlbnRpZmllciBzdGFy dGluZyB3aXRoIGEgZGlnaXQgbXVzdCBiZSBhbGwgZGlnaXRzLCB0eXBlc2V0Cis/KGV2YWwpOnR5 cGVzZXQ6MTogbm90IHZhbGlkIGluIHRoaXMgY29udGV4dDogLm5vdC4yYgorCisgIHByaW50ICR7 Lm5vdC4yYn0KKzE6SWRlbnRpZmllciBzdGFydGluZyB3aXRoIGEgZGlnaXQgbXVzdCBiZSBhbGwg ZGlnaXRzLCByZWZlcmVuY2UKKz8oZXZhbCk6MTogYmFkIHN1YnN0aXR1dGlvbgorCisgIGludGVn ZXIgLnZhci5kPTAKKyAgZmxvYXQgLnZhci5mPS4yCisgIHByaW50ICQoKC52YXIueCA9ICsrLnZh ci5kIC0gLS52YXIuZikpCiswOk5hbWVzcGFjZXMgaW4gbWF0aCBjb250ZXh0Cis+MS4yCg== --000000000000ac1b2905febb8388--