From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 14206 invoked from network); 27 May 2023 16:11:56 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 27 May 2023 16:11:56 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1685203916; b=GuON/v6rXSKEBPpeXgJufctvEfTeEi3koYhQ8czl16TXbb9V3aMgr39ivo8Ae6GEMwZ+X5moj6 xpBucEVBIoHUs8MdoFphdpR/nOYQu1s5fWjQzSWzfi6vH7IkH5DJevikM7Zl/ky0p6pPp3VbjZ 6Db43Qj5AaCK7hMxF7JEGGcOA4wO0NydVkD5ZKmuAX7UZ0UmOZt8Pf05u+7TRosjQHRQb4aFC2 /kp+/cUBOlz9SyycfS9FvHcNK0jRzn45pZLXVicXE+9MInHHCc3fNI5X0lRWh056hSNuTr/a9w ZzeMfcOjieOQa6VhMq4RdsSOMx3sK38nwX9az+5CWIjKlg==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-ed1-f54.google.com) smtp.remote-ip=209.85.208.54; dkim=pass header.d=brasslantern-com.20221208.gappssmtp.com header.s=20221208 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1685203916; bh=B7i7X1ghMEMq0pZ9MeEegxzhoU4oJag7GuNaf2TUlqQ=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:Cc:To:Subject: Message-ID:Date:From:In-Reply-To:References:MIME-Version:DKIM-Signature: DKIM-Signature; b=fKp1LNkDMcX2GRUyrJ9Ey07g7XFDsKuNgcDHO8TqZGBPQkXkiBU2PBvcJytnieOJNYFiIgGqO5 UPspMz4bbwAE1XL/c/+gtUarubiVPObi/DtHtCVsRIXiHrHi12YUdf0GmQjL5A0zgy5uqYh0Gx hGVHCpPW0k4w7Xftw2o866Ko45LN+a2USLmOt+JwjSDU93VLQvCwqD1PSPOTaAiz/Raj4n9+IV lZR0uszRbqhpCWngSO2wj3JQOXDCMfEC+xn5m3Bhfb2bsDBNFKyREDTRul03JfyTY0ZH6JcnpX IMDjqeFkQd/oIUhIQWLRGQoAvz0nQVeEA6ADuFdNUZGjeQ==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=p4o0Dq11IjKm4rZFlbdPwM9G7t+wX/Rae+ZyMfhFLwI=; b=f9Y5wSNTUNfjbtmxNriaCcYtQc uR7mPV/1X/UMfTlZxTlYT88yoxLua5mwUnCZl92PQvx9SB51yhayBbonnwbcmrGQeXz8zczxeO7dO 6MBtTXpdL4fJ4PF8bnG8IcQL7bKSG6bGX+kc6aoBUQeSuIGmuMNYD/BNpSz32FfusVp9piHxWyP+5 jXIakURM64VP7WN0sXFxxrt+SsCJOyX+8z5tCAh01he/dEwrGtgEu5X2UidQAu9zH6h91vFdWfZLr z5fYvQQ+7wrZVu/O3TyDhFVfHDHZUH9L1YtxansMLrGdAw8j0dvcXGZtOXuyd+qRlUcrMdaYGVuGh ZZ2cISKg==; Received: by zero.zsh.org with local id 1q2wWJ-0006hY-Sx; Sat, 27 May 2023 16:11:55 +0000 Authentication-Results: zsh.org; iprev=pass (mail-ed1-f54.google.com) smtp.remote-ip=209.85.208.54; dkim=pass header.d=brasslantern-com.20221208.gappssmtp.com header.s=20221208 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-ed1-f54.google.com ([209.85.208.54]:55359) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1q2wVk-0006Md-7d; Sat, 27 May 2023 16:11:21 +0000 Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-51458187be1so3036562a12.2 for ; Sat, 27 May 2023 09:11:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20221208.gappssmtp.com; s=20221208; t=1685203879; x=1687795879; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=p4o0Dq11IjKm4rZFlbdPwM9G7t+wX/Rae+ZyMfhFLwI=; b=WuKXOvdazT8Lz8U10QrCiLx6BEIPo/+p1fjra7ovTXHSy+EbrFVuRAzeR6kkt6inl8 selXpm2bynMe1V1uNi8kZRYpm3d+/NUlDbg4lL/Rc1aoG0I1YJNdRxJppPRBW6S8XVnU TNizUvxDx7+cG6RnIQkiRGUPxMEYpnxK/+1soPVuTDyzjXAdtZhQaL0drRZKlIH9/SK8 a9vFob9B2sWNwDzTtFRnJUxBPjKX1lUMlMxBriPchEtbylJ8ODdrLp/qFMFXp0lT352A qUQKMBBcJL8qJg44pYQfDtUmwi1b8IFFILWVLUgEzZe1K1Lj+/E6UfDSgYpca/aU66dl rgQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685203879; x=1687795879; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=p4o0Dq11IjKm4rZFlbdPwM9G7t+wX/Rae+ZyMfhFLwI=; b=WzAthFpcE/hdLg3aFwtGWPpcBC+AgL0zMlS+nZyCFBD/EFsroihpfY83s58FlXAmOP APyGzWekw88mP1hqLXl3YMPfVKj4C8ujK6+aipnUvXP3ZRq+JedLFSPSO7PTUEkpCCbm zx9/mTRjcGHiLxpTbHazBDb/UYN5dpwhTaiMfDvwAQq4JqyErVTis6c8bgQge6lo8r3H ZPyI+IyF/2JU7y/xC30mhQFVFL6OvRoIuudxYiGTjny2i4hOTALdGzoVLALxPLmhtUxb Afau7eB9A0dogTPqTzke6kKw3tFj2n53RXbyDaNQQeG24Wo3ID3OFTTS6DCyJwFVBQoq TTOw== X-Gm-Message-State: AC+VfDxOw4K9ANJJ3LiZogouUfO4lUZ2v2RBU7b9xjKx6bRoLkF39rUV lBKisn4+5DfvU6dM5tM4lmFpm8v1ZwmWr/wcD+lt/Q== X-Google-Smtp-Source: ACHHUZ4fBMFlM7RoU1hcr8mlkVOAIo3rexiqJqCiccfuX0DvLzvvq4b8mtgAv9KFJ4Nc34EADxfe6XxkAEmbqJfr17w= X-Received: by 2002:a17:907:6e27:b0:973:d846:cd5d with SMTP id sd39-20020a1709076e2700b00973d846cd5dmr3595302ejc.74.1685203879503; Sat, 27 May 2023 09:11:19 -0700 (PDT) MIME-Version: 1.0 References: <20230527131253.33840-1-marlon.richert@gmail.com> In-Reply-To: <20230527131253.33840-1-marlon.richert@gmail.com> From: Bart Schaefer Date: Sat, 27 May 2023 09:11:08 -0700 Message-ID: Subject: Re: [PATCH] Let _approximate work w/ possible compadd function To: Marlon Richert Cc: zsh-workers@zsh.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Seq: 51805 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: On Sat, May 27, 2023 at 6:13=E2=80=AFAM Marlon Richert wrote: > > Before this patch, if compadd had been overridden by a function of the > same name, _approximate would not do corrections. This is what _shadow was added for. I don't remember why I didn't apply it to _approximate when I did so for _complete_help, but possibly it's because those usages actually conflict, i.e., when running the help function you don't want approximate to bypass the override? Will have to think about this a bit when I have more time. The primary difference from your patch is that _shadow will handle recursive calls to the function in which it is used.