From: Bart Schaefer <schaefer@brasslantern.com>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: Ncurses declaration compatibility (52383 vs. 52398+)
Date: Sat, 30 Dec 2023 21:10:20 -0800 [thread overview]
Message-ID: <CAH+w=7YcyWhKtgQs6XE1hPbSwnSdB8Cfy1xGPCx4rxy7ZT8+ZQ@mail.gmail.com> (raw)
We have competing patches for configure failures in the face of
gcc -Werror=incompatible-pointer-types
Florian (52383) simply cast away the error in the configure script,
because the const-ness is inconsequential to Src/Modules/curses.c
usage of the arrays.
Nicholas (cf. 52398) did extra work for const correctness in the Src
code as well, but made some stylistic choices that Oliver and I found
superfluous or unhelpful.
To supply some context Nicholas did not have, users/13418 introduced
the "zstrcodes" variable because a Cygwin compiler in 2008 had issues
with (re)declaring "strcodes". However, zstrcodes was described as a
"hack" that would have been better corrected by diagnosing the reason
configure choked on strcodes. This was never done. Aside from
Oliver's stylistic objection to the use of #defines, enshrining an old
hack by changing the handling of all the other ncurses arrays to match
it, seems a step in the wrong direction.
Any volunteers, with Cygwin access, to back out users/13418 and
determine if strcodes is still broken after 15 years?
reply other threads:[~2023-12-31 5:11 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7YcyWhKtgQs6XE1hPbSwnSdB8Cfy1xGPCx4rxy7ZT8+ZQ@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).