From: Bart Schaefer <schaefer@brasslantern.com>
To: Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: Marlon Richert <marlon.richert@gmail.com>,
Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [RFC] Add xfail tests for || form of completion matchers
Date: Wed, 13 Oct 2021 13:02:39 -0700 [thread overview]
Message-ID: <CAH+w=7YeVcer4JTK4dQOPyhvw5ru=cobScp71wXwWE1JztiTYQ@mail.gmail.com> (raw)
In-Reply-To: <20211013193740.GA27436@tarpaulin.shahaf.local2>
On Wed, Oct 13, 2021 at 12:38 PM Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
>
> If you want to clarify the documentation of the feature as designed,
Just for the record, I believe that's what Marlon has done in the doc
patch. I would not apply the xfail patch in its current state (where
it removes existing tests and replaces them with xfails). Adding that
set of xfails as new tests and documenting that they represent
proposed behavior changes (without removing the existing tests) would
be preferred.
next prev parent reply other threads:[~2021-10-13 20:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 14:34 Marlon Richert
2021-10-12 12:08 ` Marlon Richert
2021-10-12 15:25 ` Daniel Shahaf
2021-10-13 4:57 ` Bart Schaefer
2021-10-13 5:08 ` Bart Schaefer
2021-10-13 14:20 ` Marlon Richert
2021-10-13 19:37 ` Daniel Shahaf
2021-10-13 20:02 ` Bart Schaefer [this message]
2021-10-14 20:25 ` Oliver Kiddle
2021-10-14 20:43 ` Oliver Kiddle
2021-10-14 21:16 ` Bart Schaefer
2021-10-22 13:02 ` Oliver Kiddle
2021-10-25 18:41 ` Marlon Richert
2021-10-25 19:41 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7YeVcer4JTK4dQOPyhvw5ru=cobScp71wXwWE1JztiTYQ@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=d.s@daniel.shahaf.name \
--cc=marlon.richert@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).